aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
* Ignore files already deleted on GCS file deletionsRosa Gutierrez2017-08-311-1/+5
| | | | | | | | Relying on the GET request issued first to fetch the file we want to delete is not enough to avoid this error. If the file is deleted after our GET request but before the DELETE request we'll get a NotFound error that after all means that the file is already deleted, so it can be safely ignored.
* RefactorGeorge Claghorn2017-08-291-12/+10
|
* Fix replacing a singular attachmentGeorge Claghorn2017-08-294-7/+50
|
* Update Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-304-9/+17
|
* Synchronously destroy attachmentsGeorge Claghorn2017-08-292-9/+7
|
* Fix order of Active Storage DiskService URL parametersKoichi ITO2017-08-262-2/+2
| | | | `content_type` parameter is before `disposition` parameter.
* Enable links in Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-262-2/+2
|
* Fix link in doc for active storage [ci skip]Yoshiyuki Hirano2017-08-251-1/+1
|
* Widen blob size columnGeorge Claghorn2017-08-241-1/+1
|
* Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-231-3/+3
|\ | | | | | | Do not generate default alt text for images
| * Do not generate default alt text in image tagsCameron Cundiff2017-08-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | Use 5.2 version of ActiveRecord::Migration for Active Storagebogdanvlviv2017-08-222-2/+2
| |
* | Merge pull request #30356 from ↵Kasper Timm Hansen2017-08-221-2/+0
|\ \ | | | | | | | | | | | | bogdanvlviv/remove-frozen_string_literal-from-blob-migration Remove frozen_string_literal comment from activestorage's migration
| * | Remove frozen_string_literal comment from activestorage's migrationbogdanvlviv2017-08-221-2/+0
| | | | | | | | | | | | | | | The activestorage's migration is used as template for apps Related to #30348
* | | Add frozen string literal pragmaGeorge Claghorn2017-08-211-0/+2
| | |
* | | Encode Content-Disposition filenames according to RFC 2231George Claghorn2017-08-216-4/+74
|/ / | | | | | | Closes #30134.
* | Update regexGeorge Claghorn2017-08-201-1/+1
| |
* | Fix testsGeorge Claghorn2017-08-204-4/+4
| |
* | Fix syntax errorGeorge Claghorn2017-08-201-1/+1
| |
* | DRYGeorge Claghorn2017-08-208-16/+20
| |
* | Rename ActiveStorage::Filename#extname to extension_with_delimiterGeorge Claghorn2017-08-202-9/+29
| |
* | Add executable file `activestorage/bin/test`bogdanvlviv2017-08-201-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | ``` rails$ cd activestorage/ rails/activestorage$ bin/test ........(compressed).... rails/activestorage$ bin/test test/controllers/disk_controller_test.rb .(compressed).. rails/activestorage$ bin/test test/controllers/disk_controller_test.rb:42 . ```
* | Remove Active Storage code climate config fileJon Moss2017-08-181-7/+0
| | | | | | | | There's already a .codeclimate.yml file at the root of the project.
* | Merge pull request #30292 from maclover7/jm-ast-purgeGeorge Claghorn2017-08-171-0/+7
|\ \ | | | | | | Add missing test for Blob#purge
| * | Add missing test for Blob#purgeJon Moss2017-08-171-0/+7
| |/
* / Use nil Logger for testsJon Moss2017-08-171-1/+1
|/ | | | | | | | | | | | | | | | Makes tests much more quietly, as opposed to the enormous amount of logging that appears right now. This setting is used in AJ, as well as other frameworks. Output from test run: ``` ......................................................... Finished in 3.003355s, 18.9788 runs/s, 45.2827 assertions/s. 57 runs, 136 assertions, 0 failures, 0 errors, 0 skips ```
* Merge pull request #30280 from koic/change_namespace_of_active_storage_rake_taskRyuta Kamizono2017-08-161-1/+1
|\ | | | | Change namespace of Active Storage rake task
| * Change namespace of Active Storage rake taskKoichi ITO2017-08-161-1/+1
| |
* | Fix RuboCop offensesKoichi ITO2017-08-161-2/+2
|/ | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* restores some double newlines deleted in ae87217Xavier Noria2017-08-153-0/+6
| | | | | | These were intentional, see https://github.com/rails/rails/pull/30061#issuecomment-320068368
* minor tweaks in Active Storage after a walkthroughXavier Noria2017-08-1515-48/+59
|
* Move test to its proper placeGeorge Claghorn2017-08-141-0/+0
| | | | ActiveStorage::Filename is a model, so its test case belongs in test/models.
* Run Active Storage service tests in CIGeorge Claghorn2017-08-141-0/+0
|
* Should escape regexp wildcard character `.`Koichi ITO2017-08-143-4/+4
|
* Merge pull request #30211 from koic/frozen_activestorageMatthew Draper2017-08-1374-4/+148
|\ | | | | Use frozen string literal in Active Storage
| * Use frozen string literal in Active StorageKoichi ITO2017-08-1274-4/+148
| |
* | Use `references` to respect primary key type in active storage tablesRyuta Kamizono2017-08-131-5/+3
|/ | | | | | If created active storage tables by mysql2 or postgresql adapters, a primary key is defined as a bigint. It should be used `references` to the reference columns to respect primary key type.
* Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-fileRafael França2017-08-112-2/+8
|\ | | | | Activestorage rack test uploaded file
| * Make activestorage treat Rack::Test::UploadedFile just like ↵Isaac Betesh2017-08-112-2/+8
| | | | | | | | ActionDispatch::Http::UploadedFile
* | Merge pull request #30147 from yhirano55/fix_trailing_blank_linesRafael França2017-08-112-2/+0
|\ \ | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
| * | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`Yoshiyuki Hirano2017-08-093-3/+1
| | |
* | | Merge pull request #30113 from dixpac/remove_unecessary_require_in_test_helperRafael França2017-08-111-2/+0
|\ \ \ | | | | | | | | ActiveStorage: Remove unnecessary require in test_helper
| * | | Remove unecessary require in test_helperdixpac2017-08-091-2/+0
| |/ /
* | | Remove unnedded Active Storage installation stepsRafael Mendonça França2017-08-111-8/+0
| | | | | | | | | | | | | | | Active Storage was now merged to master and it is automatically installed in a new application.
* | | Merge pull request #30201 from ↵Rafael França2017-08-111-12/+8
|\ \ \ | | | | | | | | | | | | | | | | kamipo/eval_active_storage_attached_name_only_once Evaluate `@active_storage_attached_#{name}` only once
| * | | Evaluate `@active_storage_attached_#{name}` only onceRyuta Kamizono2017-08-121-12/+8
| | | | | | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once.
* | | | Merge pull request #30202 from kamipo/add_null_false_to_active_storage_tablesRafael França2017-08-111-10/+10
|\ \ \ \ | | | | | | | | | | Add `null: false` to Active Storage tables
| * | | | Add `null: false` to Active Storage tablesRyuta Kamizono2017-08-121-10/+10
| |/ / / | | | | | | | | | | | | These columns aren't intended nullable.
* / / / Enable browser caching for blobs and variants (#30196)Anton Khamets2017-08-113-0/+17
|/ / /
* | | Microsoft Azure --> Microsoft Azure Storage [ci skip]Ryuta Kamizono2017-08-121-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 08:02:50 +0000