aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
* Use `require_relative` instead of `require` with full path in activestorage/bogdanvlviv2017-10-131-1/+1
| | | | Related to #29417
* Define path with __dir__ in activestorage/bogdanvlviv2017-10-133-4/+4
| | | | Related to #29176
* Clarify comment [ci skip]George Claghorn2017-10-131-1/+1
|
* Accept variation keys in #preview and #variantGeorge Claghorn2017-10-122-7/+12
|
* Introduce ActiveStorage::Blob#representationGeorge Claghorn2017-10-124-0/+73
|
* Replace variation key use with SHA256 of key to prevent long filenameskhall2017-10-052-1/+6
| | | | | | | If a variant has a large set of options associated with it, the generated filename will be too long, causing Errno::ENAMETOOLONG to be raised. This change replaces those potentially long filenames with a much more compact SHA256 hash. Fixes #30662.
* Fix third-party system libraries list in ActiveStorage::Preview [ci skip]Yoshiyuki Hirano2017-10-041-2/+2
|
* Associate blobs with their attachmentsGeorge Claghorn2017-10-031-0/+2
|
* Fix `test "signed URL generation"` failureRyuta Kamizono2017-09-301-1/+1
| | | | https://travis-ci.org/rails/rails/jobs/281044755#L5582-L5586
* Fix "warning: `*' interpreted as argument prefix"Ryuta Kamizono2017-09-301-1/+1
|
* Preview PDFs and videosGeorge Claghorn2017-09-2835-68/+436
|
* Set version in activestorage/package.json in proper format.bogdanvlviv2017-09-271-1/+1
| | | | | | `5.2.0.alpha` => `5.2.0-alpha` System versioning isn't compliant with npm.
* Fixed broken `bundle exec rake install`yalab2017-09-261-0/+2
|
* Add missing word [ci skip]George Claghorn2017-09-201-1/+1
|
* Flesh out ActiveStorage::Filename docsGeorge Claghorn2017-09-201-6/+14
|
* Merge pull request #30629 from yhirano55/add_scope_to_has_one_attached_macroEileen M. Uchitelle2017-09-202-0/+19
|\ | | | | Add `with_attached_*` scope to `has_one_attached` macro
| * Add `with_attached_*` scope to `has_one_attached` macroYoshiyuki Hirano2017-09-192-0/+19
| | | | | | | | | | * For avoiding N+1 problem, added `with_attached_*` scope to `has_one_attached` macro.
* | Remove unused require in ActiveStorage::VariationYoshiyuki Hirano2017-09-181-2/+0
|/
* Merge pull request #30628 from yhirano55/add_local_option_to_message_formRyuta Kamizono2017-09-171-1/+1
|\ | | | | Add local option to Message form [ci skip]
| * Add local option to Message form [ci skip]Yoshiyuki Hirano2017-09-171-1/+1
| | | | | | | | | | | | | | * MessagesController redirects to `GET /message/:id`. * It looks it don't expect XHR request. * `form_with` behaves for XHR by default. * I've added `local: true` option to `form_with`.
* | Fix file missing in activestorage's example code [ci skip]Yoshiyuki Hirano2017-09-173-3/+3
|/ | | | | * File.open("~/face.jpg") raise error: `Errno::ENOENT: No such file or directory @ rb_sysopen - ~/face.jpg`
* Don't expose Active Storage routesyuuji.yaginuma2017-09-161-5/+5
| | | | | | | These routes are only used internally in Active Storage, and it seems that there is no need for the user to directly use them. Therefore, I think that routes should not be exposed to users.
* Avoid making HTTP requests to generate signed URLs for GCS objectsGeorge Claghorn2017-09-131-3/+3
|
* Fix activestorage direct upload on firefox_N_I_X_O_N_2017-09-123-1/+3
| | | | | | | | Direct upload on firefox is not working because it can’t handle click events on “input[type=submit]”. After a successful upload we can see on console a xml parse error, it happens because AWS S3 success body response is empty, so changing the reponseType suppress this error.
* Rename activestorage/test/service/configurations.yml to ↵George Claghorn2017-09-111-0/+0
| | | | activestorage/test/service/configurations.example.yml
* Add credentials using a generic EncryptedConfiguration class (#30067)David Heinemeier Hansson2017-09-111-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP: Add credentials using a generic EncryptedConfiguration class This is sketch code so far. * Flesh out EncryptedConfiguration and test it * Better name * Add command and generator for credentials * Use the Pathnames * Extract EncryptedFile from EncryptedConfiguration and add serializers * Test EncryptedFile * Extract serializer validation * Stress the point about losing comments * Allow encrypted configuration to be read without parsing for display * Use credentials by default and base them on the master key * Derive secret_key_base in test/dev, source it from credentials in other envs And document the usage. * Document the new credentials setup * Stop generating the secrets.yml file now that we have credentials * Document what we should have instead Still need to make it happen, tho. * [ci skip] Keep wording to `key base`; prefer defaults. Usually we say we change defaults, not "spec" out a release. Can't use backticks in our sdoc generated documentation either. * Abstract away OpenSSL; prefer MessageEncryptor. * Spare needless new when raising. * Encrypted file test shouldn't depend on subclass. * [ci skip] Some woordings. * Ditch serializer future coding. * I said flip it. Flip it good. * [ci skip] Move require_master_key to the real production.rb. * Add require_master_key to abort the boot process. In case the master key is required in a certain environment we should inspect that the key is there and abort if it isn't. * Print missing key message and exit immediately. Spares us a lengthy backtrace and prevents further execution. I've verified the behavior in a test app, but couldn't figure the test out as loading the app just exits immediately with: ``` /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError) from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start' ``` It's likely we need to capture and prevent the exit somehow. Kernel.stub(:exit) didn't work. Leaving it for tomorrow. * Fix require_master_key config test. Loading the app would trigger the `exit 1` per require_master_key's semantics, which then aborted the test. Fork and wait for the child process to finish, then inspect the exit status. Also check we aborted because of a missing master key, so something else didn't just abort the boot. Much <3 to @tenderlove for the tip. * Support reading/writing configs via methods. * Skip needless deep symbolizing. * Remove save; test config reader elsewhere. * Move secret_key_base check to when we're reading it. Otherwise we'll abort too soon since we don't assign the secret_key_base to secrets anymore. * Add missing string literal comments; require unneeded yaml require. * ya ya ya, rubocop. * Add master_key/credentials after bundle. Then we can reuse the existing message on `rails new bc4`. It'll look like: ``` Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb) Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails` Using sass-rails 5.0.6 Bundle complete! 16 Gemfile dependencies, 72 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0 Save this in a password manager your team can access. If you lose the key, no one, including you, can access anything encrypted with it. create config/master.key ``` And that'll be executed even if `--skip-bundle` was passed. * Ensure test app has secret_key_base. * Assign secret_key_base to app or omit. * Merge noise * Split options for dynamic delegation into its own method and use deep symbols to make it work * Update error to point to credentials instead * Appease Rubocop * Validate secret_key_base when reading it. Instead of relying on the validation in key_generator move that into secret_key_base itself. * Fix generator and secrets test. Manually add config.read_encrypted_secrets since it's not there by default anymore. Move mentions of config/secrets.yml to config/credentials.yml.enc. * Remove files I have no idea how they got here. * [ci skip] swap secrets for credentials. * [ci skip] And now, changelogs are coming.
* Use v3 of the AWS SDKYuji Yaginuma2017-09-091-3/+3
|
* Accept GCS client optionsGeorge Claghorn2017-09-011-2/+2
|
* Have attachments touch their recordsGeorge Claghorn2017-08-311-1/+1
|
* Ignore files already deleted on GCS file deletionsRosa Gutierrez2017-08-311-1/+5
| | | | | | | | Relying on the GET request issued first to fetch the file we want to delete is not enough to avoid this error. If the file is deleted after our GET request but before the DELETE request we'll get a NotFound error that after all means that the file is already deleted, so it can be safely ignored.
* RefactorGeorge Claghorn2017-08-291-12/+10
|
* Fix replacing a singular attachmentGeorge Claghorn2017-08-294-7/+50
|
* Update Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-304-9/+17
|
* Synchronously destroy attachmentsGeorge Claghorn2017-08-292-9/+7
|
* Fix order of Active Storage DiskService URL parametersKoichi ITO2017-08-262-2/+2
| | | | `content_type` parameter is before `disposition` parameter.
* Enable links in Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-262-2/+2
|
* Fix link in doc for active storage [ci skip]Yoshiyuki Hirano2017-08-251-1/+1
|
* Widen blob size columnGeorge Claghorn2017-08-241-1/+1
|
* Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-231-3/+3
|\ | | | | | | Do not generate default alt text for images
| * Do not generate default alt text in image tagsCameron Cundiff2017-08-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | Use 5.2 version of ActiveRecord::Migration for Active Storagebogdanvlviv2017-08-222-2/+2
| |
* | Merge pull request #30356 from ↵Kasper Timm Hansen2017-08-221-2/+0
|\ \ | | | | | | | | | | | | bogdanvlviv/remove-frozen_string_literal-from-blob-migration Remove frozen_string_literal comment from activestorage's migration
| * | Remove frozen_string_literal comment from activestorage's migrationbogdanvlviv2017-08-221-2/+0
| | | | | | | | | | | | | | | The activestorage's migration is used as template for apps Related to #30348
* | | Add frozen string literal pragmaGeorge Claghorn2017-08-211-0/+2
| | |
* | | Encode Content-Disposition filenames according to RFC 2231George Claghorn2017-08-216-4/+74
|/ / | | | | | | Closes #30134.
* | Update regexGeorge Claghorn2017-08-201-1/+1
| |
* | Fix testsGeorge Claghorn2017-08-204-4/+4
| |
* | Fix syntax errorGeorge Claghorn2017-08-201-1/+1
| |
* | DRYGeorge Claghorn2017-08-208-16/+20
| |
* | Rename ActiveStorage::Filename#extname to extension_with_delimiterGeorge Claghorn2017-08-202-9/+29
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 22:43:45 +0000