| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Permit creating a record and attaching files in a single step.
# Before:
User.create!(user_params.except(:avatar)).tap do |user|
user.avatar.attach(user_params[:avatar])
end
# After:
User.create!(user_params)
[Yoshiyuki Hirano & George Claghorn]
|
| |
|
|
|
|
|
|
|
|
| |
Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens.
Closes #30290.
[Shinichi Maeshima & George Claghorn]
|
|
|
|
| |
Closes #31164.
|
|
|
|
| |
Due to https://github.com/rack-test/rack-test/commit/5fd3631078e7c73aaed7d4371f70fb2a79384be9.
|
| |
|
|
|
|
| |
Closes #31138.
|
|
|
| |
Closes #31073.
|
| |
|
|
|
|
| |
Related to #29417
|
|
|
|
| |
Related to #29176
|
| |
|
|
|
|
|
|
|
| |
If a variant has a large set of options associated with it, the generated
filename will be too long, causing Errno::ENAMETOOLONG to be raised. This
change replaces those potentially long filenames with a much more compact
SHA256 hash. Fixes #30662.
|
|
|
|
| |
https://travis-ci.org/rails/rails/jobs/281044755#L5582-L5586
|
| |
|
|
|
|
|
| |
* For avoiding N+1 problem, added `with_attached_*` scope to
`has_one_attached` macro.
|
|
|
|
| |
activestorage/test/service/configurations.example.yml
|
| |
|
|
|
|
| |
`content_type` parameter is before `disposition` parameter.
|
|\
| |
| |
| | |
Do not generate default alt text for images
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
|
| | |
|
| |
| |
| |
| | |
Closes #30134.
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Add missing test for Blob#purge
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes tests much more quietly, as opposed to the enormous amount of
logging that appears right now. This setting is used in AJ, as well as
other frameworks.
Output from test run:
```
.........................................................
Finished in 3.003355s, 18.9788 runs/s, 45.2827 assertions/s.
57 runs, 136 assertions, 0 failures, 0 errors, 0 skips
```
|
|
|
|
| |
ActiveStorage::Filename is a model, so its test case belongs in test/models.
|
| |
|
| |
|
| |
|
|\
| |
| | |
Activestorage rack test uploaded file
|
| |
| |
| |
| | |
ActionDispatch::Http::UploadedFile
|
|\ \
| | |
| | | |
ActiveStorage: Remove unnecessary require in test_helper
|
| | | |
|
| |/
|/| |
|
|/ |
|
|\
| |
| | |
ActiveStorage:Filter out Minitest backtrace.
|
| |
| |
| |
| |
| | |
Filter out Minitest backtrace while allowing backtrace from other
libraries to be shown.
|
|\ \
| | |
| | |
| | | |
Support content_type in AzureStorageService#url
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add in the content_type option, which is defined as part of the generic
ActiveStorage::Service class.
Without this option, attempts to generate a URL for an attached file
fail with "ArgumentError (unknown keyword: content_type)"
|
|/ /
| |
| |
| |
| |
| | |
* Add migrations per rails engine conventions
* Fix failing tests
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Extend image_tag to accept ActiveStorage's Attachments and Variants
* Flip resolve_image_source around
* Add tests for the new use-cases of image_tag
* Remove the higher-level test
* Update image_tag documentation
* Add error states into the test suite
* Re-raise polymorhic_url's NoMethodError as ArgumentError
* delegate_missing_to will raise DelegationError instead of NoMethodError
|
|
|
|
|
|
|
|
|
|
| |
This fixes following warnings:
```
test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator
lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized
lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized
```
|
| |
|
|
|
|
|
|
|
|
|
| |
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical
URL for an object will start with "https://s3.amazonaws.com/bucket.name/"
and not with "https://bucket.name.s3.amazonaws.com/".
The URL tests have now been separated into two separate asserts, to ensure
that both the "s3.amazonaws.com" and the "bucket.name" components are included,
but not specifically in that order.
|