Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the future | Ryuta Kamizono | 2017-12-14 | 1 | -4/+0 |
| | | | | Follow up of #31432. | ||||
* | Swap raw video width and height if angle is 90 or 270 degrees | George Claghorn | 2017-12-08 | 1 | -2/+2 |
| | |||||
* | Fix customizing Content-Type via GCS service URLs | George Claghorn | 2017-12-07 | 1 | -0/+14 |
| | |||||
* | Purge variants with their blobs | George Claghorn | 2017-12-02 | 2 | -1/+26 |
| | |||||
* | Use `credentials` instead of `keyfile` in GCS sevice | yuuji.yaginuma | 2017-11-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802 | ||||
* | Avoid connecting to GCS during app boot | George Claghorn | 2017-11-23 | 1 | -7/+2 |
| | |||||
* | Provide attachment writers | George Claghorn | 2017-11-20 | 1 | -0/+32 |
| | | | | | | | | | | | | | Permit creating a record and attaching files in a single step. # Before: User.create!(user_params.except(:avatar)).tap do |user| user.avatar.attach(user_params[:avatar]) end # After: User.create!(user_params) [Yoshiyuki Hirano & George Claghorn] | ||||
* | Load 5.2 defaults in ASt dummy app | George Claghorn | 2017-11-20 | 1 | -1/+1 |
| | |||||
* | Fix direct uploads to local service | George Claghorn | 2017-11-20 | 2 | -0/+4 |
| | | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn] | ||||
* | Permit attaching files to new records | George Claghorn | 2017-11-19 | 1 | -0/+44 |
| | | | | Closes #31164. | ||||
* | Fix ASt CI failure with rack-test 0.7.1 | Ryuta Kamizono | 2017-11-20 | 1 | -1/+1 |
| | | | | Due to https://github.com/rack-test/rack-test/commit/5fd3631078e7c73aaed7d4371f70fb2a79384be9. | ||||
* | Introduce ActiveStorage::Attached::{One,Many}#detach | George Claghorn | 2017-11-14 | 1 | -0/+26 |
| | |||||
* | Preserve existing metadata when analyzing a blob | George Claghorn | 2017-11-13 | 2 | -2/+27 |
| | | | | Closes #31138. | ||||
* | Fix streaming downloads from S3/Azure Storage | George Claghorn | 2017-11-06 | 1 | -0/+10 |
| | | | Closes #31073. | ||||
* | Extract metadata from images and videos | George Claghorn | 2017-10-22 | 8 | -5/+117 |
| | |||||
* | Use `require_relative` instead of `require` with full path in activestorage/ | bogdanvlviv | 2017-10-13 | 1 | -1/+1 |
| | | | | Related to #29417 | ||||
* | Define path with __dir__ in activestorage/ | bogdanvlviv | 2017-10-13 | 3 | -4/+4 |
| | | | | Related to #29176 | ||||
* | Introduce ActiveStorage::Blob#representation | George Claghorn | 2017-10-12 | 2 | -0/+43 |
| | |||||
* | Replace variation key use with SHA256 of key to prevent long filenames | khall | 2017-10-05 | 1 | -0/+5 |
| | | | | | | | If a variant has a large set of options associated with it, the generated filename will be too long, causing Errno::ENAMETOOLONG to be raised. This change replaces those potentially long filenames with a much more compact SHA256 hash. Fixes #30662. | ||||
* | Fix `test "signed URL generation"` failure | Ryuta Kamizono | 2017-09-30 | 1 | -1/+1 |
| | | | | https://travis-ci.org/rails/rails/jobs/281044755#L5582-L5586 | ||||
* | Preview PDFs and videos | George Claghorn | 2017-09-28 | 16 | -17/+128 |
| | |||||
* | Add `with_attached_*` scope to `has_one_attached` macro | Yoshiyuki Hirano | 2017-09-19 | 1 | -0/+13 |
| | | | | | * For avoiding N+1 problem, added `with_attached_*` scope to `has_one_attached` macro. | ||||
* | Rename activestorage/test/service/configurations.yml to ↵ | George Claghorn | 2017-09-11 | 1 | -0/+0 |
| | | | | activestorage/test/service/configurations.example.yml | ||||
* | Fix replacing a singular attachment | George Claghorn | 2017-08-29 | 1 | -0/+25 |
| | |||||
* | Fix order of Active Storage DiskService URL parameters | Koichi ITO | 2017-08-26 | 1 | -1/+1 |
| | | | | `content_type` parameter is before `disposition` parameter. | ||||
* | Merge pull request #30213 from ckundo/ccundiff-alt-text-default | Rafael Mendonça França | 2017-08-23 | 1 | -3/+3 |
|\ | | | | | | | Do not generate default alt text for images | ||||
| * | Do not generate default alt text in image tags | Cameron Cundiff | 2017-08-17 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096] | ||||
* | | Use 5.2 version of ActiveRecord::Migration for Active Storage | bogdanvlviv | 2017-08-22 | 1 | -1/+1 |
| | | |||||
* | | Encode Content-Disposition filenames according to RFC 2231 | George Claghorn | 2017-08-21 | 3 | -3/+35 |
| | | | | | | | | Closes #30134. | ||||
* | | Update regex | George Claghorn | 2017-08-20 | 1 | -1/+1 |
| | | |||||
* | | Fix tests | George Claghorn | 2017-08-20 | 4 | -4/+4 |
| | | |||||
* | | DRY | George Claghorn | 2017-08-20 | 2 | -3/+3 |
| | | |||||
* | | Rename ActiveStorage::Filename#extname to extension_with_delimiter | George Claghorn | 2017-08-20 | 1 | -0/+18 |
| | | |||||
* | | Merge pull request #30292 from maclover7/jm-ast-purge | George Claghorn | 2017-08-17 | 1 | -0/+7 |
|\ \ | | | | | | | Add missing test for Blob#purge | ||||
| * | | Add missing test for Blob#purge | Jon Moss | 2017-08-17 | 1 | -0/+7 |
| |/ | |||||
* / | Use nil Logger for tests | Jon Moss | 2017-08-17 | 1 | -1/+1 |
|/ | | | | | | | | | | | | | | | | Makes tests much more quietly, as opposed to the enormous amount of logging that appears right now. This setting is used in AJ, as well as other frameworks. Output from test run: ``` ......................................................... Finished in 3.003355s, 18.9788 runs/s, 45.2827 assertions/s. 57 runs, 136 assertions, 0 failures, 0 errors, 0 skips ``` | ||||
* | Move test to its proper place | George Claghorn | 2017-08-14 | 1 | -0/+0 |
| | | | | ActiveStorage::Filename is a model, so its test case belongs in test/models. | ||||
* | Run Active Storage service tests in CI | George Claghorn | 2017-08-14 | 1 | -0/+0 |
| | |||||
* | Should escape regexp wildcard character `.` | Koichi ITO | 2017-08-14 | 3 | -4/+4 |
| | |||||
* | Use frozen string literal in Active Storage | Koichi ITO | 2017-08-12 | 45 | -3/+89 |
| | |||||
* | Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-file | Rafael França | 2017-08-11 | 1 | -1/+7 |
|\ | | | | | Activestorage rack test uploaded file | ||||
| * | Make activestorage treat Rack::Test::UploadedFile just like ↵ | Isaac Betesh | 2017-08-11 | 1 | -1/+7 |
| | | | | | | | | ActionDispatch::Http::UploadedFile | ||||
* | | Merge pull request #30113 from dixpac/remove_unecessary_require_in_test_helper | Rafael França | 2017-08-11 | 1 | -2/+0 |
|\ \ | | | | | | | ActiveStorage: Remove unnecessary require in test_helper | ||||
| * | | Remove unecessary require in test_helper | dixpac | 2017-08-09 | 1 | -2/+0 |
| | | | |||||
* | | | Enable browser caching for blobs and variants (#30196) | Anton Khamets | 2017-08-11 | 1 | -0/+15 |
| |/ |/| | |||||
* | | Run Active Storage tests in CI (#30144) | George Claghorn | 2017-08-10 | 4 | -20/+18 |
|/ | |||||
* | Merge pull request #30112 from dixpac/filter_minitest_backtrace | Rafael França | 2017-08-08 | 1 | -0/+4 |
|\ | | | | | ActiveStorage:Filter out Minitest backtrace. | ||||
| * | Filter out Minitest backtrace. | dixpac | 2017-08-07 | 1 | -0/+4 |
| | | | | | | | | | | Filter out Minitest backtrace while allowing backtrace from other libraries to be shown. | ||||
* | | Merge pull request #30135 from ffmike/azure-storage-fix-content-type | Rafael Mendonça França | 2017-08-08 | 1 | -1/+8 |
|\ \ | | | | | | | | | | Support content_type in AzureStorageService#url | ||||
| * | | Support content_type in AzureStorageService#url | Mike Gunderloy | 2017-08-08 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)" |