Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Fix syntax error | George Claghorn | 2017-08-20 | 1 | -1/+1 | |
| | ||||||
* | DRY | George Claghorn | 2017-08-20 | 4 | -10/+14 | |
| | ||||||
* | Merge pull request #30280 from koic/change_namespace_of_active_storage_rake_task | Ryuta Kamizono | 2017-08-16 | 1 | -1/+1 | |
|\ | | | | | Change namespace of Active Storage rake task | |||||
| * | Change namespace of Active Storage rake task | Koichi ITO | 2017-08-16 | 1 | -1/+1 | |
| | | ||||||
* | | Fix RuboCop offenses | Koichi ITO | 2017-08-16 | 1 | -2/+2 | |
|/ | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop. | |||||
* | minor tweaks in Active Storage after a walkthrough | Xavier Noria | 2017-08-15 | 8 | -9/+9 | |
| | ||||||
* | Use frozen string literal in Active Storage | Koichi ITO | 2017-08-12 | 16 | -1/+33 | |
| | ||||||
* | Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-file | Rafael França | 2017-08-11 | 1 | -1/+1 | |
|\ | | | | | Activestorage rack test uploaded file | |||||
| * | Make activestorage treat Rack::Test::UploadedFile just like ↵ | Isaac Betesh | 2017-08-11 | 1 | -1/+1 | |
| | | | | | | | | ActionDispatch::Http::UploadedFile | |||||
* | | Merge pull request #30147 from yhirano55/fix_trailing_blank_lines | Rafael França | 2017-08-11 | 2 | -2/+0 | |
|\ \ | | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines` | |||||
| * | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines` | Yoshiyuki Hirano | 2017-08-09 | 3 | -3/+1 | |
| | | | ||||||
* | | | Evaluate `@active_storage_attached_#{name}` only once | Ryuta Kamizono | 2017-08-12 | 1 | -12/+8 | |
| | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once. | |||||
* | | | Fix formatting of Active Storage docs [ci skip] | Koichi ITO | 2017-08-11 | 2 | -2/+2 | |
| | | | | | | | | | | | | Follow up of #30188. | |||||
* | | | Fix formatting of Active Storage docs [ci skip] | yuuji.yaginuma | 2017-08-11 | 9 | -36/+36 | |
| |/ |/| | | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link | |||||
* | | Isolate ActiveStorage namespaces (#30095) | Dino Maric | 2017-08-10 | 2 | -1/+3 | |
|/ | | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric] | |||||
* | Merge pull request #30118 from georgeclaghorn/active-storage-load-hooks | Rafael França | 2017-08-08 | 1 | -16/+15 | |
|\ | | | | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded | |||||
| * | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded | George Claghorn | 2017-08-08 | 1 | -16/+15 | |
| | | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded. | |||||
* | | Merge pull request #30135 from ffmike/azure-storage-fix-content-type | Rafael Mendonça França | 2017-08-08 | 1 | -2/+3 | |
|\ \ | |/ |/| | | | Support content_type in AzureStorageService#url | |||||
| * | Support content_type in AzureStorageService#url | Mike Gunderloy | 2017-08-08 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)" | |||||
* | | ActiveStorage:Add migrations per rails engine conventions (#30111) | Dino Maric | 2017-08-08 | 2 | -36/+2 | |
|/ | | | | | | * Add migrations per rails engine conventions * Fix failing tests | |||||
* | Merge branch 'master' into ast-module | David Heinemeier Hansson | 2017-08-05 | 4 | -7/+13 | |
|\ | ||||||
| * | Merge pull request #30081 from y-yagi/fix_ruby_warnings | David Heinemeier Hansson | 2017-08-05 | 1 | -2/+8 | |
| |\ | | | | | | | Fix ruby warnings | |||||
| | * | Fix ruby warnings | yuuji.yaginuma | 2017-08-05 | 1 | -2/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ``` | |||||
| * | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-base | David Heinemeier Hansson | 2017-08-05 | 1 | -1/+1 | |
| |\ \ | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | |||||
| | * | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | George Claghorn | 2017-08-05 | 1 | -1/+1 | |
| | |/ | | | | | | | | | | By default, apps only have the former set. | |||||
| * | | Merge pull request #30083 from ↵ | David Heinemeier Hansson | 2017-08-05 | 1 | -2/+2 | |
| |\ \ | | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha | |||||
| | * | | Change gem version of Active Storage to 5.2.0.alpha | Koichi ITO | 2017-08-05 | 1 | -2/+2 | |
| | |/ | ||||||
| * / | Remove unecesarry exception variable | dixpac | 2017-08-05 | 1 | -1/+1 | |
| |/ | ||||||
* / | `module ActiveStorage`, not `ActiveStorage::Class` | claudiob | 2017-08-04 | 12 | -660/+685 | |
|/ | | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png"> | |||||
* | Rename Azure to AzureStorage (#30057) | Dino Maric | 2017-08-04 | 3 | -3/+3 | |
| | ||||||
* | Do not change the entire codebase style only because of active_storage | Rafael Mendonça França | 2017-08-03 | 1 | -4/+2 | |
| | | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places. | |||||
* | Fix all rubocop violations | Rafael Mendonça França | 2017-08-03 | 1 | -2/+4 | |
| | ||||||
* | We need to require the top file before individual one | Rafael Mendonça França | 2017-08-03 | 1 | -0/+1 | |
| | ||||||
* | Do not eager load ActiveRecord::Base | Rafael Mendonça França | 2017-08-03 | 1 | -3/+0 | |
| | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them. | |||||
* | Can't initialize a message verifier without a key base | David Heinemeier Hansson | 2017-08-03 | 1 | -1/+3 | |
| | ||||||
* | Add Azure to the available services list | Rolandas Barysas | 2017-08-02 | 1 | -0/+1 | |
| | ||||||
* | Follow same format as action_cable | David Heinemeier Hansson | 2017-08-01 | 1 | -1/+3 | |
| | ||||||
* | Directory and config installation now done by app_generator | David Heinemeier Hansson | 2017-07-31 | 1 | -7/+0 | |
| | ||||||
* | Follow form from actioncable | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+4 | |
| | ||||||
* | Use config/storage.yml as part of the skeleton and loading | David Heinemeier Hansson | 2017-07-31 | 2 | -2/+2 | |
| | ||||||
* | Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58' | Rafael Mendonça França | 2017-07-31 | 18 | -0/+1033 | |
git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58 |