aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/lib
Commit message (Collapse)AuthorAgeFilesLines
* Instrument preview image drawingGeorge Claghorn2018-01-101-3/+5
|
* Add missing `# frozen_string_literal: true`Ryuta Kamizono2018-01-111-0/+2
|
* Extract Analyzable and Representable concernsGeorge Claghorn2018-01-102-0/+7
|
* Change Active Storage destroy callbackskami-zh2018-01-091-2/+2
| | | | | There is concern that only blob are deleted depending on the `before_destroy` definition order which throws abort.
* Fix attaching blobs to optimistically-locked recordsGeorge Claghorn2018-01-081-2/+2
| | | | | | Explicitly declare inverse associations so ActiveStorage::Attachment touches the original record instance. Closes #31542.
* Document automatic width-height swapping [ci skip]George Claghorn2018-01-071-0/+2
|
* Remove redundant sentences [ci skip]George Claghorn2018-01-072-4/+2
|
* Tweak engine for readabilityGeorge Claghorn2018-01-071-11/+13
|
* Force content disposition to attachment for specific content typesRosa Gutierrez2018-01-052-0/+12
| | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable.
* Configure previewer/analyzer command paths centrallyGeorge Claghorn2018-01-035-23/+15
|
* Merge pull request #31606 from yhirano55/bump_license_years_for_2018Arun Agrawal2017-12-311-1/+1
|\ | | | | Bump license years for 2018
| * Bump license years for 2018Yoshiyuki Hirano2017-12-311-1/+1
| |
* | Expose ActiveStorage::Analyzer#logger in API docs [ci skip]George Claghorn2017-12-311-1/+1
| | | | | | | | Clarify that it's public API and may be used in third-party analyzers.
* | Expose ActiveStorage::Previewer#logger in API docs [ci skip]George Claghorn2017-12-311-2/+2
| | | | | | | | Clarify that it's public API intended for use by third-party previewers. It shouldn't be removed without deprecation even though it isn't used by the built-in previewers.
* | Suppress noise from drawing command invocationsGeorge Claghorn2017-12-311-1/+1
| |
* | Append extension to tempfile nameGeorge Claghorn2017-12-311-1/+1
|/ | | | | | Fixes analyzing an SVG image without an XML declaration. ImageMagick occasionally looks to the extension when it can't discern the type of an image file from its contents. References #31356.
* Restrict variants to variable image blobsGeorge Claghorn2017-12-152-0/+3
|
* Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-142-2/+6
|\
| * Merge pull request #31391 from ↵Eileen M. Uchitelle2017-12-131-1/+5
| |\ | | | | | | | | | | | | 5t111111/fix-active_storage-installation-failure-in-engine Fix active_storage installation failure when in engine
| | * Invoke app-prefixed active storage task when in engineHirofumi Wakasugi2017-12-131-1/+5
| | |
| * | Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`Yoshiyuki Hirano2017-12-121-1/+1
| |/ | | | | | | | | | | | | * If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this.
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-0812-35/+135
|\|
| * Swap raw video width and height if angle is 90 or 270 degreesGeorge Claghorn2017-12-081-1/+13
| |
| * Fix customizing Content-Type via GCS service URLsGeorge Claghorn2017-12-071-1/+7
| |
| * Fix instrumention name: delete_prefixed like the others.Kasper Timm Hansen2017-12-031-1/+1
| |
| * Purge variants with their blobsGeorge Claghorn2017-12-027-29/+79
| |
| * Make ASt previewer/analyzer binary paths configurableGeorge Claghorn2017-12-014-4/+32
| |
| * Add ActiveStorage::Previewer#logger to match ActiveStorage::Analyzer#loggerGeorge Claghorn2017-11-301-0/+4
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-302-6/+15
|\|
| * Use `credentials` instead of `keyfile` in GCS seviceyuuji.yaginuma2017-11-291-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802
| * Preparing for 5.2.0.beta2 releaseRafael Mendonça França2017-11-281-1/+1
| |
| * Preparing for 5.2.0.beta1 releaseRafael Mendonça França2017-11-271-1/+1
| |
| * Avoid connecting to GCS during app bootGeorge Claghorn2017-11-231-5/+12
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-203-12/+31
|\|
| * Provide attachment writersGeorge Claghorn2017-11-201-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Permit creating a record and attaching files in a single step. # Before: User.create!(user_params.except(:avatar)).tap do |user| user.avatar.attach(user_params[:avatar]) end # After: User.create!(user_params) [Yoshiyuki Hirano & George Claghorn]
| * Permit attaching files to new recordsGeorge Claghorn2017-11-192-5/+9
| | | | | | | | Closes #31164.
| * Introduce ActiveStorage::Attached::{One,Many}#detachGeorge Claghorn2017-11-142-7/+14
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-094-21/+13
|\|
| * Remove needless block parameterGeorge Claghorn2017-11-071-1/+1
| |
| * Fix streaming downloads from S3/Azure StorageGeorge Claghorn2017-11-062-7/+7
| | | | | | Closes #31073.
| * Permit configuring Active Storage's job queueGeorge Claghorn2017-11-032-14/+6
| |
* | Fixes typo in docsJeffrey Guenther2017-11-021-1/+1
|/
* Allow third-party previewers/analyzers to customize their tempdirsGeorge Claghorn2017-11-022-3/+10
|
* Use the indicative mood consistently [ci skip]George Claghorn2017-10-221-1/+1
|
* Fix links [ci skip]George Claghorn2017-10-221-2/+2
|
* Extract metadata from images and videosGeorge Claghorn2017-10-2213-30/+218
|
* [Active Storage] require_relative => requireAkira Matsuda2017-10-211-1/+1
|
* Fix "warning: `*' interpreted as argument prefix"Ryuta Kamizono2017-09-301-1/+1
|
* Preview PDFs and videosGeorge Claghorn2017-09-2810-7/+135
|
* Add `with_attached_*` scope to `has_one_attached` macroYoshiyuki Hirano2017-09-191-0/+6
| | | | | * For avoiding N+1 problem, added `with_attached_*` scope to `has_one_attached` macro.