| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
[Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Currently `"@active_storage_attached_#{name}"` in `define_method` is
evaluated every call. It is better to evaluate it only once.
|
| | |
| | |
| | |
| | | |
Follow up of #30188.
|
| |/
|/|
| |
| |
| | |
* Use `+` instead of backquote.
* Remove escape from class to be link
|
|/
|
|
|
|
|
| |
* Isolate ActiveStorage namespaces
* Rename migrations task
[Rafael Mendonça França + Dino Maric]
|
|\
| |
| | |
Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded
|
| |
| |
| |
| |
| | |
Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob
is reloaded.
|
|\ \
| |/
|/|
| | |
Support content_type in AzureStorageService#url
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add in the content_type option, which is defined as part of the generic
ActiveStorage::Service class.
Without this option, attempts to generate a URL for an attached file
fail with "ArgumentError (unknown keyword: content_type)"
|
|/
|
|
|
|
| |
* Add migrations per rails engine conventions
* Fix failing tests
|
|\ |
|
| |\
| | |
| | | |
Fix ruby warnings
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes following warnings:
```
test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator
lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized
lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized
```
|
| |\ \
| | | |
| | | | |
Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
|
| | |/
| | |
| | |
| | | |
By default, apps only have the former set.
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
koic/change_gem_version_of_active_storage_to_5_2_0
Change gem version of Active Storage to 5.2.0.alpha
|
| | |/ |
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reasons for this commit are:
- uniformity with the other Rails libraries
- (possibly) behave better with respect to autoloading
- fix the index in the generated documentation
Before this commit, run `rake rdoc` generates this left sidebar
(ActiveStorage entries are indexed twice, both inside and outside the module):
<img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png">
After this commit, run `rake rdoc` generates this left sidebar:
(ActiveStorage entries are only indexed inside the module):
<img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
|
| |
|
|
|
|
|
|
| |
We are already removing the braces around hash parameters in the last
argument in other places so we should not change the entire codebase
because of two places.
|
| |
|
| |
|
|
|
|
| |
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
git-subtree-dir: activestorage
git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6
git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58
|