aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/lib/active_storage
Commit message (Collapse)AuthorAgeFilesLines
* Fix Azure signed URL generation with newer client libGeorge Claghorn2018-03-121-6/+4
|
* Remove path config option from Azure serviceAndrew White2018-03-121-6/+10
| | | | | | | | | | | The Active Storage service for Azure Storage has an option called `path` that is ambiguous in meaning. It needs to be set to the primary blob storage endpoint but that can be determined from the blobs client anyway. To simplify the configuration this commit removes the `path` option and gets the endpoint from the blobs client instead. Closes #32225.
* Provide an alternative PDF previewer based on PopplerTerence Lee2018-03-064-28/+74
| | | | | | mutool is licensed under the Affero GPL, which has strict distribution requirements. Poppler is licensed under the more liberal GPL, making it a good alternative for those who can't use mutool.
* Allow selectively purging attached blobsNicholas Shirley2018-03-062-12/+18
|
* Remove blank Content-Type from GCS direct upload headersGeorge Claghorn2018-03-061-1/+1
| | | | Since we started clearing the client-side blob's type in e0867b3, we no longer need to set a blank Content-Type header before issuing the direct upload request. Fixes that Safari 9 would combine the blank Content-Type header with the blank blob type to produce a Content-Type header containing a single comma, invalidating the request.
* Fix purging dependent blobs when attachments aren't loadedGeorge Claghorn2018-03-052-23/+17
|
* Delete dependent attachments with recordGeorge Claghorn2018-03-051-2/+2
| | | | [Matt Jones & George Claghorn]
* Correct the ActiveStorage::Service#download_chunk docs [ci skip]George Claghorn2018-03-051-1/+1
|
* Generate root-relative paths in Active Storage disk service URL methodsGeorge Claghorn2018-03-056-8/+53
| | | | Fixes #32129.
* Handle another case where a blob might be erroneously purgedGeorge Claghorn2018-03-041-5/+10
|
* Avoid purging attached blob when replacing it with itselfGeorge Claghorn2018-03-041-2/+6
|
* Deprecate `active_support/core_ext/hash/compact`yuuji.yaginuma2018-03-021-2/+0
| | | | | Ruby 2.4+ provides `Hash#compact` and `Hash#compact!` natively, so `active_support/core_ext/hash/compact` is no longer necessary.
* Avoid specifying content types for direct uploads to Google Cloud StorageGeorge Claghorn2018-02-261-5/+4
| | | | Fix customizing the download Content-Type for a directly-uploaded blob via a signed URL. See e8286ee.
* Use lazy load hook to configure ActiveStorage::BlobEugene Kenny2018-02-251-1/+1
| | | | | | | | | `to_prepare` callbacks are run during initialization; using one here meant that `ActiveStorage::Blob` would be loaded when the app boots, which would in turn load `ActiveRecord::Base`. By using a lazy load hook to configure `ActiveStorage::Blob` instead, we can avoid loading `ActiveRecord::Base` unnecessarily.
* Support varying ICO filesGeorge Claghorn2018-02-241-1/+9
| | | | Closes #32096.
* Correct orientation detectionGeorge Claghorn2018-01-311-1/+1
|
* Swap encoded image width and height if angle is 90 or 270 degreesGeorge Claghorn2018-01-311-1/+11
|
* Start Rails 6.0 development!!!Rafael Mendonça França2018-01-301-3/+3
| | | | :tada::tada::tada:
* Unlink internal tempfiles after useGeorge Claghorn2018-01-262-2/+22
|
* Add missing requireGeorge Claghorn2018-01-221-3/+5
|
* Cope with videos with undefined display aspect ratiosGeorge Claghorn2018-01-201-2/+6
|
* Preserve display aspect ratio for videos with rectangular samplesGeorge Claghorn2018-01-191-15/+35
|
* Provide a sensible default hostGeorge Claghorn2018-01-161-1/+1
|
* Extract content types from blob dataGeorge Claghorn2018-01-151-17/+11
|
* Instrument preview image drawingGeorge Claghorn2018-01-101-3/+5
|
* Add missing `# frozen_string_literal: true`Ryuta Kamizono2018-01-111-0/+2
|
* Extract Analyzable and Representable concernsGeorge Claghorn2018-01-101-0/+5
|
* Change Active Storage destroy callbackskami-zh2018-01-091-2/+2
| | | | | There is concern that only blob are deleted depending on the `before_destroy` definition order which throws abort.
* Fix attaching blobs to optimistically-locked recordsGeorge Claghorn2018-01-081-2/+2
| | | | | | Explicitly declare inverse associations so ActiveStorage::Attachment touches the original record instance. Closes #31542.
* Document automatic width-height swapping [ci skip]George Claghorn2018-01-071-0/+2
|
* Remove redundant sentences [ci skip]George Claghorn2018-01-072-4/+2
|
* Tweak engine for readabilityGeorge Claghorn2018-01-071-11/+13
|
* Force content disposition to attachment for specific content typesRosa Gutierrez2018-01-051-0/+11
| | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable.
* Configure previewer/analyzer command paths centrallyGeorge Claghorn2018-01-034-23/+14
|
* Expose ActiveStorage::Analyzer#logger in API docs [ci skip]George Claghorn2017-12-311-1/+1
| | | | Clarify that it's public API and may be used in third-party analyzers.
* Expose ActiveStorage::Previewer#logger in API docs [ci skip]George Claghorn2017-12-311-2/+2
| | | | Clarify that it's public API intended for use by third-party previewers. It shouldn't be removed without deprecation even though it isn't used by the built-in previewers.
* Suppress noise from drawing command invocationsGeorge Claghorn2017-12-311-1/+1
|
* Append extension to tempfile nameGeorge Claghorn2017-12-311-1/+1
| | | | | | Fixes analyzing an SVG image without an XML declaration. ImageMagick occasionally looks to the extension when it can't discern the type of an image file from its contents. References #31356.
* Restrict variants to variable image blobsGeorge Claghorn2017-12-151-0/+2
|
* Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-141-1/+1
|\
| * Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`Yoshiyuki Hirano2017-12-121-1/+1
| | | | | | | | | | | | | | * If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this.
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-0812-35/+135
|\|
| * Swap raw video width and height if angle is 90 or 270 degreesGeorge Claghorn2017-12-081-1/+13
| |
| * Fix customizing Content-Type via GCS service URLsGeorge Claghorn2017-12-071-1/+7
| |
| * Fix instrumention name: delete_prefixed like the others.Kasper Timm Hansen2017-12-031-1/+1
| |
| * Purge variants with their blobsGeorge Claghorn2017-12-027-29/+79
| |
| * Make ASt previewer/analyzer binary paths configurableGeorge Claghorn2017-12-014-4/+32
| |
| * Add ActiveStorage::Previewer#logger to match ActiveStorage::Analyzer#loggerGeorge Claghorn2017-11-301-0/+4
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-302-6/+15
|\|
| * Use `credentials` instead of `keyfile` in GCS seviceyuuji.yaginuma2017-11-291-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802