aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/lib/active_storage
Commit message (Collapse)AuthorAgeFilesLines
...
* DRYGeorge Claghorn2017-08-204-10/+14
|
* Fix RuboCop offensesKoichi ITO2017-08-161-2/+2
| | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* minor tweaks in Active Storage after a walkthroughXavier Noria2017-08-158-9/+9
|
* Use frozen string literal in Active StorageKoichi ITO2017-08-1214-1/+29
|
* Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-fileRafael França2017-08-111-1/+1
|\ | | | | Activestorage rack test uploaded file
| * Make activestorage treat Rack::Test::UploadedFile just like ↵Isaac Betesh2017-08-111-1/+1
| | | | | | | | ActionDispatch::Http::UploadedFile
* | Merge pull request #30147 from yhirano55/fix_trailing_blank_linesRafael França2017-08-112-2/+0
|\ \ | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
| * | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`Yoshiyuki Hirano2017-08-093-3/+1
| | |
* | | Evaluate `@active_storage_attached_#{name}` only onceRyuta Kamizono2017-08-121-12/+8
| | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once.
* | | Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-112-2/+2
| | | | | | | | | | | | Follow up of #30188.
* | | Fix formatting of Active Storage docs [ci skip]yuuji.yaginuma2017-08-119-36/+36
| |/ |/| | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link
* | Isolate ActiveStorage namespaces (#30095)Dino Maric2017-08-101-0/+2
|/ | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric]
* Merge pull request #30118 from georgeclaghorn/active-storage-load-hooksRafael França2017-08-081-16/+15
|\ | | | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded
| * Set ActiveStorage::Blob.service when ActiveStorage::Blob is loadedGeorge Claghorn2017-08-081-16/+15
| | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded.
* | Merge pull request #30135 from ffmike/azure-storage-fix-content-typeRafael Mendonça França2017-08-081-2/+3
|\ \ | |/ |/| | | Support content_type in AzureStorageService#url
| * Support content_type in AzureStorageService#urlMike Gunderloy2017-08-081-2/+3
| | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* | ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-081-27/+0
|/ | | | | | * Add migrations per rails engine conventions * Fix failing tests
* Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-054-7/+13
|\
| * Merge pull request #30081 from y-yagi/fix_ruby_warningsDavid Heinemeier Hansson2017-08-051-2/+8
| |\ | | | | | | Fix ruby warnings
| | * Fix ruby warningsyuuji.yaginuma2017-08-051-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
| * | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-baseDavid Heinemeier Hansson2017-08-051-1/+1
| |\ \ | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
| | * | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`George Claghorn2017-08-051-1/+1
| | |/ | | | | | | | | | By default, apps only have the former set.
| * | Merge pull request #30083 from ↵David Heinemeier Hansson2017-08-051-2/+2
| |\ \ | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha
| | * | Change gem version of Active Storage to 5.2.0.alphaKoichi ITO2017-08-051-2/+2
| | |/
| * / Remove unecesarry exception variabledixpac2017-08-051-1/+1
| |/
* / `module ActiveStorage`, not `ActiveStorage::Class`claudiob2017-08-0412-660/+685
|/ | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
* Rename Azure to AzureStorage (#30057)Dino Maric2017-08-043-3/+3
|
* Do not change the entire codebase style only because of active_storageRafael Mendonça França2017-08-031-4/+2
| | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
* Fix all rubocop violationsRafael Mendonça França2017-08-031-2/+4
|
* We need to require the top file before individual oneRafael Mendonça França2017-08-031-0/+1
|
* Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-031-3/+0
| | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
* Can't initialize a message verifier without a key baseDavid Heinemeier Hansson2017-08-031-1/+3
|
* Add Azure to the available services listRolandas Barysas2017-08-021-0/+1
|
* Follow form from actioncableDavid Heinemeier Hansson2017-07-311-1/+4
|
* Use config/storage.yml as part of the skeleton and loadingDavid Heinemeier Hansson2017-07-312-2/+2
|
* Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58'Rafael Mendonça França2017-07-3116-0/+979
git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 14:38:06 +0000