aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/lib/active_storage/service
Commit message (Collapse)AuthorAgeFilesLines
* Preview PDFs and videosGeorge Claghorn2017-09-284-7/+13
|
* Avoid making HTTP requests to generate signed URLs for GCS objectsGeorge Claghorn2017-09-131-3/+3
|
* Use v3 of the AWS SDKYuji Yaginuma2017-09-091-3/+3
|
* Accept GCS client optionsGeorge Claghorn2017-09-011-2/+2
|
* Ignore files already deleted on GCS file deletionsRosa Gutierrez2017-08-311-1/+5
| | | | | | | | Relying on the GET request issued first to fetch the file we want to delete is not enough to avoid this error. If the file is deleted after our GET request but before the DELETE request we'll get a NotFound error that after all means that the file is already deleted, so it can be safely ignored.
* Fix order of Active Storage DiskService URL parametersKoichi ITO2017-08-261-1/+1
| | | | `content_type` parameter is before `disposition` parameter.
* Fix syntax errorGeorge Claghorn2017-08-201-1/+1
|
* DRYGeorge Claghorn2017-08-204-10/+14
|
* Fix RuboCop offensesKoichi ITO2017-08-161-2/+2
| | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* minor tweaks in Active Storage after a walkthroughXavier Noria2017-08-154-4/+4
|
* Use frozen string literal in Active StorageKoichi ITO2017-08-126-0/+12
|
* Merge pull request #30147 from yhirano55/fix_trailing_blank_linesRafael França2017-08-111-1/+0
|\ | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
| * [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`Yoshiyuki Hirano2017-08-091-1/+0
| |
* | Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-111-1/+1
| | | | | | | | Follow up of #30188.
* | Fix formatting of Active Storage docs [ci skip]yuuji.yaginuma2017-08-115-9/+9
|/ | | | | * Use `+` instead of backquote. * Remove escape from class to be link
* Support content_type in AzureStorageService#urlMike Gunderloy2017-08-081-2/+3
| | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-051-1/+1
|\
| * Remove unecesarry exception variabledixpac2017-08-051-1/+1
| |
* | `module ActiveStorage`, not `ActiveStorage::Class`claudiob2017-08-046-353/+366
|/ | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
* Rename Azure to AzureStorage (#30057)Dino Maric2017-08-042-2/+2
|
* Do not change the entire codebase style only because of active_storageRafael Mendonça França2017-08-031-4/+2
| | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
* Fix all rubocop violationsRafael Mendonça França2017-08-031-2/+4
|
* Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58'Rafael Mendonça França2017-07-316-0/+488
git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58