aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/app
Commit message (Collapse)AuthorAgeFilesLines
* Clear Blob's type before sending itGeorge Claghorn2018-02-262-2/+2
| | | | Prevent older versions of Chrome from appending a Content-Type header containing the Blob type, rendering the request invalid if we intend not to provide a Content-Type. This behavior was observed in Chrome 58.
* Use lazy load hook to configure ActiveStorage::BlobEugene Kenny2018-02-251-0/+2
| | | | | | | | | `to_prepare` callbacks are run during initialization; using one here meant that `ActiveStorage::Blob` would be loaded when the app boots, which would in turn load `ActiveRecord::Base`. By using a lazy load hook to configure `ActiveStorage::Blob` instead, we can avoid loading `ActiveRecord::Base` unnecessarily.
* Support varying ICO filesGeorge Claghorn2018-02-241-1/+1
| | | | Closes #32096.
* Hoist update for clarityGeorge Claghorn2018-02-202-8/+8
|
* Undocument ActiveStorage::IdentificationGeorge Claghorn2018-02-201-1/+1
|
* Correct Range header syntaxGeorge Claghorn2018-02-201-1/+1
|
* Use require_dependency inside Active StorageEugene Kenny2018-02-142-3/+9
| | | | | | | | | | | | | | | Active Storage is an engine which means its models, jobs and controllers are autoloaded by Rails rather than Ruby. Unfortunately this means it's subject to the same gotchas as applications, including this one: http://guides.rubyonrails.org/v5.1.4/autoloading_and_reloading_constants.html#when-constants-aren-t-missed-qualified-references On Ruby < 2.5, constants nested under classes can't be autoloaded by Rails if a top level constant already exists with the same name. To avoid clashing with constants defined in users' applications or gems, we can use `require_dependency` to ensure that the nested constants are loaded before they're used.
* Document MuPDF version requirementGeorge Claghorn2018-02-131-1/+1
|
* Add ActiveStorage::Blob.unattached scopefatkodima2018-02-121-0/+2
|
* Use full class names when including concerns to avoid collisionsWojtek Wrona2018-02-121-1/+3
|
* Add missing requireGeorge Claghorn2018-02-111-0/+2
|
* Merge pull request #31927 from mrreynolds/patch-2Eileen M. Uchitelle2018-02-091-0/+8
|\ | | | | Document :combine_options
| * Document :combine_optionsRobert Glaser2018-02-081-0/+8
| | | | | | | | Turns out this is still undocumented functionality.
* | Fix `blob.service_url` for supports string or nil `:filename` option.Jason Lee2018-02-082-1/+11
|/ | | | | | | | | | | | | | | | | | | | | | | | | - Make sure `blob.service_url` present a `ActiveStorage::Filename` type to `serivce.url`. - Add `ActiveStorage::Filename.wrap` method. before: ```rb blob.service_url(filename: ActiveStorage::Filename.new("new.txt")) blob.service_url(filename: "new.txt") => NoMethodError: undefined method `parameters' for "new.txt":String params = {} blob.service_url(filename: params[:filename]) => NoMethodError: undefined method `parameters' for nil:NilClass ``` after: ```rb blob.service_url(filename: "new.txt") blob.service_url(filename: nil) ```
* Merge pull request #31854 from huacnlee/allow-more-options-for-service-urlGeorge Claghorn2018-02-011-2/+3
|\ | | | | Allow ActiveStorage::Blob#service_url to pass addition options to service.url
| * Allow `ActiveStorage::Blob#service_url` to pass addition options to ↵Jason Lee2018-02-011-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `service.url`. Because there have some service needs more parameters for file URL: https://www.alibabacloud.com/help/doc-detail/44687.htm ```rb class AliyunService < Service def url(key, options = {}) image_process = options[:oss_process] || "image/resize,w_800" "http://image-demo.oss-cn-hangzhou.aliyuncs.com/example.jpg?x-oss-process=#{image_process}" end end ``` Use case: ```erb <%= image_tag @user.avatar.service_url(oss_process: "image/resize,m_fill,h_100,w_100" %> ```
* | Use the full class name for the JSON coder, as there may be anotherRenaud Chaput2018-02-011-1/+1
|/ | | | | | `JSON` constant defined. For example when using the `representable` gem: https://github.com/trailblazer/representable/issues/224
* Extract content types from blob dataGeorge Claghorn2018-01-154-5/+64
|
* Instrument image transformationGeorge Claghorn2018-01-101-7/+9
|
* Update error names in docs [ci skip]George Claghorn2018-01-101-3/+3
|
* Add missing `# frozen_string_literal: true`Ryuta Kamizono2018-01-112-0/+4
|
* Correct comment [ci skip]George Claghorn2018-01-101-1/+1
|
* Extract Analyzable and Representable concernsGeorge Claghorn2018-01-103-147/+148
|
* Rebuild activestorage.jsJavan Makhmali2018-01-081-1/+1
| | | | To pick up 21417e02e906f6b64f013aafefdc0cb8ea8b5e74
* Work around Firefox's refusal to dispatch events on disabled elements. Fixes ↵Javan Makhmali2018-01-081-1/+10
| | | | | | #31393 Brought to you by a 12 year old Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=329509
* Allow overriding filename in `Blob#service_url`Rosa Gutierrez2018-01-081-1/+1
| | | | | | | This is useful when we have several representations for the same underlying file, each one with a different name, and we need to provide a custom download URL based on that name and not that of the underlying file.
* Force content disposition to attachment for specific content typesRosa Gutierrez2018-01-051-2/+7
| | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable.
* Exclude ActiveStorage::SetBlob from API docs [ci skip]George Claghorn2018-01-021-1/+1
|
* Restore support for the -layers transformationGeorge Claghorn2018-01-021-14/+14
|
* prevent shadowing outer variablesDorian Marié2017-12-251-4/+4
|
* Active Storage: Fix direct uploads in IE 11Javan Makhmali2017-12-232-4/+18
| | | | | Fixes #31531 Closes #31540
* Add support for combined MiniMagick transformationsRobert Glaser2017-12-221-6/+16
|
* [ci skip] Remove needless from doc for ActiveStorage::VariantYoshiyuki Hirano2017-12-221-1/+1
|
* Delete MiniMagick tempfile when transformation failsGeorge Claghorn2017-12-181-1/+7
|
* Ensure MiniMagick tempfiles are properly unlinked after image transformationGeorge Claghorn2017-12-181-9/+18
|
* Convert non-web image (e.g. PSD) variants to PNGGeorge Claghorn2017-12-181-3/+34
|
* Update ActiveStorage::Blob#transformation docs [ci skip]George Claghorn2017-12-161-3/+3
|
* Handle invalid signed blob IDs gracefullyGeorge Claghorn2017-12-154-18/+28
|
* Restrict variants to variable image blobsGeorge Claghorn2017-12-151-4/+18
|
* Exclude ActiveStorage::Filename{#parameters,::Parameters} from API docs [ci ↵George Claghorn2017-12-132-2/+2
| | | | skip]
* Fix optimizing GIF variants using mogrify's -layers optionGeorge Claghorn2017-12-111-5/+7
|
* Revert "Invoke mogrify once when transforming an image"George Claghorn2017-12-111-8/+6
| | | | This reverts commit a80f81af055f02bf4625c90470aa90441cf6fc24.
* Invoke mogrify once when transforming an imageGeorge Claghorn2017-12-111-6/+8
| | | | Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing.
* Purge variants with their blobsGeorge Claghorn2017-12-021-1/+2
|
* Fix loading ActiveStorage::DiskController when CSRF protection is disabled ↵George Claghorn2017-11-211-1/+1
| | | | by default
* Fix direct uploads to local serviceGeorge Claghorn2017-11-201-0/+2
| | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn]
* Preserve existing metadata when analyzing a blobGeorge Claghorn2017-11-131-1/+1
| | | | Closes #31138.
* Permit configuring Active Storage's job queueGeorge Claghorn2017-11-033-2/+7
|
* Extract metadata from images and videosGeorge Claghorn2017-10-224-2/+72
|
* Clarify comment [ci skip]George Claghorn2017-10-131-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 16:00:00 +0000