aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage/app
Commit message (Collapse)AuthorAgeFilesLines
* Fix loading ActiveStorage::DiskController when CSRF protection is disabled ↵George Claghorn2017-11-211-1/+1
| | | | by default
* Fix direct uploads to local serviceGeorge Claghorn2017-11-201-0/+2
| | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn]
* Preserve existing metadata when analyzing a blobGeorge Claghorn2017-11-131-1/+1
| | | | Closes #31138.
* Permit configuring Active Storage's job queueGeorge Claghorn2017-11-033-2/+7
|
* Extract metadata from images and videosGeorge Claghorn2017-10-224-2/+72
|
* Clarify comment [ci skip]George Claghorn2017-10-131-1/+1
|
* Accept variation keys in #preview and #variantGeorge Claghorn2017-10-122-7/+12
|
* Introduce ActiveStorage::Blob#representationGeorge Claghorn2017-10-122-0/+30
|
* Replace variation key use with SHA256 of key to prevent long filenameskhall2017-10-051-1/+1
| | | | | | | If a variant has a large set of options associated with it, the generated filename will be too long, causing Errno::ENAMETOOLONG to be raised. This change replaces those potentially long filenames with a much more compact SHA256 hash. Fixes #30662.
* Fix third-party system libraries list in ActiveStorage::Preview [ci skip]Yoshiyuki Hirano2017-10-041-2/+2
|
* Associate blobs with their attachmentsGeorge Claghorn2017-10-031-0/+2
|
* Preview PDFs and videosGeorge Claghorn2017-09-288-44/+160
|
* Add missing word [ci skip]George Claghorn2017-09-201-1/+1
|
* Flesh out ActiveStorage::Filename docsGeorge Claghorn2017-09-201-6/+14
|
* Remove unused require in ActiveStorage::VariationYoshiyuki Hirano2017-09-181-2/+0
|
* Fix activestorage direct upload on firefox_N_I_X_O_N_2017-09-123-1/+3
| | | | | | | | Direct upload on firefox is not working because it can’t handle click events on “input[type=submit]”. After a successful upload we can see on console a xml parse error, it happens because AWS S3 success body response is empty, so changing the reponseType suppress this error.
* Have attachments touch their recordsGeorge Claghorn2017-08-311-1/+1
|
* Update Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-302-7/+15
|
* Synchronously destroy attachmentsGeorge Claghorn2017-08-292-9/+7
|
* Enable links in Active Storage docs [ci skip]Yoshiyuki Hirano2017-08-262-2/+2
|
* Fix link in doc for active storage [ci skip]Yoshiyuki Hirano2017-08-251-1/+1
|
* Add frozen string literal pragmaGeorge Claghorn2017-08-211-0/+2
|
* Encode Content-Disposition filenames according to RFC 2231George Claghorn2017-08-213-1/+39
| | | | Closes #30134.
* DRYGeorge Claghorn2017-08-202-3/+3
|
* Rename ActiveStorage::Filename#extname to extension_with_delimiterGeorge Claghorn2017-08-201-9/+11
|
* restores some double newlines deleted in ae87217Xavier Noria2017-08-153-0/+6
| | | | | | These were intentional, see https://github.com/rails/rails/pull/30061#issuecomment-320068368
* minor tweaks in Active Storage after a walkthroughXavier Noria2017-08-156-32/+28
|
* Use frozen string literal in Active StorageKoichi ITO2017-08-1210-0/+20
|
* Enable browser caching for blobs and variants (#30196)Anton Khamets2017-08-112-0/+2
|
* Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-115-31/+31
| | | | Follow up of #30188.
* Fix a typoqsona2017-08-101-1/+1
|
* Use `content_type.start_with?("...")` than `content_type =~ /^.../`Ryuta Kamizono2017-08-051-4/+4
| | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string.
* Merge pull request #30061 from claudiob/ast-rubocopRafael França2017-08-032-2/+2
|\ | | | | Make Rubocop happy about ActiveStorage
| * Make Rubocop happier about ActiveStorageclaudiob2017-08-032-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
* | Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-033-9/+0
| | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
* | There is no reason to single line methods hereRafael Mendonça França2017-08-031-4/+12
|/ | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify.
* Remove circular dependencyDavid Heinemeier Hansson2017-08-011-2/+0
|
* Move the direct_upload: true convenience option from the activestorage ↵David Heinemeier Hansson2017-07-311-18/+0
| | | | helper into actionview
* Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58'Rafael Mendonça França2017-07-3121-0/+983
git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58