Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Correct Range header syntax | George Claghorn | 2018-02-20 | 1 | -1/+1 | |
| | ||||||
* | Use require_dependency inside Active Storage | Eugene Kenny | 2018-02-14 | 2 | -3/+9 | |
| | | | | | | | | | | | | | | | Active Storage is an engine which means its models, jobs and controllers are autoloaded by Rails rather than Ruby. Unfortunately this means it's subject to the same gotchas as applications, including this one: http://guides.rubyonrails.org/v5.1.4/autoloading_and_reloading_constants.html#when-constants-aren-t-missed-qualified-references On Ruby < 2.5, constants nested under classes can't be autoloaded by Rails if a top level constant already exists with the same name. To avoid clashing with constants defined in users' applications or gems, we can use `require_dependency` to ensure that the nested constants are loaded before they're used. | |||||
* | Document MuPDF version requirement | George Claghorn | 2018-02-13 | 1 | -1/+1 | |
| | ||||||
* | Add ActiveStorage::Blob.unattached scope | fatkodima | 2018-02-12 | 1 | -0/+2 | |
| | ||||||
* | Use full class names when including concerns to avoid collisions | Wojtek Wrona | 2018-02-12 | 1 | -1/+3 | |
| | ||||||
* | Add missing require | George Claghorn | 2018-02-11 | 1 | -0/+2 | |
| | ||||||
* | Merge pull request #31927 from mrreynolds/patch-2 | Eileen M. Uchitelle | 2018-02-09 | 1 | -0/+8 | |
|\ | | | | | Document :combine_options | |||||
| * | Document :combine_options | Robert Glaser | 2018-02-08 | 1 | -0/+8 | |
| | | | | | | | | Turns out this is still undocumented functionality. | |||||
* | | Fix `blob.service_url` for supports string or nil `:filename` option. | Jason Lee | 2018-02-08 | 2 | -1/+11 | |
|/ | | | | | | | | | | | | | | | | | | | | | | | | | - Make sure `blob.service_url` present a `ActiveStorage::Filename` type to `serivce.url`. - Add `ActiveStorage::Filename.wrap` method. before: ```rb blob.service_url(filename: ActiveStorage::Filename.new("new.txt")) blob.service_url(filename: "new.txt") => NoMethodError: undefined method `parameters' for "new.txt":String params = {} blob.service_url(filename: params[:filename]) => NoMethodError: undefined method `parameters' for nil:NilClass ``` after: ```rb blob.service_url(filename: "new.txt") blob.service_url(filename: nil) ``` | |||||
* | Merge pull request #31854 from huacnlee/allow-more-options-for-service-url | George Claghorn | 2018-02-01 | 1 | -2/+3 | |
|\ | | | | | Allow ActiveStorage::Blob#service_url to pass addition options to service.url | |||||
| * | Allow `ActiveStorage::Blob#service_url` to pass addition options to ↵ | Jason Lee | 2018-02-01 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `service.url`. Because there have some service needs more parameters for file URL: https://www.alibabacloud.com/help/doc-detail/44687.htm ```rb class AliyunService < Service def url(key, options = {}) image_process = options[:oss_process] || "image/resize,w_800" "http://image-demo.oss-cn-hangzhou.aliyuncs.com/example.jpg?x-oss-process=#{image_process}" end end ``` Use case: ```erb <%= image_tag @user.avatar.service_url(oss_process: "image/resize,m_fill,h_100,w_100" %> ``` | |||||
* | | Use the full class name for the JSON coder, as there may be another | Renaud Chaput | 2018-02-01 | 1 | -1/+1 | |
|/ | | | | | | `JSON` constant defined. For example when using the `representable` gem: https://github.com/trailblazer/representable/issues/224 | |||||
* | Extract content types from blob data | George Claghorn | 2018-01-15 | 4 | -5/+64 | |
| | ||||||
* | Instrument image transformation | George Claghorn | 2018-01-10 | 1 | -7/+9 | |
| | ||||||
* | Update error names in docs [ci skip] | George Claghorn | 2018-01-10 | 1 | -3/+3 | |
| | ||||||
* | Add missing `# frozen_string_literal: true` | Ryuta Kamizono | 2018-01-11 | 2 | -0/+4 | |
| | ||||||
* | Correct comment [ci skip] | George Claghorn | 2018-01-10 | 1 | -1/+1 | |
| | ||||||
* | Extract Analyzable and Representable concerns | George Claghorn | 2018-01-10 | 3 | -147/+148 | |
| | ||||||
* | Rebuild activestorage.js | Javan Makhmali | 2018-01-08 | 1 | -1/+1 | |
| | | | | To pick up 21417e02e906f6b64f013aafefdc0cb8ea8b5e74 | |||||
* | Work around Firefox's refusal to dispatch events on disabled elements. Fixes ↵ | Javan Makhmali | 2018-01-08 | 1 | -1/+10 | |
| | | | | | | #31393 Brought to you by a 12 year old Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=329509 | |||||
* | Allow overriding filename in `Blob#service_url` | Rosa Gutierrez | 2018-01-08 | 1 | -1/+1 | |
| | | | | | | | This is useful when we have several representations for the same underlying file, each one with a different name, and we need to provide a custom download URL based on that name and not that of the underlying file. | |||||
* | Force content disposition to attachment for specific content types | Rosa Gutierrez | 2018-01-05 | 1 | -2/+7 | |
| | | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable. | |||||
* | Exclude ActiveStorage::SetBlob from API docs [ci skip] | George Claghorn | 2018-01-02 | 1 | -1/+1 | |
| | ||||||
* | Restore support for the -layers transformation | George Claghorn | 2018-01-02 | 1 | -14/+14 | |
| | ||||||
* | prevent shadowing outer variables | Dorian Marié | 2017-12-25 | 1 | -4/+4 | |
| | ||||||
* | Active Storage: Fix direct uploads in IE 11 | Javan Makhmali | 2017-12-23 | 2 | -4/+18 | |
| | | | | | Fixes #31531 Closes #31540 | |||||
* | Add support for combined MiniMagick transformations | Robert Glaser | 2017-12-22 | 1 | -6/+16 | |
| | ||||||
* | [ci skip] Remove needless from doc for ActiveStorage::Variant | Yoshiyuki Hirano | 2017-12-22 | 1 | -1/+1 | |
| | ||||||
* | Delete MiniMagick tempfile when transformation fails | George Claghorn | 2017-12-18 | 1 | -1/+7 | |
| | ||||||
* | Ensure MiniMagick tempfiles are properly unlinked after image transformation | George Claghorn | 2017-12-18 | 1 | -9/+18 | |
| | ||||||
* | Convert non-web image (e.g. PSD) variants to PNG | George Claghorn | 2017-12-18 | 1 | -3/+34 | |
| | ||||||
* | Update ActiveStorage::Blob#transformation docs [ci skip] | George Claghorn | 2017-12-16 | 1 | -3/+3 | |
| | ||||||
* | Handle invalid signed blob IDs gracefully | George Claghorn | 2017-12-15 | 4 | -18/+28 | |
| | ||||||
* | Restrict variants to variable image blobs | George Claghorn | 2017-12-15 | 1 | -4/+18 | |
| | ||||||
* | Exclude ActiveStorage::Filename{#parameters,::Parameters} from API docs [ci ↵ | George Claghorn | 2017-12-13 | 2 | -2/+2 | |
| | | | | skip] | |||||
* | Fix optimizing GIF variants using mogrify's -layers option | George Claghorn | 2017-12-11 | 1 | -5/+7 | |
| | ||||||
* | Revert "Invoke mogrify once when transforming an image" | George Claghorn | 2017-12-11 | 1 | -8/+6 | |
| | | | | This reverts commit a80f81af055f02bf4625c90470aa90441cf6fc24. | |||||
* | Invoke mogrify once when transforming an image | George Claghorn | 2017-12-11 | 1 | -6/+8 | |
| | | | | Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing. | |||||
* | Purge variants with their blobs | George Claghorn | 2017-12-02 | 1 | -1/+2 | |
| | ||||||
* | Fix loading ActiveStorage::DiskController when CSRF protection is disabled ↵ | George Claghorn | 2017-11-21 | 1 | -1/+1 | |
| | | | | by default | |||||
* | Fix direct uploads to local service | George Claghorn | 2017-11-20 | 1 | -0/+2 | |
| | | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn] | |||||
* | Preserve existing metadata when analyzing a blob | George Claghorn | 2017-11-13 | 1 | -1/+1 | |
| | | | | Closes #31138. | |||||
* | Permit configuring Active Storage's job queue | George Claghorn | 2017-11-03 | 3 | -2/+7 | |
| | ||||||
* | Extract metadata from images and videos | George Claghorn | 2017-10-22 | 4 | -2/+72 | |
| | ||||||
* | Clarify comment [ci skip] | George Claghorn | 2017-10-13 | 1 | -1/+1 | |
| | ||||||
* | Accept variation keys in #preview and #variant | George Claghorn | 2017-10-12 | 2 | -7/+12 | |
| | ||||||
* | Introduce ActiveStorage::Blob#representation | George Claghorn | 2017-10-12 | 2 | -0/+30 | |
| | ||||||
* | Replace variation key use with SHA256 of key to prevent long filenames | khall | 2017-10-05 | 1 | -1/+1 | |
| | | | | | | | If a variant has a large set of options associated with it, the generated filename will be too long, causing Errno::ENAMETOOLONG to be raised. This change replaces those potentially long filenames with a much more compact SHA256 hash. Fixes #30662. | |||||
* | Fix third-party system libraries list in ActiveStorage::Preview [ci skip] | Yoshiyuki Hirano | 2017-10-04 | 1 | -2/+2 | |
| | ||||||
* | Associate blobs with their attachments | George Claghorn | 2017-10-03 | 1 | -0/+2 | |
| |