Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add frozen string literal pragma | George Claghorn | 2017-08-21 | 1 | -0/+2 |
| | |||||
* | Encode Content-Disposition filenames according to RFC 2231 | George Claghorn | 2017-08-21 | 3 | -1/+39 |
| | | | | Closes #30134. | ||||
* | DRY | George Claghorn | 2017-08-20 | 1 | -1/+1 |
| | |||||
* | Rename ActiveStorage::Filename#extname to extension_with_delimiter | George Claghorn | 2017-08-20 | 1 | -9/+11 |
| | |||||
* | restores some double newlines deleted in ae87217 | Xavier Noria | 2017-08-15 | 2 | -0/+4 |
| | | | | | | These were intentional, see https://github.com/rails/rails/pull/30061#issuecomment-320068368 | ||||
* | minor tweaks in Active Storage after a walkthrough | Xavier Noria | 2017-08-15 | 4 | -29/+27 |
| | |||||
* | Use frozen string literal in Active Storage | Koichi ITO | 2017-08-12 | 5 | -0/+10 |
| | |||||
* | Fix formatting of Active Storage docs [ci skip] | Koichi ITO | 2017-08-11 | 4 | -30/+30 |
| | | | | Follow up of #30188. | ||||
* | Fix a typo | qsona | 2017-08-10 | 1 | -1/+1 |
| | |||||
* | Use `content_type.start_with?("...")` than `content_type =~ /^.../` | Ryuta Kamizono | 2017-08-05 | 1 | -4/+4 |
| | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string. | ||||
* | Merge pull request #30061 from claudiob/ast-rubocop | Rafael França | 2017-08-03 | 2 | -2/+2 |
|\ | | | | | Make Rubocop happy about ActiveStorage | ||||
| * | Make Rubocop happier about ActiveStorage | claudiob | 2017-08-03 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190) | ||||
* | | Do not eager load ActiveRecord::Base | Rafael Mendonça França | 2017-08-03 | 2 | -7/+0 |
| | | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them. | ||||
* | | There is no reason to single line methods here | Rafael Mendonça França | 2017-08-03 | 1 | -4/+12 |
|/ | | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify. | ||||
* | Remove circular dependency | David Heinemeier Hansson | 2017-08-01 | 1 | -2/+0 |
| | |||||
* | Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58' | Rafael Mendonça França | 2017-07-31 | 5 | -0/+406 |
git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58 |