| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Example: Given you have a comments model with a polymorphic commentable
association (e.g. books and songs) with the touch option set.
Every time you update a comment its commentable should be touched.
This was working when you changed attributes on the comment or when you
moved the comment from one book to another. However, it was not working
when moving a comment from a book to a song. This is now fixed.
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Fix AR#method_missing re-dispatching into overwritten attribute methods
Conflicts:
activerecord/lib/active_record/attribute_methods.rb
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was happening when a `super` call in an overwritten attribute method
was triggering a method_missing fallback, because attribute methods
haven't been generated yet.
class Topic < ActiveRecord::Base
def title
# `super` would re-invoke this method if define_attribute_methods
# hasn't been called yet resulting in double '!' appending
super + '!'
end
end
|
| | |
| |
| |
| | |
skip]
|
| |\ \
| | |
| | | |
Improve formatting of ActiveRecord migration exception messages
|
| | | | |
|
| |/ /
| |
| |
| | |
Closes #7441
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closes #13146.
This fixes an error when using:
```
change_colum :table, :column, :bigint, array: true
```
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Callback caller class uses `after_initialize`,
but Callback callee defines `after_find`.
Current sample code causes following error.
NoMethodError: undefined method `after_initialize' for #<EncryptionWrapper:0x007fe4931fa5c0>
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
already have cache true.
This commit takes into account the last cache_enabled value, before clearing query_cache.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixture files are passed through an ERB renderer before being read as
YAML. The rendering is currently done in the context of the main object,
so method definitons leak into other fixtures, and there is no clean
place to define fixture helpers.
After this commit, the ERB renderer will use a new subclass of
ActiveRecord::FixtureSet.context_class each time a fixture is rendered.
|
| | | |
|
| | |
| |
| |
| | |
We need to fix this test
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
Typo fixes [ci skip]
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously, the `has_one` macro incorrectly accepts the `counter_cache` option
due to a bug, although that options was never supported nor functional on
`has_one` and `has_one ... through` relationships. It now correctly raises an
`ArgumentError` when passed that option.
For reference, this bug was introduced in 52f8e4b9.
|
| |/ /
| |
| |
| |
| | |
This method is not using the block variable directly since it is calling
yield
|
| |\ \
| | |
| | | |
removed unnecessary test case
|
| | | |
| | |
| | |
| | | |
removed unnecessary test case and improved test case for belongs_to having invalid options
|
| |\ \ \
| | | |
| | | | |
Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been deprecated already.
|
| | | | |
| | | |
| | | |
| | | | |
deprecated already.
|
| |\ \ \ \
| |/ / /
|/| | | |
#type_cast - improve performance & readability
|
| | | | | |
|
| | |/ /
|/| |
| | |
| | | |
also clarify native rename_index support is >= 5.7, not > 5.7
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Extract **notable changes**, **deprecations** and **removals** from
each CHANGELOG.
I tried to reference the commits and pull requests for new features
and deprecations.
In the process I also made some minor changes to the CHANGELOGS.
The 4_1_release_notes guide is declared WIP.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
because it is only used in
`activerecord/test/cases/adapters/oracle/synonym_test.rb`
See rails/rails#13054
|
| |\ \ \
| | | |
| | | | |
Remove leftover Oracle tests.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
laurocaetano/fix-uniqueness-validation-for-aliased-attribute
Fix bug when validating the uniqueness of an aliased attribute.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | | |
remove leftover firebird adapter tests.
|
| | | | | |
|
| |/ / / |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This prevents the following error when a MySQL index on a foreign key
column is renamed:
```
ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_engines_on_car_id': needed in a foreign key constraint: DROP INDEX `index_engines_on_car_id` ON `engines`
```
refs: #13038.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes #12812
Raise `ActiveRecord::RecordNotDestroyed` when a child marked with
`dependent: destroy` can't be destroyed.
The following code:
```ruby
class Post < ActiveRecord::Base
has_many :comments, dependent: :destroy
end
class Comment < ActiveRecord::Base
before_destroy do
return false
end
end
post = Post.create!(comments: [Comment.create!])
post.comments = [Comment.create!]
````
would result in a `post` with two `comments`.
With this commit, the same code would raise a `RecordNotDestroyed`
exception, keeping the `post` with the same `comment`.
|
