Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | | Mark :GeneratedAssociationMethods also as private_constant | Prathamesh Sonpatki | 2016-12-31 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - After https://github.com/rails/rails/commit/64e5b897ac944a05a33275e3828a3d4047a6b457, only :GeneratedAssociationMethods was remaining to be marked as private constant, so marked it as well. - Before: >> User.constants(false) => [:GeneratedAssociationMethods] - After: >> User.constants(false) => [] | |||||
* | | | | | | | | Bump license years for 2017 | Jon Moss | 2016-12-31 | 2 | -2/+2 | |
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip] | |||||
* | | | | | | | Add missing word in activerecord/CHANGELOG.md | Jon Moss | 2016-12-30 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | | Mark internal cache constants as private | Matthew Draper | 2016-12-31 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #14640 | |||||
* | | | | | | | Remove deprecated `#uniq`, `#uniq!`, and `#uniq_value` | Ryuta Kamizono | 2016-12-30 | 7 | -46/+5 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated `#insert_sql`, `#update_sql`, and `#delete_sql` | Ryuta Kamizono | 2016-12-30 | 3 | -12/+4 | |
| | | | | | | | ||||||
* | | | | | | | Grammar linting in activerecord/CHANGELOG.md | Jon Moss | 2016-12-29 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | | Fix grammar in AR CHANGELOG.md [ci skip] | kenta-s | 2016-12-30 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated #use_transactional_fixtures configuration | Rafael Mendonça França | 2016-12-29 | 3 | -31/+5 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated `#raise_in_transactional_callbacks` configuration | Rafael Mendonça França | 2016-12-29 | 2 | -10/+4 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated #load_schema_for | Rafael Mendonça França | 2016-12-29 | 2 | -8/+4 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated conditions parameter from #delete_all | Rafael Mendonça França | 2016-12-29 | 3 | -26/+12 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated conditions parameter from `#destroy_all` | Rafael Mendonça França | 2016-12-29 | 3 | -16/+6 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated support to passing arguments to `#select` when a block is ↵ | Rafael Mendonça França | 2016-12-29 | 3 | -10/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | provided. | |||||
* | | | | | | | Remove deprecated support to query using commas on LIMIT | Rafael Mendonça França | 2016-12-29 | 4 | -37/+9 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated support to passing a class as a value in a query | Rafael Mendonça França | 2016-12-29 | 4 | -40/+4 | |
| | | | | | | | ||||||
* | | | | | | | Raises IrreversibleOrderError when using last with an irreversible order | Rafael Mendonça França | 2016-12-29 | 3 | -9/+6 | |
| | | | | | | | ||||||
* | | | | | | | Raise when a through association has an ambiguous reflection name | Rafael Mendonça França | 2016-12-29 | 4 | -10/+27 | |
| | | | | | | | ||||||
* | | | | | | | Raises when `ActiveRecord::Migration` is inherited directly. | Rafael Mendonça França | 2016-12-29 | 4 | -54/+35 | |
| | | | | | | | ||||||
* | | | | | | | Remove original_exception from ActiveRecord::StatementInvalid | Rafael Mendonça França | 2016-12-29 | 3 | -12/+7 | |
| | | | | | | | ||||||
* | | | | | | | `#tables` and `#table_exists?` and returns only tables and not views | Rafael Mendonça França | 2016-12-29 | 18 | -161/+128 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated `name` argument from `#tables` | Rafael Mendonça França | 2016-12-29 | 8 | -30/+10 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated support to passing a column to #quote | Rafael Mendonça França | 2016-12-29 | 4 | -24/+18 | |
| | | | | | | | ||||||
* | | | | | | | Set time as a timezone aware type and remove related deprecation | Rafael Mendonça França | 2016-12-29 | 3 | -26/+7 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated force reload argument in association readers | Rafael Mendonça França | 2016-12-29 | 9 | -67/+12 | |
| | | | | | | | ||||||
* | | | | | | | Remove deprecated i18n scopes in Active Record | Rafael Mendonça França | 2016-12-29 | 5 | -55/+7 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #27493 from kamipo/sync_visibility | Rafael França | 2016-12-29 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Sync the visibility of `sql_for_insert` to private | |||||
| * | | | | | | | Sync the visibility of `sql_for_insert` to private | Ryuta Kamizono | 2016-12-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visibility of all internal protected methods was changed to private since 5b14129. | |||||
* | | | | | | | | [ci skip] Add changelog for 261e94b. | Kasper Timm Hansen | 2016-12-29 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ *Kasper Timm Hansen* & *Kir Shatrov* ] | |||||
* | | | | | | | | Remove try! usage in sqlite_database_tasks. | Kasper Timm Hansen | 2016-12-29 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We try to not try! internally. | |||||
* | | | | | | | | Merge pull request #27437 from kirs/structure-load-dump-flags | Kasper Timm Hansen | 2016-12-29 | 7 | -15/+109 | |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Make ActiveRecord structure load/dump configurable | |||||
| * | | | | | | | Make ActiveRecord structure load/dump configurable | Kir Shatrov | 2016-12-22 | 7 | -15/+109 | |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this patch it's impossible to pass extra flags to mysqldump/pg_dump when running `rake db:structure:dump` or `load` The following config variables (`structure_load_flags` and `structure_dump_flags`) make it better configurable. | |||||
* | | | | | | | Merge pull request #27490 from ↵ | Rafael França | 2016-12-29 | 4 | -4/+20 | |
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | kamipo/should_not_update_children_when_parent_creation_with_no_reason Should not update children when the parent creation with no reason | |||||
| * | | | | | | Should not update children when the parent creation with no reason | Ryuta Kamizono | 2016-12-29 | 4 | -4/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338. | |||||
* | | | | | | | Merge pull request #26376 from kamipo/remove_polymorphic_base_class_for_array | Rafael França | 2016-12-29 | 1 | -3/+0 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue` | |||||
| * | | | | | | Remove extracting `polymorphic_base_class` for `Array` in ↵ | Ryuta Kamizono | 2016-09-21 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AssociationQueryValue` It is handled by `PolymorphicArrayValue`. | |||||
* | | | | | | | Merge pull request #27402 from yui-knk/execute | Rafael França | 2016-12-28 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Use `#execute` instead of `@connection.query` | |||||
| * | | | | | | | Use `#execute` instead of `@connection.query` | yui-knk | 2016-12-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@connection.query` bypasses instrumenting "sql.active_record". This behavior preventing us from debugging SQLs which Rails generates. | |||||
* | | | | | | | | Fix Rubocop violations and fix documentation visibility | Rafael Mendonça França | 2016-12-28 | 17 | -153/+153 | |
| |_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API. | |||||
* | | | | | | | Merge pull request #27442 from kamipo/fix_27434 | Eileen M. Uchitelle | 2016-12-27 | 3 | -14/+17 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Add a record to target before any callbacks loads the record | |||||
| * | | | | | | | Add a record to target before any callbacks loads the record | Ryuta Kamizono | 2016-12-23 | 3 | -14/+17 | |
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434. | |||||
* | | | | | | | Small edits to activerecord/CHANGELOG.md | Jon Moss | 2016-12-27 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] - add period where necessary - add backticks where necessary | |||||
* | | | | | | | assert_equal takes expectation first | Akira Matsuda | 2016-12-26 | 8 | -19/+19 | |
| | | | | | | | ||||||
* | | | | | | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 4 | -10/+10 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #27448 from kamipo/no_need_doc_for_nodoc_classes | Akira Matsuda | 2016-12-25 | 5 | -15/+15 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | |||||
| * | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | Ryuta Kamizono | 2016-12-25 | 5 | -15/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html | |||||
* | | | | | | | | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 22 | -77/+77 | |
|/ / / / / / / | ||||||
* | | | | | | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 | |
| | | | | | | | ||||||
* | | | | | | | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 | |
| | | | | | | | ||||||
* | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 | |
| | | | | | | |