Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Merge pull request #12590 from laurocaetano/whitelist-to-delegate-array-methods | Rafael Mendonça França | 2013-12-12 | 4 | -104/+105 | |
|\ \ \ \ | | | | | | | | | | | Create a whitelist of methods to be delegated to Array. | |||||
| * | | | | Use `public_send` instead of just use `send`. | Lauro Caetano | 2013-12-12 | 2 | -9/+9 | |
| | | | | | ||||||
| * | | | | Use a whitelist to delegate methods to array | Lauro Caetano | 2013-12-12 | 2 | -75/+38 | |
| | | | | | ||||||
| * | | | | Add changelog | laurocaetano | 2013-12-12 | 1 | -6/+15 | |
| | | | | | ||||||
| * | | | | Remove delegation test. | laurocaetano | 2013-12-12 | 1 | -17/+46 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This test was removed, since Relation will not delegate class methods to Array. | |||||
* | | | | | extract cache counter logic to one method | Aaron Patterson | 2013-12-12 | 1 | -11/+10 | |
| | | | | | ||||||
* | | | | | remove duplicate code | Aaron Patterson | 2013-12-12 | 1 | -15/+6 | |
| | | | | | ||||||
* | | | | | extract a method for updating without a record object | Aaron Patterson | 2013-12-12 | 1 | -6/+10 | |
| | | | | | ||||||
* | | | | | extract methods out of the cache update method | Aaron Patterson | 2013-12-12 | 1 | -14/+22 | |
| | | | | | ||||||
* | | | | | pull a nil check up one frame | Aaron Patterson | 2013-12-12 | 1 | -6/+10 | |
|/ / / / | ||||||
* | | | | remove more nil checks | Aaron Patterson | 2013-12-12 | 1 | -6/+5 | |
| | | | | ||||||
* | | | | remove nil check | Aaron Patterson | 2013-12-12 | 2 | -7/+11 | |
| | | | | | | | | | | | | | | | | | | | | calling replace_keys could possibly do a nil check twice, this commit reduces it to once. | |||||
* | | | | remove the nil check from set_inverse_instance | Aaron Patterson | 2013-12-12 | 4 | -4/+7 | |
| | | | | | | | | | | | | | | | | | | | | methods that call set_inverse_instance with a record will not have to pay the cost of a nil check on every call | |||||
* | | | | make sure cached table name is a string. fixes #12582 | Aaron Patterson | 2013-12-12 | 3 | -1/+12 | |
| | | | | ||||||
* | | | | Merge pull request #13293 from akshay-vishnoi/typo | Carlos Antonio da Silva | 2013-12-12 | 2 | -5/+5 | |
|\| | | | | | | | | | | | Spelling and Grammar checks [ci skip] | |||||
| * | | | Spelling and Grammar checks | Akshay Vishnoi | 2013-12-12 | 2 | -5/+5 | |
| | | | | ||||||
* | | | | Merge pull request #13291 from strzibny/new_unique_constraint | Yves Senn | 2013-12-12 | 1 | -1/+5 | |
|\ \ \ \ | |/ / / |/| | | | Translate new unique constraint error message for sqlite >= 3.8.2 | |||||
| * | | | Translate new unique constraint for sqlite >= 3.8.2 | Josef Stribny | 2013-12-12 | 1 | -1/+5 | |
| | | | | ||||||
* | | | | Get rid of hack for freezing time on AR tests | Carlos Antonio da Silva | 2013-12-12 | 2 | -23/+5 | |
| | | | | | | | | | | | | | | | | | | | | We can now make use of the existent #travel/#travel_to helper methods added to AS test case and available in all tests. | |||||
* | | | | Changelog improvements [ci skip] | Carlos Antonio da Silva | 2013-12-12 | 1 | -7/+7 | |
| | | | | ||||||
* | | | | Merge pull request #13264 from ↵ | Rafael Mendonça França | 2013-12-11 | 3 | -2/+16 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix_dynamic_finder_with_reserved_words Prevent invalid code when using dynamic finders with reserved ruby word. | |||||
| * | | | | Prevent invalid code when using dynamic finders with Ruby's reserved words. | Lauro Caetano | 2013-12-11 | 3 | -2/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dynamic finder was creating the method signature with the parameters name, which may have reserved words and this way creating invalid Ruby code. Closes: #13261 Example: # Before Dog.find_by_alias('dog name') # Was creating this method def self.find_by_alias(alias, options = {}) # After Dog.find_by_alias('dog name') # Will create this method def self.find_by_alias(_alias, options = {}) | |||||
* | | | | | Move the parameter normalization to the initialize method | Rafael Mendonça França | 2013-12-11 | 1 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | activerecord-deprecated_finders expects the parameters denormalized in its initialize method | |||||
* | | | | | Revert the whole refactoring in the association builder classes. | Rafael Mendonça França | 2013-12-11 | 8 | -47/+64 | |
| | | | | | | | | | | | | | | | | | | | | This is to get activerecord-deprecated_finders work again | |||||
* | | | | | Mark the arguments needed by activerecord-deprecated_finders with a TODO | Rafael Mendonça França | 2013-12-11 | 4 | -2/+20 | |
| | | | | | ||||||
* | | | | | Revert "Merge pull request #12518 from vipulnsward/remove_count_options" | Rafael Mendonça França | 2013-12-11 | 5 | -17/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is needed for activerecord-depecated_finders This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f. | |||||
* | | | | | Bring back the valid_options class accessor | Rafael Mendonça França | 2013-12-11 | 6 | -9/+14 | |
|/ / / / | | | | | | | | | | | | | It is need in activerecord-deprecated_finders | |||||
* | | | | Merge pull request #13236 from jetthoughts/13230_type_cast_bug_in_agr_functions | Yves Senn | 2013-12-10 | 3 | -1/+23 | |
|\ \ \ \ | | | | | | | | | | | Fix type cast on group sum with custom expression | |||||
| * | | | | Fix type cast on group sum with custom expression | Paul Nikitochkin | 2013-12-10 | 3 | -1/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For PG adapters with custom expression and grouped result of aggregate functions have not found correct column type for it. Extract column type from query result. Closes: #13230 | |||||
* | | | | | Fix warnings on mysql2 explain test | Carlos Antonio da Silva | 2013-12-10 | 1 | -3/+3 | |
| | | | | | ||||||
* | | | | | Merge pull request #13248 from yahonda/support_mysql573_explain | Jeremy Kemper | 2013-12-09 | 1 | -3/+3 | |
|\ \ \ \ \ | | | | | | | | | | | | | Support MySQL 5.7 explain | |||||
| * | | | | | Support MySQL 5.7 explain | Yasuo Honda | 2013-12-10 | 1 | -3/+3 | |
| |/ / / / | ||||||
* / / / / | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3 | Yasuo Honda | 2013-12-10 | 3 | -7/+7 | |
|/ / / / | | | | | | | | | | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null. | |||||
* | | | | fix typo, "state_state" should be "stale_state" [ci skip] | Scott M | 2013-12-07 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Very tiny typo fix [ci skip] | Robin Dupret | 2013-12-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | _enum_methods_module should be kept private | Godfrey Chan | 2013-12-05 | 1 | -6/+7 | |
| | | | | ||||||
* | | | | Make clear that the enum array should not be changed once defined. [ci skip] | Godfrey Chan | 2013-12-05 | 1 | -1/+12 | |
| | | | | ||||||
* | | | | Add integration test for #12459 | George Guimarães | 2013-12-05 | 1 | -0/+8 | |
| | | | | ||||||
* | | | | fix pg warnings on geometric types | Aaron Patterson | 2013-12-05 | 1 | -10/+23 | |
| | | | | ||||||
* | | | | Improve AR changelog [ci skip] | Carlos Antonio da Silva | 2013-12-05 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Use the right type_map | Rafael Mendonça França | 2013-12-05 | 2 | -5/+3 | |
| | | | | ||||||
* | | | | Remove deprecated call to Relation#all | Carlos Antonio da Silva | 2013-12-05 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | polymorphic belongs_to association with touch: true updates old record correctly | Severin Schoepke | 2013-12-05 | 3 | -17/+63 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed. | |||||
* | | | | end sentences with a `.`. [ci skip] | Yves Senn | 2013-12-05 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Use the released arel gem | Rafael Mendonça França | 2013-12-05 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | make the type_map per connection. fixes #13182 | Aaron Patterson | 2013-12-04 | 2 | -12/+17 | |
| | | | | ||||||
* | | | | Merge pull request #12403 from thedarkone/attr-method-missing-fix | Rafael Mendonça França | 2013-12-04 | 2 | -3/+51 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods Conflicts: activerecord/lib/active_record/attribute_methods.rb | |||||
| * | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods. | thedarkone | 2013-09-29 | 2 | -3/+51 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was happening when a `super` call in an overwritten attribute method was triggering a method_missing fallback, because attribute methods haven't been generated yet. class Topic < ActiveRecord::Base def title # `super` would re-invoke this method if define_attribute_methods # hasn't been called yet resulting in double '!' appending super + '!' end end | |||||
* | | | | | Improve AR changelog, add entry for migration error improvements #12462 [ci ↵ | Carlos Antonio da Silva | 2013-12-03 | 1 | -2/+12 | |
| | | | | | | | | | | | | | | | | | | | | skip] | |||||
* | | | | | Merge pull request #12462 from jjb/improve_ar_exception_message_formatting | Carlos Antonio da Silva | 2013-12-03 | 1 | -8/+15 | |
|\ \ \ \ \ | | | | | | | | | | | | | Improve formatting of ActiveRecord migration exception messages |