Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #27442 from kamipo/fix_27434 | Eileen M. Uchitelle | 2016-12-27 | 3 | -14/+17 |
|\ | | | | | Add a record to target before any callbacks loads the record | ||||
| * | Add a record to target before any callbacks loads the record | Ryuta Kamizono | 2016-12-23 | 3 | -14/+17 |
| | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434. | ||||
* | | Small edits to activerecord/CHANGELOG.md | Jon Moss | 2016-12-27 | 1 | -2/+2 |
| | | | | | | | | | | | | | | [ci skip] - add period where necessary - add backticks where necessary | ||||
* | | assert_equal takes expectation first | Akira Matsuda | 2016-12-26 | 8 | -19/+19 |
| | | |||||
* | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 4 | -10/+10 |
| | | |||||
* | | Merge pull request #27448 from kamipo/no_need_doc_for_nodoc_classes | Akira Matsuda | 2016-12-25 | 5 | -15/+15 |
|\ \ | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | ||||
| * | | No need `:doc:` for `:nodoc:` classes [ci skip] | Ryuta Kamizono | 2016-12-25 | 5 | -15/+15 |
| | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html | ||||
* | | | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 22 | -77/+77 |
|/ / | |||||
* | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 |
| | | |||||
* | | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 |
| | | |||||
* | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 |
| | | |||||
* | | Privatize unneededly protected methods in Active Record tests | Akira Matsuda | 2016-12-24 | 11 | -11/+11 |
| | | |||||
* | | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 24 | -0/+50 |
|/ | |||||
* | fix #create_fixtures when equal table names in different databases | Julia Lopez | 2016-12-21 | 6 | -3/+28 |
| | |||||
* | Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_key | Eileen M. Uchitelle | 2016-12-19 | 1 | -6/+0 |
|\ | | | | | Remove useless `test_supports_primary_key` | ||||
| * | Remove useless `test_supports_primary_key` | Ryuta Kamizono | 2016-12-19 | 1 | -6/+0 |
| | | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors. | ||||
* | | Consolidate duplicated elsif branch | Ryuta Kamizono | 2016-12-19 | 1 | -6/+1 |
|/ | |||||
* | Merge pull request #27329 from kamipo/simplify_unsigned_regex | Eileen M. Uchitelle | 2016-12-17 | 2 | -3/+2 |
|\ | | | | | Simplify the regex for `unsigned?` method | ||||
| * | Simplify the regex for `unsigned?` method | Ryuta Kamizono | 2016-12-11 | 2 | -3/+2 |
| | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`. | ||||
* | | Merge pull request #27375 from kirs/fixture-error-message | Rafael França | 2016-12-16 | 3 | -4/+20 |
|\ \ | | | | | | | Throw friendly error message when fixture is not a hash | ||||
| * | | Throw friendly error message when fixture is not a hash | Kir Shatrov | 2016-12-15 | 3 | -4/+20 |
| | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid. | ||||
* | | | fix QueryCache nil dup | Richard Monette | 2016-12-15 | 5 | -5/+34 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog | ||||
* | | | fix new warning in ruby 2.4 | yuuji.yaginuma | 2016-12-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` test/caching_test.rb:986: warning: parentheses after method name is interpreted as test/caching_test.rb:986: warning: an argument list, not a decomposed argument test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument ``` Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24 | ||||
* | | | Add CHANGELOG entry to #27042 | Rafael Mendonça França | 2016-12-13 | 1 | -0/+4 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #27042 from kirs/yaml-schema-cache | Rafael França | 2016-12-13 | 6 | -15/+433 |
|\ \ \ | | | | | | | | | Schema cache in YAML | ||||
| * | | | Use YAML to serialize schema cache | Kir Shatrov | 2016-11-27 | 6 | -15/+433 |
| | | | | |||||
* | | | | Add a changelog entry for #26687 [ci skip] | Ryuta Kamizono | 2016-12-12 | 1 | -0/+7 |
| | | | | |||||
* | | | | Remove duplicated line | Ryuta Kamizono | 2016-12-11 | 1 | -1/+0 |
| |_|/ |/| | | |||||
* | | | Merge pull request #27323 from kamipo/add_changelog_for_25227 | Matthew Draper | 2016-12-11 | 1 | -0/+4 |
|\ \ \ | | | | | | | | | Add a changelog entry for #25227 [ci skip] | ||||
| * | | | Add a changelog entry for #25227 [ci skip] | Ryuta Kamizono | 2016-12-10 | 1 | -0/+4 |
| | |/ | |/| | |||||
* / | | Fix CI failure caused by #25227 and #25280 were merged at the same time | Ryuta Kamizono | 2016-12-10 | 2 | -2/+2 |
|/ / | |||||
* | | Merge pull request #25280 from ↵ | Sean Griffin | 2016-12-10 | 2 | -0/+16 |
|\ \ | | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations | ||||
| * | | Prevent `RangeError` for `belongs_to` associations | Ryuta Kamizono | 2016-10-10 | 2 | -0/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140. | ||||
* | | | Merge pull request #25227 from kamipo/numeric_value_out_of_range | Sean Griffin | 2016-12-10 | 7 | -8/+26 |
|\ \ \ | | | | | | | | | Translate numeric value out of range to the specific exception | ||||
| * | | | Translate numeric value out of range to the specific exception | Ryuta Kamizono | 2016-12-06 | 7 | -8/+26 |
| | | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range. | ||||
* | | | | Add a changelog entry for #25451 [ci skip] | Ryuta Kamizono | 2016-12-10 | 1 | -8/+13 |
| | | | | |||||
* | | | | Emulate db trigger behaviour for after_commit :destroy, :update | Stefan Budeanu | 2016-12-09 | 4 | -5/+67 |
| | | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger. | ||||
* | | | | Resolve association class correctly when assigning ids on a through association | Matthew Draper | 2016-12-09 | 3 | -1/+12 |
| | | | | |||||
* | | | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value. | utilum | 2016-12-08 | 1 | -0/+1 |
| | | | | |||||
* | | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodel | Sean Griffin | 2016-12-08 | 6 | -4/+57 |
|\ \ \ \ | | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord | ||||
| * | | | | Moved database-specific ActiveModel types into ActiveRecord | Iain Beeston | 2016-10-14 | 6 | -3/+57 |
| | | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger | ||||
* | | | | | Check whether the current attribute being write is aliased or not before writing | Prathamesh Sonpatki | 2016-12-09 | 3 | -2/+20 |
| | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. | ||||
* | | | | | Check whether the current attribute being read is aliased or not before reading | Prathamesh Sonpatki | 2016-12-08 | 3 | -2/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417. | ||||
* | | | | | Merge pull request #27278 from kamipo/should_be_sync_primary_key_definition | Sean Griffin | 2016-12-08 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Should be sync the `primary_key` definition with actually created | ||||
| * | | | | | Should be sync the `primary_key` definition with actually created | Ryuta Kamizono | 2016-12-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually the `primary_key` definition is not used but the inconsistency is confusing. Actual definition is `bigint auto_increment PRIMARY KEY` so `UNSIGNED` and `(8)` is unnecessary. See also #21607. | ||||
* | | | | | | Add some documentation around internal APIs [ci skip] | Sean Griffin | 2016-12-08 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While these method aren't public API, they are a non-trivial internal API which warrant a bit of explanation. | ||||
* | | | | | | Merge pull request #27251 from ebeigarts/fix-autosave | Sean Griffin | 2016-12-06 | 2 | -3/+27 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix association scope inside autosaved association callbacks | ||||
| * | | | | | | Improve test without using anonymous classes | Edgars Beigarts | 2016-12-06 | 1 | -27/+24 |
| | | | | | | | |||||
| * | | | | | | Reload association scope inside autosaved associations | Edgars Beigarts | 2016-12-02 | 2 | -3/+30 |
| | | | | | | | |||||
* | | | | | | | [ci skip] Document regex change | Alex Kitchens | 2016-12-06 | 1 | -0/+1 |
| |_|_|/ / / |/| | | | | |