aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Fixed the inferred table name for HABTM within a schemaEric Chahin2014-05-203-1/+33
| | | | Fixes #14824.
* fix `rake test_sqlite3_mem`.Yves Senn2014-05-201-0/+1
| | | | | | | | | | | | | | | | | | | | While running Sqlite3 memory tests I encountered the following error: ``` Finished in 69.416366s, 58.0267 runs/s, 162.3681 assertions/s. 1) Error: ActiveRecord::Migration::ChangeSchemaTest#test_add_column_with_timestamp_type: NoMethodError: undefined method `type' for nil:NilClass /Users/senny/Projects/rails/activerecord/test/cases/migration/change_schema_test.rb:244:in `test_add_column_with_timestamp_type' 4028 runs, 11271 assertions, 0 failures, 1 errors, 1 skips ``` This was because the table `testings` was used in multiple test-cases. This resulted in a wrongly cached schema on `ActiveRecord::Base.schema_chae`. /cc @zuhao
* docs, `instantiate` expects `String` keys. [Rafal Piekarski & Yves Senn]Yves Senn2014-05-202-4/+15
| | | | | Closes #15122 Closes #15107
* Remove :timestamp column typeSean Griffin2014-05-1918-47/+52
| | | | | | | | | | | | The `:timestamp` type for columns is unused. All database adapters treat them as the same database type. All code in `ActiveRecord` which changes its behavior based on the column's type acts the same in both cases. However, when the type is passed to code that checks for the `:datetime` type, but not `:timestamp` (such as XML serialization), the result is unexpected behavior. Existing schema definitions will continue to work, and the `timestamp` type is transparently aliased to `datetime`.
* Fixing test order issuesRafael Mendonça França2014-05-191-2/+8
|
* Merge pull request #10798 from ↵Rafael Mendonça França2014-05-193-1/+65
|\ | | | | | | | | | | | | | | | | | | jcxplorer/fix-enable_extension-with-table_name_prefix Fix migrations that use enable_extension with table_name_prefix/suffix Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/migration.rb
| * Fix migrations with enable_extensionJoao Carlos2013-05-293-1/+65
| | | | | | | | | | | | | | When using ActiveRecord::Base.table_name_prefix and/or table_name_suffix, extension names got the same treatment as table names when running migrations. This led to migrations that tried to call, for example, enable_extension("prefix_hstore") on the connection.
* | Delegate `Column#type` to the injected type objectSean Griffin2014-05-1929-117/+570
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decision to wrap type registrations in a proc was made for two reasons. 1. Some cases need to make an additional decision based on the type (e.g. a `Decimal` with a 0 scale) 2. Aliased types are automatically updated if they type they point to is updated later. If a user or another adapter decides to change the object used for `decimal` columns, `numeric`, and `number` will automatically point to the new type, without having to track what types are aliased explicitly. Everything else here should be pretty straightforward. PostgreSQL ranges had to change slightly, since the `simplified_type` method is gone.
* | test, inline `DeveloperWithAggregate`, which is used by a single test.Yves Senn2014-05-192-7/+7
| |
* | Merge pull request #15168 from ↵Rafael Mendonça França2014-05-191-0/+2
|\ \ | | | | | | | | | | | | eileencodes/return-early-on-delete-and-destroy-methods Return early on delete and destroy methods
| * | early return on delete and destroy methodseileencodes2014-05-181-0/+2
| | | | | | | | | | | | | | | | | | When delete or destroy is called on all records nothing is deleted or destroyed. Intead of running through the code and still not deleteing anything, we should early return
* | | Merge pull request #14126 from schuetzm/index_option_for_columnRafael Mendonça França2014-05-193-6/+28
|\ \ \ | | | | | | | | Make `:index` in migrations work with all column types
| * | | Make `:index` in migrations work with all column typesMarc Schütz2014-05-183-6/+28
| |/ /
* | | Merge pull request #15160 from sgrif/sg-destructured-eachRafael Mendonça França2014-05-191-4/+4
|\ \ \ | | | | | | | | Use destructured arguments when looping through pairs
| * | | Use destructured arguments when looping through pairsSean Griffin2014-05-171-4/+4
| | | | | | | | | | | | | | | | Minor refactoring of looping behavior for aggregation
* | | | pg, re-introduce `PostgreSQL::Utils` to unify schema/table extraction.Yves Senn2014-05-196-39/+51
| | | | | | | | | | | | | | | | Partial revert of c0bfc3f412834ffe8327a15ae3a46602cc28e425
* | | | pg, add missing nodocs for extracted modules.Yves Senn2014-05-195-10/+10
| | | |
* | | | Merge pull request #14962 from arunagw/aa-fix-rake-activerecordYves Senn2014-05-191-71/+74
|\ \ \ \ | | | | | | | | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]
| * | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-161-71/+74
| | | | |
* | | | | Merge pull request #15156 from sgrif/sg-postgres-timestampsYves Senn2014-05-181-6/+3
|\ \ \ \ \ | |_|_|/ / |/| | | | PostgreSQL timestamps should always be datetimes
| * | | | PostgreSQL timestamps are always datetimesSean Griffin2014-05-171-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current behavior is that they are treated as `datetime` normally, but if they are part of an array, they are treated as `timestamp`. The only place that seems to be impacted by this is schema dumping, which shouldn't matter since `t.datetime` and `t.timestamp` are equivalent in the `PostgreSQL` adapter, anyway.
* | | | | Add a type object to Column constructorSean Griffin2014-05-1714-57/+86
| |_|/ / |/| | | | | | | | | | | | | | | | | | | Part of #15134. In order to perform typecasting polymorphically, we need to add another argument to the constructor. The order was chosen to match the `oid_type` on `PostgreSQLColumn`.
* | | | Remove dead test code for unsupported adaptersSean Griffin2014-05-1719-183/+82
|/ / /
* | | Merge pull request #14428 from jnormore/reset_counters_aliasRafael Mendonça França2014-05-173-8/+27
|\ \ \ | | | | | | | | Updates reset_counters to allow counter name in params
| * | | Updates reset_counters to allow counter name in paramsJason Normore2014-05-163-8/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for counter name to be passed as parameter on `CounterCache::ClassMethods#reset_counters`. This is to be consistent with the other methods in the module that all accept counter name.
* | | | Add missing tests for column type cast behaviorSean Griffin2014-05-171-0/+36
| | | |
* | | | fix typo [ci skip]Vijay Dev2014-05-171-1/+1
| | | |
* | | | Fix typo in CHANGELOG entry for #15071Leandro Facchinetti2014-05-171-1/+3
|/ / /
* | | Add CHANGELOG entry for #15071 [ci skip]Rafael Mendonça França2014-05-161-0/+8
| | |
* | | Merge pull request #15071 from leafac/issues/11985Rafael Mendonça França2014-05-162-4/+18
|\ \ \ | |/ / |/| | Fix `Relation#delete_all` inconsistency
| * | Fix `Relation#delete_all` inconsistencyLeandro Facchinetti2014-05-162-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985
* | | Remove unecessary requireArthur Neves2014-05-161-2/+0
| | |
* | | Remove the assignment for real this time.Zachary Scott2014-05-161-2/+2
| | | | | | | | | | | | | | | | | | cc: https://github.com/rails/rails/commit/a11e2fcff8cdc9691b977d8330abe63024f8c732#commitcomment-6353614 and 0369dbf
* | | prepend mutates the string so we can remove the assignmentRafael Mendonça França2014-05-161-1/+1
| | |
* | | Reuse the force_clear_transaction_record_stateRafael Mendonça França2014-05-161-1/+1
| | |
* | | Missed if :bomb:Rafael Mendonça França2014-05-161-1/+1
| | |
* | | Add a specific method to force the transaction record state clearRafael Mendonça França2014-05-161-5/+8
| | | | | | | | | | | | | | | | | | We are using that code path in only one place so we should not add a conditional to all the other cases. This will avoid performance regressions on the old paths.
* | | Merge pull request #15125 from arthurnn/small_refactoring_transaction_clearGodfrey Chan2014-05-162-4/+19
|\ \ \ | | | | | | | | Small refactoring on clear_transaction_record_state
| * | | Clear transaction state if callback raise rollbackArthur Neves2014-05-152-1/+14
| | | |
| * | | Small refactoring on clear_transaction_record_stateArthur Neves2014-05-151-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | Make sure when we clean the `@_start_transaction_state` var we do it in the same code-path. Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state`
* | | | Remove code related to adapter which are no longer in repoArun Agrawal2014-05-162-31/+1
| | | | | | | | | | | | | | | | As we have remove code for these adapters so no need to have tasks
* | | | formatting pass through CHANGELOGS. [ci skip]Yves Senn2014-05-161-5/+5
|/ / /
* | | Changed extract_limit in class Column to return correct mysql float and ↵Aaron Nelson2014-05-163-0/+47
| | | | | | | | | | | | double limits
* | | :scissors:Rafael Mendonça França2014-05-143-4/+0
| | |
* | | Methods of these modules are internalRafael Mendonça França2014-05-142-14/+14
| | | | | | | | | | | | | | | They should not be used on people application so they should not be present on the API documentation.
* | | Merge pull request #15088 from kares/shareable-modulesRafael Mendonça França2014-05-1411-68/+67
|\ \ \ | | | | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes
| * | | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵kares2014-05-144-40/+34
| | | | | | | | | | | | | | | | redundant
| * | | move PostgreSQL's DatabaseStatements out of the PostgreSQLAdapter name-spacekares2014-05-142-7/+7
| | | |
| * | | PostgreSQL's SchemaStatements seems a could candidate for re-use (with AR-JDBC)kares2014-05-142-8/+7
| | | |
| * | | introduce AR::ConnectionAdapters::PostgreSQL for sharing modules (with AR-JDBC)kares2014-05-147-15/+21
| | | | | | | | | | | | ... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 11:15:21 +0000