| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵ | Jon Leighton | 2011-01-03 | 14 | -114/+90 | |
| | | | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences. | |||||
| * | Fix test_any in relations_test.rb, which was failing when relations_test.rb ↵ | Jon Leighton | 2011-01-03 | 1 | -0/+8 | |
| | | | | | is run on its own (it passes when the entire suite is run). This is a hacky fix for a problem I didn't quite get to the bottom of, so I'd welcome a better solution... | |||||
| * | Rename AssociationProxy#foreign_key_present to foreign_key_present? | Jon Leighton | 2011-01-03 | 4 | -7/+7 | |
| | | ||||||
| * | Allow assignment on has_one :through where the owner is a new record [#5137 ↵ | Jon Leighton | 2011-01-03 | 15 | -85/+113 | |
| | | | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message! | |||||
| * | Have a proper AssociationReflection#foreign_type method rather than using ↵ | Jon Leighton | 2011-01-03 | 8 | -28/+24 | |
| | | | | | options[:foreign_type] | |||||
| * | Add documentation for the :foreign_type option on belongs_to | Jon Leighton | 2011-01-03 | 1 | -0/+5 | |
| | | ||||||
| * | Some basic tests for the :foreign_type option on belongs_to, which was ↵ | Jon Leighton | 2011-01-03 | 3 | -2/+33 | |
| | | | | | previously completely untested. | |||||
| * | herp derpricating add_limit_offset! | Aaron Patterson | 2011-01-03 | 3 | -12/+4 | |
| | | ||||||
| * | User id instead of quoted_id to prevent double quoting. Fixes failing test ↵ | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -1/+1 | |
| | | | | | for bug #6036. | |||||
| * | Added one more failing test for bug #6036 | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -0/+6 | |
| | | ||||||
| * | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 16 | -54/+56 | |
| | | | | | options key which it relates to is :foreign_key | |||||
| * | Support for :counter_cache on polymorphic belongs_to | Jon Leighton | 2010-12-31 | 3 | -1/+14 | |
| | | ||||||
| * | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 6 | -120/+127 | |
| | | | | | inherit from it | |||||
| * | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 4 | -6/+21 | |
| | | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | |||||
| * | Verify that when has_many associated objects are destroyed via :dependent => ↵ | Jon Leighton | 2010-12-31 | 2 | -1/+25 | |
| | | | | | :destroy, when the parent is destroyed, the callbacks are run | |||||
| * | Get rid of extra_conditions param from configure_dependency_for_has_many. I ↵ | Jon Leighton | 2010-12-31 | 1 | -9/+3 | |
| | | | | | can't see a particularly plausible argument for this being used by plugins, and if they really want they can just redefine the callback or whatever. Note also that before my recent commit the extra_conditions param was completely ignored for :dependent => :destroy. | |||||
| * | And owner_quoted_id can go too | Jon Leighton | 2010-12-31 | 3 | -22/+0 | |
| | | ||||||
| * | Now we can drop-kick AssociationReflection#dependent_conditions into oblivion. | Jon Leighton | 2010-12-31 | 1 | -11/+0 | |
| | | ||||||
| * | Refactor configure_dependency_for_has_many to use ↵ | Jon Leighton | 2010-12-31 | 2 | -41/+24 | |
| | | | | | AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0. | |||||
| * | Make sure Model#touch doesn't try to update non existing columns | Pratik Naik | 2010-12-30 | 2 | -2/+4 | |
| | | ||||||
| * | Make serialized fixtures work again | Pratik Naik | 2010-12-29 | 6 | -5/+20 | |
| | | ||||||
| * | Do not use primary key on insertion when it's nil | Santiago Pastorino | 2010-12-29 | 1 | -2/+2 | |
| | | ||||||
| * | Simplify inspect implementation | Santiago Pastorino | 2010-12-28 | 1 | -1/+1 | |
| | | | | | | After 304d38c0536dc32a8a1595ba34370ebf69a0d50d we don't need the new_record? check anymore. | |||||
| * | Allow primary_key to be an attribute when the model is a new record | Santiago Pastorino | 2010-12-28 | 3 | -4/+4 | |
| | | ||||||
| * | I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. | Aaron Patterson | 2010-12-27 | 3 | -15/+3 | |
| | | ||||||
| * | No need to symbolize these. | José Valim | 2010-12-27 | 1 | -2/+4 | |
| | | ||||||
| * | try not to make so many funcalls | Aaron Patterson | 2010-12-26 | 1 | -3/+6 | |
| | | ||||||
| * | make our hash of klasses and ids actually have classes for keys | Aaron Patterson | 2010-12-26 | 1 | -8/+6 | |
| | | ||||||
| * | stop calling deprecated apis | Aaron Patterson | 2010-12-26 | 2 | -5/+5 | |
| | | ||||||
| * | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 10 | -52/+41 | |
| | | | | | other things | |||||
| * | Add a HasAssociation module for common code for has_* associations | Jon Leighton | 2010-12-26 | 8 | -61/+69 | |
| | | ||||||
| * | Remove AssociationProxy#dependent? - it's badly named and only used in one place | Jon Leighton | 2010-12-26 | 2 | -6/+1 | |
| | | ||||||
| * | Associations: DRY up the code which is generating conditions, and make it ↵ | Jon Leighton | 2010-12-26 | 7 | -65/+50 | |
| | | | | | all use arel rather than SQL strings | |||||
| * | Fix dodgy tests which were effectively asserting nil == nil | Jon Leighton | 2010-12-26 | 2 | -3/+4 | |
| | | ||||||
| * | Remove custom_select param from construct_select, as it isn't used | Jon Leighton | 2010-12-26 | 1 | -3/+3 | |
| | | ||||||
| * | Remove construct_from from ThroughAssociationScope - it's not called from ↵ | Jon Leighton | 2010-12-26 | 1 | -4/+0 | |
| | | | | | anywhere | |||||
| * | Set the create scope to an empty hash in ThroughAssociationScope. For ↵ | Jon Leighton | 2010-12-26 | 1 | -1/+5 | |
| | | | | | reasoning please see the inline code comments. | |||||
| * | Use conditionals and implicit returns rather than explicit returns and ↵ | Jon Leighton | 2010-12-26 | 1 | -3/+7 | |
| | | | | | postfix ifs (it's easier to read) | |||||
| * | Remove has_cached_counter? and cached_counter_attribute_name from ↵ | Jon Leighton | 2010-12-26 | 1 | -8/+0 | |
| | | | | | HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation | |||||
| * | Remove pointless use of 'private' | Jon Leighton | 2010-12-26 | 1 | -1/+0 | |
| | | ||||||
| * | Use the through association proxy for operations on the through record, so ↵ | Jon Leighton | 2010-12-26 | 3 | -17/+17 | |
| | | | | | that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes. | |||||
| * | Remove target_obsolete? which is not called from anywhere | Jon Leighton | 2010-12-26 | 1 | -4/+0 | |
| | | ||||||
| * | scoped.where_values_hash is never nil | Jon Leighton | 2010-12-26 | 1 | -1/+1 | |
| | | ||||||
| * | refactor to use group_by | Aaron Patterson | 2010-12-25 | 1 | -3/+3 | |
| | | ||||||
| * | arel will deal with casting the ids, so we can delete this | Aaron Patterson | 2010-12-25 | 1 | -13/+1 | |
| | | ||||||
| * | use arel to determine selection column | Aaron Patterson | 2010-12-25 | 1 | -2/+1 | |
| | | ||||||
| * | refactoring method selection | Aaron Patterson | 2010-12-25 | 1 | -10/+5 | |
| | | ||||||
| * | using arel to compile sql statements | Aaron Patterson | 2010-12-25 | 4 | -10/+21 | |
| | | ||||||
| * | use sql literal factory method | Aaron Patterson | 2010-12-25 | 1 | -1/+1 | |
| | | ||||||
| * | take more advantage of arel sql compiler | Aaron Patterson | 2010-12-25 | 2 | -13/+21 | |
| | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activerecord