Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 10 | -7/+29 |
| | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | ||||
* | Merge pull request #12188 from SamSaffron/master | Aaron Patterson | 2013-09-11 | 4 | -12/+16 |
|\ | | | | | Perf: avoid dupes add fallback logic for coders | ||||
| * | Perf: avoid dupes add fallback logic for coders | Sam | 2013-09-11 | 4 | -12/+16 |
| | | |||||
* | | Merge pull request #12135 from dylanahsmith/avoid_empty_transaction | Rafael Mendonça França | 2013-09-11 | 3 | -1/+10 |
|\ \ | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Avoid empty transaction from setting has_one association on new record. | Dylan Thacker-Smith | 2013-09-11 | 3 | -1/+9 |
| | | | |||||
* | | | Whitespaces | Rafael Mendonça França | 2013-09-11 | 1 | -1/+2 |
| | | | |||||
* | | | Merge pull request #12185 from SamSaffron/join_dep | Rafael Mendonça França | 2013-09-11 | 1 | -1/+13 |
|\ \ \ | | | | | | | | | Reduce allocations when extracting AR models | ||||
| * | | | Reduce allocations when extracting AR models | Sam | 2013-09-11 | 1 | -1/+13 |
| | | | | |||||
* | | | | Merge pull request #12194 from thedarkone/readonly-merger-fix | Rafael Mendonça França | 2013-09-11 | 3 | -1/+17 |
|\ \ \ \ | | | | | | | | | | | Relation#merge should not lose readonly(false) flag. | ||||
| * | | | | Relation#merge should not lose readonly(false) flag. | thedarkone | 2013-09-11 | 3 | -1/+17 |
| |/ / / | | | | | | | | | | | | | The original code ignores the `false` value because `false.blank? # => true`. | ||||
* | / / | fix deleting join models with no pk | Aaron Patterson | 2013-09-11 | 2 | -6/+62 |
| |/ / |/| | | |||||
* | | | add a comment for sanity of other people to come | Aaron Patterson | 2013-09-10 | 1 | -0/+8 |
| | | | |||||
* | | | ask the association for records rather than calling `send` | Aaron Patterson | 2013-09-10 | 1 | -1/+2 |
| | | | |||||
* | | | More unused associations in AR test models | Akira Matsuda | 2013-09-10 | 8 | -13/+0 |
| | | | |||||
* | | | :scissors: [ci skip] | Carlos Antonio da Silva | 2013-09-10 | 1 | -1/+1 |
| | | | |||||
* | | | change function def self.table_name to self.table_name | Rajarshi Das | 2013-09-10 | 2 | -5/+3 |
| | | | | | | | | | | | | | | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key | ||||
* | | | Clean up unused associations in AR test model | Akira Matsuda | 2013-09-10 | 1 | -3/+0 |
|/ / | |||||
* | | let the class cache object clean up user input | Aaron Patterson | 2013-09-09 | 1 | -8/+20 |
| | | |||||
* | | make @bitsweat happy. :heart: | Aaron Patterson | 2013-09-09 | 1 | -0/+6 |
| | | |||||
* | | stop using deprecated api in the tests | Aaron Patterson | 2013-09-09 | 1 | -1/+1 |
| | | |||||
* | | Typo in Changelog. | Ryan Wallace | 2013-09-08 | 1 | -2/+2 |
| | | |||||
* | | Fix fixtures regression that required table names to map to classes only, ↵ | Jeremy Kemper | 2013-09-08 | 2 | -2/+2 |
| | | | | | | | | not class names | ||||
* | | hm:t join tables may not have a primary key | Aaron Patterson | 2013-09-06 | 2 | -1/+23 |
| | | |||||
* | | use polymorphic proxies to remove duplicate code | Aaron Patterson | 2013-09-06 | 1 | -24/+43 |
| | | |||||
* | | reduce duplication somewhat | Aaron Patterson | 2013-09-06 | 1 | -14/+14 |
| | | |||||
* | | make the duplicate code more similar | Aaron Patterson | 2013-09-06 | 1 | -4/+10 |
| | | |||||
* | | auto link hm:t fixture join tables like habtm | Aaron Patterson | 2013-09-06 | 2 | -0/+51 |
| | | |||||
* | | don't depend on object state when reading fixture files | Aaron Patterson | 2013-09-06 | 1 | -8/+7 |
| | | |||||
* | | ensure @model_class is initialized | Aaron Patterson | 2013-09-06 | 1 | -0/+1 |
| | | |||||
* | | no need to dup | Aaron Patterson | 2013-09-05 | 1 | -1/+1 |
| | | |||||
* | | push logic outside the FixtureSet constructor | Aaron Patterson | 2013-09-05 | 1 | -3/+3 |
| | | |||||
* | | only construct the FixtureSet with AR models | Aaron Patterson | 2013-09-05 | 1 | -2/+11 |
| | | |||||
* | | push constant lookup in the a cache object | Aaron Patterson | 2013-09-05 | 1 | -2/+21 |
| | | |||||
* | | Add a test case for exists? with multiple values | Rafael Mendonça França + Kassio Borges | 2013-09-04 | 1 | -0/+1 |
| | | |||||
* | | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_args | Yves Senn | 2013-09-04 | 5 | -15/+52 |
|\ \ | | | | | | | Re-use order arguments pre-processing for reorder | ||||
| * | | Extracted from `order` processing of arguments, and use it for `reorder` to ↵ | Paul Nikitochkin | 2013-09-04 | 5 | -15/+52 |
| | | | | | | | | | | | | be consistent. | ||||
* | | | adding a hm:t test for singleton ar objects | Aaron Patterson | 2013-09-03 | 1 | -0/+27 |
| | | | |||||
* | | | support anonymous classes on has_many associations | Aaron Patterson | 2013-09-03 | 3 | -1/+20 |
| | | | |||||
* | | | Merge pull request #12065 from SamSaffron/result_optimisation | Aaron Patterson | 2013-09-03 | 1 | -1/+15 |
|\ \ \ | | | | | | | | | Perf: micro optimised Result column hash_row creation | ||||
| * | | | Perf: micro optimised Result column hash_row creation | Sam | 2013-08-29 | 1 | -1/+15 |
| | | | | |||||
* | | | | Revert "Merge pull request #12085 from valk/master" | Santiago Pastorino | 2013-09-03 | 1 | -3/+1 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 15455d76c8d33b3767a61e0cdd2de0ff592098ef, reversing changes made to ffa56f73d5ae98fe0b8b6dd2ca6f0dffac9d9217. | ||||
* | | | | Remove useless comment and white spaces :scissors: [ci skip] | Carlos Antonio da Silva | 2013-09-01 | 2 | -3/+2 |
| | | | | |||||
* | | | | clear all connections before forking | Aaron Patterson | 2013-08-31 | 1 | -0/+3 |
| | | | | |||||
* | | | | Revert "Do not dup the binds when visiting the AST" | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 3 | -10/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this. | ||||
* | | | | Don't need to check if the scope respond to call | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 3 | -7/+3 |
| | | | | | | | | | | | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError | ||||
* | | | | Revert "reconnect after the fork returns" | Rafael Mendonça França | 2013-08-31 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit baf5f47b8768c7ec0164ed5ab60e369cdd936d71. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove | ||||
* | | | | Do not dup the binds when visiting the AST | Rafael Mendonça França | 2013-08-31 | 3 | -3/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023 | ||||
* | | | | Don't use Enumerable#next in pluck since it is very slow | Ryan Wallace | 2013-08-30 | 1 | -2/+1 |
| | | | | |||||
* | | | | Merge pull request #12090 from njakobsen/merger-performance | Aaron Patterson | 2013-08-30 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | [Performance] Don't create fibers while merging bind variables | ||||
| * | | | | Don't create fibers just to iterate | Nicholas Jakobsen | 2013-08-30 | 1 | -3/+3 |
| | | | | |