Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #18362 from georgemillo/attribute | Rafael Mendonça França | 2015-01-06 | 1 | -3/+2 |
|\ | | | | | replacing 'attribute' method with an alias | ||||
| * | replacing 'attribute' method with an alias | George Millo | 2015-01-06 | 1 | -3/+2 |
| | | |||||
* | | Fixed typos and wording in ActiveRecord CHANGELOG [ci skip] | Prathamesh Sonpatki | 2015-01-06 | 1 | -5/+5 |
| | | |||||
* | | Merge pull request #18358 from ↵ | Yves Senn | 2015-01-06 | 4 | -1/+12 |
|\ \ | |/ |/| | | | | | | | prathamesh-sonpatki/add-test-for-non-string-labeled-fixtures Fix lookup of fixtures with non-string(like Fixnum) label | ||||
| * | Fix lookup of fixtures with non-string label | Prathamesh Sonpatki | 2015-01-06 | 4 | -1/+13 |
|/ | | | | | | | | | | | - Fixtures with non-string labels such as integers should be accessed using integer label as key. For eg. pirates(1) or pirates(42). - But this results in NotFound error because the label is converted into string before looking up into the fixtures hash. - After this commit, the label is converted into string only if its a symbol. - This issue was fount out while adding a test case for https://github.com/rails/rails/commit/7b910917. | ||||
* | Merge pull request #18350 from brainopia/fix_build_from_bind_values | Sean Griffin | 2015-01-05 | 2 | -2/+12 |
|\ | | | | | Propagate bind_values from join in subquery | ||||
| * | Correctly fetch bind_values from join in subquery | brainopia | 2015-01-06 | 2 | -2/+12 |
| | | |||||
* | | Define attribute methods before attempting to populate records | Sean Griffin | 2015-01-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | `initialize_internals_callback` will attempt to assign attributes from the current scope, which will fail if something defined the method and calls super (meaning it won't hit `method_missing`). Fixes #18339 | ||||
* | | Whitespace fixes from #18349 | Sean Griffin | 2015-01-05 | 1 | -2/+1 |
| | | |||||
* | | Merge pull request #18349 from jdelStrother/primarykeyless | Sean Griffin | 2015-01-05 | 2 | -1/+23 |
|\ \ | |/ |/| | Fix rollback of primarykey-less tables | ||||
| * | Fix rollback of primarykey-less tables | Jonathan del Strother | 2015-01-05 | 2 | -1/+23 |
| | | | | | | If you have a table without a primary key, and an `after_commit` callback on that table (ie `has_transactional_callbacks?` returns true), then trying to rollback a transaction involving that record would result in “ActiveModel::MissingAttributeError: can't write unknown attribute ``” | ||||
* | | Add firebird support to test suite | Ray Zane | 2015-01-05 | 5 | -21/+28 |
| | | |||||
* | | Merge pull request #18344 from jonatack/patch-1 | Rafael Mendonça França | 2015-01-05 | 1 | -5/+5 |
|\ \ | | | | | | | Clean up secure_token_test | ||||
| * | | Clean up secure_token_test | Jon Atack | 2015-01-05 | 1 | -5/+5 |
| | | | |||||
* | | | Fix TypeError in Fixture creation | Matt Hogan | 2015-01-05 | 1 | -1/+1 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 4.2 started doing `value.gsub('$LABEL', label)` for fixture label interpolation, but you can have have valid YAML where `label` isn't a String. For example: ```YAML 0: name: John email: johndoe@gmail.com 1: name: Jane email: janedoe@gmail.com ``` This YAML will create a label that is a Fixnum, causing `TypeError: no implicit conversion of Fixnum into String.` | ||||
* | | Fix typo in changelog [ci skip] | Carlos Antonio da Silva | 2015-01-05 | 1 | -1/+1 |
| | | |||||
* | | remove deprecated support to preload instance-dependent associaitons. | Yves Senn | 2015-01-05 | 4 | -32/+16 |
| | | | | | | | | Addresses https://github.com/rails/rails/commit/ed56e596a0467390011bc9d56d462539776adac1#commitcomment-9145960 | ||||
* | | remove deprecated support for PG ranges with exclusive lower bounds. | Yves Senn | 2015-01-05 | 3 | -37/+10 |
| | | | | | | | | addresses https://github.com/rails/rails/commit/91949e48cf41af9f3e4ffba3e5eecf9b0a08bfc3#commitcomment-9144563 | ||||
* | | can't kill thread with in-memory db. fixes `rake test:sqlite3_mem`. | Yves Senn | 2015-01-05 | 1 | -0/+2 |
| | | |||||
* | | remove deprecation warning when modifying a Relation with cached arel. | Yves Senn | 2015-01-05 | 3 | -21/+27 |
| | | | | | | | | This adresses https://github.com/rails/rails/commit/1b7aa62b184c4410c99208f71b59bbac5c5f03be#commitcomment-9147803 | ||||
* | | add punctuation. [ci skip] | Yves Senn | 2015-01-05 | 1 | -2/+2 |
| | | |||||
* | | Remove version conditional for calling GC.disable | Rafael Mendonça França | 2015-01-04 | 1 | -1/+1 |
| | | |||||
* | | Remove Thread hack for Ruby 1.9 | claudiob | 2015-01-04 | 1 | -23/+18 |
| | | | | | | | | | | | | | | | | The hack so skip a Thread test for Ruby 1.9 can be removed now that Rails requires Ruby >= 2.0. Conflicts: activerecord/test/cases/transactions_test.rb | ||||
* | | remove files which is dependent on ruby1.9 as we do not support Ruby1.9 | Kuldeep Aggarwal | 2015-01-04 | 2 | -44/+24 |
| | | | | | | | | | | Conflicts: activerecord/lib/active_record/attribute_methods/read.rb | ||||
* | | Merge pull request #18217 from robertomiranda/has_secure_token | David Heinemeier Hansson | 2015-01-04 | 7 | -0/+104 |
|\ \ | | | | | | | Add has_secure_token to Active Record | ||||
| * | | Add has_secure_token to Active Record | robertomiranda | 2015-01-04 | 7 | -0/+104 |
| | | | | | | | | | | | | | | | | | | Update SecureToken Docs Add Changelog entry for has_secure_token [ci skip] | ||||
* | | | Simplify boolean casting logic | Carlos Antonio da Silva | 2015-01-04 | 1 | -3/+1 |
|/ / | |||||
* | | Remove unneeded `require 'as/deprecation'` | claudiob | 2015-01-04 | 1 | -1/+0 |
| | | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed. | ||||
* | | Remove unneeded requires | Rafael Mendonça França | 2015-01-04 | 3 | -6/+0 |
| | | | | | | | | These requires were added only to change deprecation message | ||||
* | | Change the behavior of boolean columns to be closer to Ruby's semantics. | Rafael Mendonça França | 2015-01-04 | 4 | -19/+16 |
| | | | | | | | | | | | | | | | | Before this change we had a small set of "truthy", and all others are "falsy". Now, we have a small set of "falsy" values and all others are "truthy" matching Ruby's semantics. | ||||
* | | Change transaction callbacks to not swallowing errors. | Rafael Mendonça França | 2015-01-04 | 5 | -75/+25 |
| | | | | | | | | | | | | | | | | Before this change any error raised inside a transaction callback are rescued and printed in the logs. Now these errors are not rescue anymore and just bubble up, as the other callbacks. | ||||
* | | Remove deprecated `sanitize_sql_hash_for_conditions` | Rafael Mendonça França | 2015-01-04 | 3 | -40/+4 |
| | | |||||
* | | Remove deprecated `Reflection#source_macro` | Rafael Mendonça França | 2015-01-04 | 2 | -19/+4 |
| | | |||||
* | | Remove deprecated `symbolized_base_class` and `symbolized_sti_name` | Rafael Mendonça França | 2015-01-04 | 2 | -10/+4 |
| | | |||||
* | | Remove deprecated `ActiveRecord::Fixtures` constant | Rafael Mendonça França | 2015-01-04 | 1 | -6/+0 |
| | | |||||
* | | Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=` | Rafael Mendonça França | 2015-01-04 | 3 | -13/+4 |
| | | |||||
* | | Remove deprecated access to connection specification using a string acessor. | Rafael Mendonça França | 2015-01-04 | 3 | -58/+7 |
| | | | | | | | | Now all strings will be handled as a URL. | ||||
* | | Change the default `null` value for `timestamps` to `false` | Rafael Mendonça França | 2015-01-04 | 7 | -80/+37 |
| | | |||||
* | | Return an array of pools from `connection_pools` | Rafael Mendonça França | 2015-01-04 | 3 | -13/+6 |
| | | |||||
* | | Return a null column from `column_for_attribute` when no column exists. | Rafael Mendonça França | 2015-01-04 | 5 | -16/+36 |
| | | | | | | | | | | | | | | | | This reverts commit ae96f229f6501d8635811d6b22d75d43cdb880a4. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/attribute_methods.rb | ||||
* | | Remove deprecated `serialized_attributes` | Rafael Mendonça França | 2015-01-04 | 3 | -19/+4 |
| | | |||||
* | | Remove `cache_attributes` and friends | Rafael Mendonça França | 2015-01-04 | 2 | -25/+0 |
| | | |||||
* | | Remove deprecated automatic counter caches on `has_many :through` | Rafael Mendonça França | 2015-01-04 | 3 | -40/+4 |
| | | |||||
* | | Remove deprecated `ActiveModel::Dirty#reset_#{attribute}` and ↵ | Rafael Mendonça França | 2015-01-04 | 1 | -12/+0 |
| | | | | | | | | `ActiveModel::Dirty#reset_changes`. | ||||
* | | Remove deprecated methods at `Kernel`. | Rafael Mendonça França | 2015-01-04 | 2 | -1/+23 |
|/ | | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`. | ||||
* | Merge pull request #18319 from kamipo/sql_type_has_been_determined | Rafael Mendonça França | 2015-01-04 | 1 | -4/+2 |
|\ | | | | | `sql_type` has been determined already when quoting defaults | ||||
| * | `sql_type` has been determined already when quoting defaults | Ryuta Kamizono | 2015-01-04 | 1 | -4/+2 |
| | | | | | | | | No need to call `type_to_sql` again. | ||||
* | | Merge pull request #18318 from ↵ | Rafael Mendonça França | 2015-01-04 | 1 | -1/+2 |
|\ \ | | | | | | | | | | | | | kamipo/stop_passing_the_column_when_quoting_defaults Stop passing the column to the `quote` method when quoting defaults | ||||
| * | | Stop passing the column to the `quote` method when quoting defaults | Ryuta Kamizono | 2015-01-04 | 1 | -1/+2 |
| |/ | | | | | | | Related the commit 8f8f8058e58dda20259c1caa61ec92542573643d. | ||||
* / | Prefer `array?` rather than `array` | Ryuta Kamizono | 2015-01-04 | 18 | -30/+29 |
|/ | | | | | | Slightly refactoring `PostgreSQLColumn`. `array` should be readonly. `default_function` should be initialized by `super`. `sql_type` has been removed `[]`. Since we already choose to remove it we should not change. |