Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove 'needless boolean casting'. | Jack Chen (chendo) | 2012-03-26 | 1 | -1/+1 |
| | | | | | "Predicates in Rails rely on standard Ruby semantics for boolean values and guarantee no singletons whatsoever." - @fxn | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-24 | 2 | -1/+15 |
|\ | | | | | | | | | Conflicts: guides/source/ruby_on_rails_guides_guidelines.textile | ||||
| * | Adding documentation for ActiveRecord::Base.abstract_class to clarify a ↵ | Joe Goggins | 2012-03-22 | 1 | -0/+14 |
| | | | | | | | | particular usecase for this feature (to allow you to use inheritance in ActiveRecord without using the STI table name | ||||
| * | Correct description of ['migrated_at > ?', 1.week.ago] from "more than a ↵ | Dave Burt | 2012-03-20 | 1 | -1/+1 |
| | | | | | | | | week ago" to "more recently than a week ago." | ||||
* | | properly namespace the fixture exception | Aaron Patterson | 2012-03-22 | 2 | -7/+3 |
| | | |||||
* | | Avoid another blank line in generated migration and remove assertion as per ↵ | Marcelo Silveira | 2012-03-21 | 1 | -1/+1 |
| | | | | | | | | @spastorino request | ||||
* | | Deprecate eager-evaluated scopes. | Jon Leighton | 2012-03-21 | 20 | -83/+159 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions | ||||
* | | Avoid obscure &Proc.new thing | Jon Leighton | 2012-03-21 | 1 | -2/+2 |
| | | |||||
* | | Remove valid_scope_name? check - use ruby | Jon Leighton | 2012-03-21 | 2 | -30/+1 |
| | | | | | | | | | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods. | ||||
* | | no need for cast | Jon Leighton | 2012-03-21 | 1 | -1/+0 |
| | | |||||
* | | no need for lvar | Jon Leighton | 2012-03-21 | 1 | -3/+1 |
| | | |||||
* | | Merge pull request #5532 from mhfs/migration_blank_line | José Valim | 2012-03-21 | 1 | -1/+1 |
|\ \ | | | | | | | Remove blank line from generated migration | ||||
| * | | Remove blank line from generated migration | Marcelo Silveira | 2012-03-20 | 1 | -1/+1 |
| |/ | |||||
* / | Generate Migration Thats Adds Removed Index | Travis Jeffery | 2012-03-21 | 1 | -0/+3 |
|/ | | | | | When generating a migration that removes a field with an index, the down will add both the field and its index. | ||||
* | changed all.map to pluck | Sandeep | 2012-03-19 | 1 | -1/+1 |
| | |||||
* | Merge pull request #3329 from armstrjare/autosave_collection_new_record_bug | José Valim | 2012-03-18 | 2 | -1/+16 |
|\ | | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction | ||||
| * | Fix bug with autosave collection association on new record with a marked for ↵ | Jared Armstrong | 2012-03-18 | 2 | -1/+16 |
| | | | | | | | | destroy record in autosave collection. | ||||
* | | Merge pull request #5486 from kennyj/fix_5435 | Aaron Patterson | 2012-03-17 | 1 | -0/+1 |
|\ \ | | | | | | | Fix GH #5435. db:structure:dump should be re-enable. | ||||
| * | | Fix GH #5435. db:structure:dump should be reenable. | kennyj | 2012-03-17 | 1 | -0/+1 |
| | | | |||||
* | | | Fix typo in ActiveRecord::Relation#blank? test | Ruben Davila | 2012-03-17 | 1 | -1/+1 |
| | | | |||||
* | | | Updates 'modyfing' typo to 'modifying' | Jonathan R. Wallace | 2012-03-17 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditions | José Valim | 2012-03-17 | 2 | -2/+30 |
|\ \ \ | |/ / |/| | | Add :conditions option to uniqueness validator | ||||
| * | | Correct grammar in documentation | Mattias Pfeiffer | 2012-03-07 | 1 | -1/+1 |
| | | | |||||
| * | | Change syntax to accept an AR::Relation instead of old conditions hash/array. | Mattias Pfeiffer | 2012-03-07 | 2 | -4/+10 |
| | | | |||||
| * | | Add :conditions option to uniqueness validator | Mattias Pfeiffer | 2012-03-07 | 2 | -2/+24 |
| | | | |||||
* | | | Fix ActiveRecord::Relation#blank? tests | Rafael Mendonça França | 2012-03-16 | 1 | -12/+15 |
| | | | |||||
* | | | Merge pull request #5469 from yakko/master | José Valim | 2012-03-16 | 1 | -0/+19 |
|\ \ \ | | | | | | | | | tests for Relation .present? .blank? | ||||
| * | | | test relation presence fix | Thiago Almeida | 2012-03-16 | 1 | -4/+4 |
| | | | | |||||
| * | | | tests for Relation .present? and .blank? are check cases and shouldn't force ↵ | Thiago Almeida | 2012-03-16 | 1 | -0/+19 |
| | | | | | | | | | | | | | | | | sql-count | ||||
* | | | | Merge pull request #5467 from bogdan/initialize_callbacks | José Valim | 2012-03-16 | 1 | -1/+1 |
|\ \ \ \ | |_|_|/ |/| | | | ActiveRecord::Core#initialize: improve performance | ||||
| * | | | ActiveRecord::Core#initialize: improve performance | Bogdan Gusiev | 2012-03-15 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #5461 from yakko/master | José Valim | 2012-03-16 | 1 | -0/+4 |
|\ \ \ \ | | |/ / | |/| | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id) | ||||
| * | | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id) | Thiago Almeida | 2012-03-16 | 1 | -0/+4 |
| | | | | |||||
* | | | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_column | Aaron Patterson | 2012-03-15 | 2 | -1/+12 |
|\ \ \ \ | |/ / / |/| | | | Don't reset inheritance_column when setting explicitly. | ||||
| * | | | Don't reset inheritance_column when setting explicitly. | kennyj | 2012-03-08 | 2 | -1/+12 |
| | | | | |||||
* | | | | errors should probably be logged as errors | Aaron Patterson | 2012-03-15 | 1 | -20/+19 |
| | | | | |||||
* | | | | Address the dump file format for hstore | Yasuo Honda | 2012-03-15 | 1 | -1/+1 |
| | | | | |||||
* | | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA. | kennyj | 2012-03-15 | 2 | -1/+8 |
| |/ / |/| | | |||||
* | | | Expand changelog and upgrading rails guide with IdentityMap info | Carlos Antonio da Silva | 2012-03-13 | 1 | -1/+10 |
| | | | |||||
* | | | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 29 | -945/+35 |
| | | | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-13 | 1 | -1/+3 |
|\ \ \ | |||||
| * | | | added clarification stating the counter_cache attribute needs to be created ↵ | Michael de Silva | 2012-03-11 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | on the associate class via a migration | ||||
* | | | | Fix GH #5399. connection_pools's keys are ↵ | kennyj | 2012-03-14 | 2 | -2/+8 |
| | | | | | | | | | | | | | | | | ActiveRecord::Base::ConnectionSpecification objects. | ||||
* | | | | Merge pull request #5294 from robinroestenburg/master | Aaron Patterson | 2012-03-12 | 3 | -26/+53 |
|\ \ \ \ | | | | | | | | | | | Refactoring of `arel_attributes_values` method | ||||
| * | | | | Removed flag attributes. | Robin Roestenburg | 2012-03-06 | 3 | -22/+35 |
| | | | | | |||||
| * | | | | Refactored method arel_attributes_values. | Robin Roestenburg | 2012-03-06 | 1 | -20/+34 |
| | | | | | |||||
* | | | | | make sure connections returned after close are marked as in_use | Aaron Patterson | 2012-03-12 | 2 | -4/+27 |
| | | | | | |||||
* | | | | | deprecated clear_stale_active_connections! can call #reap instead of ↵ | Jonathan Rochkind | 2012-03-12 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | no-op'ing, #reap does the same thing | ||||
* | | | | | Add documentation for find_or_create_by_{attribute}! method. | Andrew White | 2012-03-12 | 1 | -0/+3 |
| | | | | | |||||
* | | | | | Add dynamic find_or_create_by_{attribute}! method. | Andrew White | 2012-03-12 | 7 | -2/+80 |
| | | | | |