Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Merge pull request #10390 from Noemj/bind_param_handling | Rafael Mendonça França | 2013-04-30 | 1 | -3/+3 | |
| |\ \ | | | | | | | | | Added :nodoc: for relation.rb's private methods | |||||
| | * | | Added :nodoc: for private methods | Noemj | 2013-04-30 | 1 | -3/+3 | |
| | | | | ||||||
| * | | | mysql needs to reconnect after recreate. Thanks @mperham | Aaron Patterson | 2013-04-30 | 1 | -0/+1 | |
| | | | | ||||||
| * | | | Abort a rake task when missing db/structure.sql like `db:schema:load` task. | kennyj | 2013-05-01 | 4 | -6/+21 | |
| |/ / | ||||||
| * | | Moved update_record logic to relation.rb | Noemj | 2013-04-30 | 2 | -26/+28 | |
| | | | ||||||
* | | | Initial commit for select statements bindparam implementation | Noemj | 2013-05-15 | 4 | -6/+98 | |
|/ / | ||||||
* | | add missing :nodoc: marks to ActiveRecord::Delegation [ci skip] | Francesco Rodriguez | 2013-04-29 | 1 | -3/+3 | |
| | | ||||||
* | | rails/master is now 4.1.0.beta | Rafael Mendonça França | 2013-04-29 | 2 | -2044/+3 | |
| | | ||||||
* | | Bump version to rc1 | David Heinemeier Hansson | 2013-04-29 | 1 | -1/+1 | |
| | | ||||||
* | | Bump activerecord-deprecated_finders. Fixes #10304 | Rafael Mendonça França | 2013-04-29 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #10372 from ↵ | Jeremy Kemper | 2013-04-28 | 3 | -12/+13 | |
|\ \ | | | | | | | | | | | | | jeremy/statement-invalid-wraps-underlying-exception StatementInvalid takes WrappedDatabaseException's place | |||||
| * | | StatementInvalid takes WrappedDatabaseException's place | Jeremy Kemper | 2013-04-28 | 3 | -12/+13 | |
| | | | ||||||
* | | | Delegate #unscope query method | Carlos Antonio da Silva | 2013-04-28 | 2 | -1/+11 | |
|/ / | ||||||
* | | Merge pull request #10368 from demands/fix-typo | Guillermo Iguaran | 2013-04-28 | 1 | -1/+1 | |
|\ \ | | | | | | | Fix typo in serialized_attribute_test. [ci skip] | |||||
| * | | Fix typo in serialized_attribute_test. [ci skip] | Max Edmands | 2013-04-28 | 1 | -1/+1 | |
| | | | ||||||
* | | | fixes a test, and explains why AR::AttributeMethods checks ↵ | Xavier Noria | 2013-04-28 | 3 | -6/+8 | |
|/ / | | | | | | | defined?(@attributes) in some places | |||||
* | | adding test for the symbol refs | Aaron Patterson | 2013-04-26 | 1 | -0/+7 | |
| | | ||||||
* | | ActiveRecord -> Active Record | Xavier Noria | 2013-04-25 | 1 | -1/+1 | |
| | | ||||||
* | | fixes warning in the AR test suite | Xavier Noria | 2013-04-25 | 1 | -1/+1 | |
| | | ||||||
* | | Review DatabaseTasks docs [ci skip] | Carlos Antonio da Silva | 2013-04-24 | 1 | -17/+17 | |
| | | ||||||
* | | Merge pull request #10333 from ikataitsev/move-test-method-to-tests | Rafael Mendonça França | 2013-04-24 | 2 | -8/+9 | |
|\ \ | | | | | | | Move method used only in the test to the test code itself | |||||
| * | | Move method used only in the test to the test code itself | Ivan Kataitsev | 2013-04-25 | 2 | -8/+9 | |
| | | | ||||||
* | | | Minor AR changelog review [ci skip] | Carlos Antonio da Silva | 2013-04-24 | 1 | -6/+8 | |
|/ / | ||||||
* | | Merge branch 'active-record-standalone-improvements' | Piotr Sarnacki | 2013-04-24 | 4 | -24/+92 | |
|\ \ | ||||||
| * | | Use env == 'development' instead of env.development? | Piotr Sarnacki | 2013-04-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | It's simpler to assume that passed env is just a string without any extensions, especially when DatabaseTasks are intended to be used also without rails. | |||||
| * | | Move CHANGELOG entry for db.rake improvements to 4.0.0 | Piotr Sarnacki | 2013-04-24 | 1 | -3/+1 | |
| | | | ||||||
| * | | Don't require Rails.env in order to use AR::Tasks::DatabaseTasks | Piotr Sarnacki | 2013-04-24 | 2 | -6/+8 | |
| | | | ||||||
| * | | Add some documentation to ActiveRecord::Tasks::DatabaseTasks | Piotr Sarnacki | 2013-04-24 | 1 | -1/+29 | |
| | | | | | | | | | | | | | | | | | | This is a public class, which could be used directly in order to allow easier database management. Now it also contains settings, which will be used by databases.rake. | |||||
| * | | Use DatabaseTasks.fixtures_path instead of FIXTURES_PATH in db.rake | Piotr Sarnacki | 2013-04-24 | 3 | -3/+22 | |
| | | | | | | | | | | | | | | | | | | This will allow to set fixtures path in global config easier, it should be not needed to use FIXTURES_PATH every time user wants to load fixtures. | |||||
| * | | Don't require having Rails.application to run database tasks | Piotr Sarnacki | 2013-04-24 | 4 | -15/+36 | |
| | | | ||||||
* | | | Added testcase for #10067 and a CHANGELOG entry about this change. | kennyj | 2013-04-25 | 2 | -0/+21 | |
| | | | ||||||
* | | | Fix a SystemStackError that occurs when using time zone aware attributes. | Dan Erikson | 2013-04-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | This fixes issue #10066 | |||||
* | | | Remove code duplication | Neeraj Singh | 2013-04-24 | 1 | -8/+9 | |
| | | | ||||||
* | | | Lookup the class at runtime, not when the association is built | Andrew White | 2013-04-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Trying to lookup the parent class when the association is being built runs the risk of generating uninitialized constant errors because classes haven't been fully defined yet. To work around this we look up the class at runtime through the `association` method. Fixes #10197. | |||||
* | | | Removed unused associations | Andrew White | 2013-04-24 | 1 | -2/+0 | |
| | | | ||||||
* | | | Reset the primary key for other tests | Andrew White | 2013-04-24 | 1 | -0/+2 | |
| | | | ||||||
* | | | added test cases for #10197 | Adam Gamble | 2013-04-24 | 1 | -0/+56 | |
| | | | ||||||
* | | | Revert "Revert "`belongs_to :touch` behavior now touches old association ↵ | Andrew White | 2013-04-24 | 3 | -1/+78 | |
|/ / | | | | | | | | | | | | | | | | | when transitioning to new association" until a proper fix is found for #10197" This reverts commit 7389df139a35436f00876c96d20e81ba23c93f0a. Conflicts: activerecord/test/cases/timestamp_test.rb | |||||
* | | Remove test case also related to the belongs_to touch feature | David Heinemeier Hansson | 2013-04-23 | 1 | -20/+0 | |
| | | ||||||
* | | Revert "`belongs_to :touch` behavior now touches old association when ↵ | David Heinemeier Hansson | 2013-04-23 | 3 | -58/+1 | |
| | | | | | | | | transitioning to new association" until a proper fix is found for #10197 | |||||
* | | When empty options passed to having clause having_values was [nil] but ↵ | Fyodor | 2013-04-23 | 2 | -1/+8 | |
| | | | | | | | | should be empty. | |||||
* | | Merge pull request #10295 from senny/10237_dirty_with_nullable_datetime | Carlos Antonio da Silva | 2013-04-22 | 1 | -3/+5 | |
|\ \ | | | | | | | Also assign nil in dirty nullable_datetime test. Closes #10237 | |||||
| * | | also assign nil in dirty nullable_datetime test. #10237 | Yves Senn | 2013-04-22 | 1 | -3/+5 | |
| | | | ||||||
* | | | Update counter cache when pushing into association | Matthew Robertson | 2013-04-21 | 3 | -3/+22 | |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes a regression bug in which counter_cache columns were not being updated correctly when newly created records were being pushed into an assocation. EG: # this was fine @post.comment.create! # this was fine @comment = Comment.first @post.comments << @comment # this would not update counters @post.comments << Comment.create! | |||||
* | | Merge pull request #10280 from vipulnsward/fix_typos_temp | Steve Klabnik | 2013-04-21 | 2 | -2/+2 | |
|\ \ | | | | | | | fix typos [ci skip] | |||||
| * | | fix typos | Vipul A M | 2013-04-21 | 2 | -2/+2 | |
| | | | ||||||
* | | | if singletons belong to the contract, test them | Xavier Noria | 2013-04-20 | 2 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | Object#respond_to? returns singletons and thus we inherit that contract. The implementation of the predicate is good, but the test is only checking boolean semantics, which in this case is not enough. | |||||
* | | | Rewrites a CHANGELOG entry. | Xavier Noria | 2013-04-20 | 1 | -16/+6 | |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The entry is basically copy & paste of the commit message, but the CHANGELOG has a different purpose than Git history, it just communicates what is new: * No need to explain why did the bug happen (unless it is truly relevant). * No need to explain how was the bug fixed. * Whether the user gives new names to columns does not really matter, use of select to cherry-pick a column for example also presented that behaviour. Non-selected attributes are the key, either because they were not included in the selected list, or because they were but with a different alias. * In the case of an attribute alias, what you really want to depict is that respond_to? returns false for the original attribute name. | |||||
* | | Typo Fix in AR CHANGELOG [ci skip] | Prathamesh Sonpatki | 2013-04-20 | 1 | -2/+2 | |
| | | ||||||
* | | fix respond_to? for non selected column | Neeraj Singh | 2013-04-19 | 3 | -1/+41 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #4208 If a query selects only a few columns and gives custom names to those columns then respond_to? was returning true for the non selected columns. However calling those non selected columns raises exception. post = Post.select("'title' as post_title").first In the above case when `post.body` is invoked then an exception is raised since `body` attribute is not selected. Howevere `respond_to?` did not behave correctly. pos.respond_to?(:body) #=> true Reason was that Active Record calls `super` to pass the call to Active Model and all the columns are defined on Active Model. Fix is to actually check if the data returned from the db contains the data for column in question. |