Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | where_values_hash always returns a hash | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | performance improvement based on discussion at ↵ | Neeraj Singh | 2010-09-28 | 1 | -9/+3 | |
| | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion | |||||
* | Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master" | Aaron Patterson | 2010-09-28 | 1 | -6/+0 | |
| | | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af. | |||||
* | Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab. | |||||
* | removing a conditional that is not used | Aaron Patterson | 2010-09-28 | 1 | -2/+0 | |
| | ||||||
* | fisting the postgresql tests | Aaron Patterson | 2010-09-28 | 1 | -1/+2 | |
| | ||||||
* | Set attributes properly for model built from association with conditions ↵ | Marcelo Giorgi | 2010-09-28 | 8 | -10/+61 | |
| | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | each works well too | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | no need for splat and flatten | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | avoid calling to_sql when we can | Aaron Patterson | 2010-09-28 | 2 | -4/+4 | |
| | ||||||
* | removing an inject + merge in favor of Hash#[] | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | fixing indentation warning | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | Test add_index and remove_index with a symbol name #4891 | Étienne Barrié | 2010-09-28 | 2 | -4/+10 | |
| | ||||||
* | porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | | | | Giorgi | |||||
* | porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master | Aaron Patterson | 2010-09-28 | 1 | -0/+6 | |
| | ||||||
* | use new skool Ruby instead of Ruby Classic™ | Aaron Patterson | 2010-09-27 | 1 | -5/+3 | |
| | ||||||
* | be kind to the garbage collector: only instantiate objects when absolutely ↵ | Aaron Patterson | 2010-09-27 | 1 | -14/+17 | |
| | | | | necessary | |||||
* | adding test cases for the dynamic finder matcher match method | Aaron Patterson | 2010-09-27 | 1 | -0/+49 | |
| | ||||||
* | constructor should not do so much work; avoid allocating object if possible | Aaron Patterson | 2010-09-27 | 1 | -10/+5 | |
| | ||||||
* | @klass also uses DynamicFinderMatch, so no need for it on the relation | Aaron Patterson | 2010-09-27 | 2 | -9/+5 | |
| | ||||||
* | no need for a case / when statement | Aaron Patterson | 2010-09-27 | 1 | -11/+7 | |
| | ||||||
* | do not need intermediate variable, avoid lasgn | Aaron Patterson | 2010-09-27 | 1 | -2/+3 | |
| | ||||||
* | DRY up our regular expression | Aaron Patterson | 2010-09-27 | 1 | -3/+3 | |
| | ||||||
* | reduce method calls in the dynamic finder matcher | Aaron Patterson | 2010-09-27 | 1 | -4/+4 | |
| | ||||||
* | make sure we use the engine assigned to the table when quoting | Aaron Patterson | 2010-09-27 | 2 | -1/+19 | |
| | ||||||
* | Fix for #5579 involved the code change for both has_one and has_many ↵ | Neeraj Singh | 2010-09-27 | 1 | -1/+9 | |
| | | | | | | | | relationships. The path included test only for has_one. This patch adds test for has_many relationship. [#5706 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix for nested_attributes with has_many association fails when a single ↵ | Neeraj Singh | 2010-09-27 | 2 | -1/+14 | |
| | | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 1 | -3/+3 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | |||||
| * | Prevent shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -3/+3 | |
| | | ||||||
* | | adding a test for slug behavior | Aaron Patterson | 2010-09-27 | 1 | -0/+4 | |
| | | ||||||
* | | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 | |
| | | | | | | | | | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | |||||
* | | depending on arel 2.0.0 | Aaron Patterson | 2010-09-27 | 1 | -1/+1 | |
|/ | ||||||
* | third parameter is not used | Aaron Patterson | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | db:structure:dump should list current Rails.env adapter in errors, not ↵ | Nic Benders | 2010-09-26 | 1 | -1/+1 | |
| | | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Fix remove_index issue when provided :name is a symbol | Tim Connor | 2010-09-26 | 2 | -2/+2 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Add namespacing for observer generator | Piotr Sarnacki | 2010-09-25 | 1 | -0/+2 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Generators fix: properly check if module should be created when creating a ↵ | Piotr Sarnacki | 2010-09-25 | 1 | -1/+1 | |
| | | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵ | Marcelo Giorgi | 2010-09-24 | 2 | -1/+7 | |
| | | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved] | Brian Candler | 2010-09-24 | 1 | -1/+1 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Refactor namespaced generators to use module_namespacing block helper | Piotr Sarnacki | 2010-09-24 | 3 | -2/+6 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Generators are not aware of namespace of isolated engines and applications | Piotr Sarnacki | 2010-09-24 | 1 | -2/+2 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | restore behavior of touch for models without :updated_xx [#5439 state:resolved] | tnp | 2010-09-24 | 2 | -8/+15 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | reject_id option should be respected while using nested_attributes | Neeraj Singh | 2010-09-24 | 2 | -3/+12 | |
| | | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Hash#to_s behaves differently between 1.8 and 1.9, so adjust accordingly | Aaron Patterson | 2010-09-23 | 1 | -1/+1 | |
| | ||||||
* | switch present in favor of empty | Aaron Patterson | 2010-09-22 | 1 | -1/+1 | |
| | ||||||
* | testing poor behavior of hash serialization | Aaron Patterson | 2010-09-22 | 1 | -0/+4 | |
| | ||||||
* | Refactor association_collection uniq method. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | No need to use inject here. | Emilio Tagua | 2010-09-22 | 1 | -5/+5 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | No need to use inject here, use map instead. | Emilio Tagua | 2010-09-22 | 1 | -4/+1 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> |