aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Reversing the changes done in c278a2c while still resolving #1857.Vijay Dev2011-07-022-14/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before.
* | | | | a few minor performance improvements: fewer strings, fewer range objects, ↵Aaron Patterson2011-07-012-22/+13
| | | | | | | | | | | | | | | | | | | | fewer method calls
* | | | | calling super is super. if the other object is exactly equal, we can return ↵Aaron Patterson2011-07-011-1/+5
| | | | | | | | | | | | | | | | | | | | early
* | | | | remove unused codesAaron Patterson2011-07-011-4/+0
| | | | |
* | | | | reduce calls to owners_by_key and to read_attribute, respond_to? etcAaron Patterson2011-07-011-2/+3
| |_|_|/ |/| | |
* | | | Remove AssociationReflection#create_association and ↵Jon Leighton2011-06-301-17/+0
| | | | | | | | | | | | | | | | AssociationReflection#create_association! - they are not called from anywhere.
* | | | Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-308-12/+45
| | | | | | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842.
* | | | match method signature of the superclassAaron Patterson2011-06-302-4/+4
| | | |
* | | | call super rather than delegating to the other objects equal? methodAaron Patterson2011-06-301-1/+1
| | | |
* | | | just alias eql? to == for frewer method callsAaron Patterson2011-06-301-5/+1
| | | |
* | | | only calculate method name onceAaron Patterson2011-06-301-2/+3
| | | |
* | | | cache the plural name on the reflection so we do not pay pluralize costs on ↵Aaron Patterson2011-06-303-8/+15
| | | | | | | | | | | | | | | | joins
* | | | Master version is 3.2.0.betaSantiago Pastorino2011-06-301-2/+2
| | | |
* | | | Bump up rack-cache and tzinfoSantiago Pastorino2011-06-301-1/+1
| | | |
* | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵Jon Leighton2011-06-302-2/+11
| | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
* | | | Define to_ary on ActiveRecord::Base to return nil. Improve performance of ↵Jon Leighton2011-06-301-0/+12
| | | | | | | | | | | | | | | | Array#flatten under 1.9, see comment for details.
* | | | Merge pull request #1574 from ↵Aaron Patterson2011-06-282-1/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes
| * | | | Fix caseOriol Gual2011-06-281-2/+1
| | | | |
| * | | | Update reverse order with new Arel NodesOriol Gual2011-06-281-1/+2
| | | | |
| * | | | Add more test casesOriol Gual2011-06-281-0/+8
| | | | |
| * | | | Add failing testOriol Gual2011-06-281-0/+4
| | | | |
* | | | | Fix test_finding_with_cross_table_order_and_limit for OracleRaimonds Simanovskis2011-06-281-3/+3
|/ / / / | | | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.
* | | | Merge pull request #1857 from vijaydev/irreversible-migrationAaron Patterson2011-06-282-7/+9
|\ \ \ \ | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
| * | | | record unsupported methods in CommandRecorder instead of letting the ↵Vijay Dev2011-06-252-7/+9
| | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
* | | | | Merge pull request #1860 from dmathieu/comparisonAaron Patterson2011-06-282-0/+22
|\ \ \ \ \ | | | | | | | | | | | | Allow comparison on model objects - Closes #1858
| * | | | | comparing different classes returns nilDamien Mathieu2011-06-262-1/+11
| | | | | |
| * | | | | allow comparison on model objects - Closes #1858Damien Mathieu2011-06-262-0/+12
| |/ / / /
* | | | | remove useless assignmentAaron Patterson2011-06-281-2/+1
| | | | |
* | | | | lock_optimistically is typically true, so evaluate the common failure case firstAaron Patterson2011-06-281-1/+1
| | | | |
* | | | | reduce object allocation during AR instantiationAaron Patterson2011-06-282-3/+8
| | | | |
* | | | | remove the check for needs_type_condition? because ensure_proper_type will ↵Aaron Patterson2011-06-272-3/+4
| | | | | | | | | | | | | | | | | | | | pick up the type column
* | | | | stop using && for the short circuit side effectAaron Patterson2011-06-271-1/+1
| | | | |
* | | | | let strings be converted to symbols inside the interpreterAaron Patterson2011-06-271-2/+2
| | | | |
* | | | | avoice paying hash cost if there are no serialized attributesAaron Patterson2011-06-271-3/+4
| | | | |
* | | | | cache column defaults for AR object instantiationAaron Patterson2011-06-273-3/+16
| | | | |
* | | | | AR object instantiation is ~30% faster in the simple caseAaron Patterson2011-06-272-1/+17
| | | | |
* | | | | initialize instance variablesAaron Patterson2011-06-271-0/+2
| | | | |
* | | | | oops! remove debugging codesAaron Patterson2011-06-271-1/+0
| | | | |
* | | | | default create_with_value to a hash so we can eliminate conditionals, add ↵Aaron Patterson2011-06-275-5/+14
| | | | | | | | | | | | | | | | | | | | test surrounding create_with(nil) behavior
* | | | | Bump ARel to 2.1.3Guillermo Iguaran2011-06-271-1/+1
|/ / / /
* | | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_paramsSantiago Pastorino2011-06-242-1/+8
|\ \ \ \ | | | | | | | | | | Fix for complex ordering of multiple columns on postgresql
| * | | | Improve ordering of multiple columns on postgresqlLucia Escanellas2011-06-242-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720
* | | | | Apply the default scope earlier when doing calculations. Fixes #1682.Jon Leighton2011-06-233-5/+24
|/ / / /
* / / / Update SQL Server db related rake tasks.Ken Collins2011-06-231-6/+7
|/ / / | | | | | | | | | | | | | | | * Uses open source smoscript since scptxfr came out in 2000. * Uses sqlcmd which replaces osql. * Takes advantage of host/user/pass passed down by TinyTDS.
* | | Merge pull request #1790 from ernie/reverse_sql_order_fixAaron Patterson2011-06-222-3/+24
|\ \ \ | | | | | | | | Support reversal of ARel orderings in reverse_sql_order
| * | | Support reversal of ARel orderings in reverse_sql_orderErnie Miller2011-06-202-3/+24
| | | |
* | | | Merge pull request #1632 from tardate/pg_schema_fuAaron Patterson2011-06-214-50/+285
|\ \ \ \ | |/ / / |/| | | Improving PostgreSQL adapter schema-awareness
| * | | Merge remote branch 'rails/master' into pg_schema_fuPaul Gallagher2011-06-1918-112/+476
| |\ \ \
| * | | | Make PostgreSQL adapter view-compatiblePaul Gallagher2011-06-193-4/+54
| | | | | | | | | | | | | | | * amongst other things, allows meta_search to run against view-backed models
| * | | | make extract_schema_and_table a private methodPaul Gallagher2011-06-112-27/+24
| | | | |