| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I can never remember if it returns `self` or `true` (seems to be `true`)
[ci skip]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Simplify query in column_definitions() for Postgres
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
column_definitions() needs to fetch the collation for every column, if
present. Previously, it did so using a correlated subquery - a subquery
that references results from the outer scope.
This patch updates the query to remove the subquery in favor of a
simpler and more efficient JOIN clause.
Running the two queries through EXPLAIN against Postgres additionally
shows that the original form with a correlated subquery requires a
Nested Loop Left Join, while the new form with a simple JOIN can use a
more efficient Merge Left Join.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Report the attribute on ActiveRecord::SerializationTypeMismatch
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | | |
this probably fixes #25840
|
|/ / /
| | |
| | |
| | |
| | | |
This message could be generated by `assert_predicate`, https://github.com/rails/rails/commit/1853a4f2c8b2bddfbde6aae80abb08310295201c#commitcomment-20546113
but I'd rather handwrite the message string if I could reduce magic from the code by doing so.
|
|/ /
| |
| |
| |
| | |
Since `Migration` module is included in both `MigrationGenerator` and
`ModelGenerator`, no need to define a common method for each class.
|
| |
| |
| |
| |
| |
| | |
`initialize_internal_metadata_table`
These internal initialize methods are no longer used internally.
|
| |
| |
| |
| |
| | |
This reverts commit 39c77eb1843f79925c7195e8869afc7cb7323682, reversing
changes made to 9f6f51be78f8807e18fc6562c57af2fdbf8ccb56.
|
|\ \
| | |
| | | |
Tweak bigint PK handling
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Don't force PKs on tables that have explicitly opted out
* All integer-like PKs are autoincrement unless they have an explicit
default
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
These are followups for 307065f959f2b34bdad16487bae906eb3bfeaf28,
but TBH I'm personally not very much confortable with this style.
Maybe we could override assert_equal in our test_helper not to warn?
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`initialize_internal_metadata_table` internal public methods
These internal methods accidentally appeared in the doc, and so almost
useless. It is enough to create these internal tables directly, and
indeed do so in several places.
https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/schema.rb#L55
https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/railties/databases.rake#L6
https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/tasks/database_tasks.rb#L230
|
|\ \
| | |
| | | |
Generate migrations at path set by `config.paths["db/migrate"]`
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove meaningless line from adapter_test.rb
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
https://www.sqlite.org/foreignkeys.html
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
statement
If an adapter does not support foreign key feature, should be noop.
https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/foreign_key_test.rb#L288-L294
https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/references_foreign_key_test.rb#L208-L214
|
| | | |
|
|\ \ \
| | | |
| | | | |
Translate Foreign Key violation to the specific exception for SQLite3 adapter
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Raise `ActiveRecord::InvalidForeignKey` when a record cannot be inserted
or updated because it references a non-existent record for SQLite3
adapter.
|
|/ / |
|
|\ \
| | |
| | | |
Add test for update_counters with empty touch array
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a regression test for a fix included in
https://github.com/rails/rails/commit/bad9bfbea6d6af9dc28583e08a49492668087393.
Without that change, this test would fail with:
ActiveRecord::StatementInvalid: SQLite3::SQLException: near "WHERE": syntax error: UPDATE "topics" SET "replies_count" = COALESCE("replies_count", 0) - 1, WHERE "topics"."id" = ?
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`timestamp_attributes_for_updates_in_model` returns an empty
array when a model has no `updated_at` or `updated_on`.
So my previously thought uncommon case is a lot more likely
now.
This reverts commit a0a1ede8c2eb6436571eae8778033162d1f9dcc3.
|
|\ \ \
| | | |
| | | | |
Fix UUID primary key with default nil in legacy migration
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
UUID primary key with no default value feature (#10404, #18206) was lost
in legacy migration caused by #25395 got merged. Restore the feature
again in legacy migration.
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #27683.
Seeing a code sample that leads to what we're guarding against:
```ruby
Topic.update_counters(1, replies_count: 1, touch: [])
```
It doesn't look like a case people would ever intentionally end
up with. Thus we're better off sparing the conditional.
Note: it could happen if a method returns an empty array
that's then passed to `update_counters` and its touchy friends.
But `[].presence` can fix that once people see their query blow
up.
[ Eugene Kenny & Kasper Timm Hansen ]
|
|\ \ \
| | | |
| | | | |
Add the touch option to ActiveRecord#increment! and decrement!
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Supports the `touch` option from update_counters.
The default behavior is not to update timestamp columns.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`scope_for_create`
`type_condition` should be overwritten by `create_with_value`. So `type`
in `create_with_value` should be a string because `where_values_hash`
keys are converted to string.
Fixes #27600.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If a process is forked more than once, the pool was grabbing the oldest
spec, not the most recent spec. This wasn't noticed before because most
folks are lilely forking the process only once.
If you're forking the process multiple times however the wrong spec name
will be returned and an incorrect connection will be used for the
process.
This fixes the issue by reversing the list of spec names so we can grab
the most recent spec rather than the oldest spec.
|
| | |
| | |
| | |
| | | |
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
| | |
| | |
| | |
| | | |
(I personally prefer writing one string in one line no matter how long it is, though)
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
railties/lib/rails/generators.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Removes space from the word; is now spelled in the standard way.
[ci skip]
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
active_connections
clearing AR::Base's active_connections on the "primary" pool loses connections to the in_memory DB
when running sqlite3_mem tests
|
| | | |
| | | |
| | | |
| | | | |
so let's test with a tiny inner-class model instead
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since 79887593c18919fed49f441d64236362cb755872, create_all task recreates the connection to AR::Base
which doesn't connect to the in_memory database that is set up for tests
|
|\ \ \ \
| | | | |
| | | | | |
activerecord/test: Fix Mysql2ConnectionTest#test_execute_after_disconnect
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Mysql2ConnectionTest#test_execute_after_disconnect was originally added to
catch a NoMethodError occuring in execute when the Mysql2Adapter has a nil
`@connection`. Pull request #26869 removed the error message check in that
test because the error message changed in the mysql2 gem, which caused the
test to fail. Now the test wouldn't catch the original bug since the
NoMethodError would get turned into a ActiveRecord::StatementInvalid
exception.
Check the cause of the StatementInvalid exception to make sure it is of the
correct type.
|