aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* improve how ActiveRecord::Observer defines callbacks on observed modelsMislav Marohnić2010-04-162-7/+24
| | | | | | | | | | | | | | | | | | Instead of using a single `notify_observers` call for every callback type, each observer now registers a unique callback for itself. Example: before_save :_notify_user_observer_for_before_save def _notify_user_observer_for_before_save observer.update(:before_save, self) end Benefit: "before" callbacks halt when `observer.update` returns false. This way, ActiveRecord observers can prevent records from saving. [#4087 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* ActiveModel::Observing: stop using Observable Ruby module, re-implement ↵Mislav Marohnić2010-04-161-0/+20
| | | | | | | | | `notify_observers` `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord callback chains) and has extra features (like `changed`) that were never used. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* merge callbacks_observers_test.rb into lifecycle_test.rb where other ↵Mislav Marohnić2010-04-162-37/+34
| | | | | | | | observers test reside Benefits: test able to run independently, subclassing instead of changing the original Comment model Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* fix a failure and some warnings on 1.9.2 [#4417 state:resolved]Aaron Patterson2010-04-162-2/+2
| | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* Split the observer railtie into two phases.Michael Koziarski2010-04-161-3/+7
| | | | Observers observing models with scopes defined will require the connection to be established.
* i18n -> AS/i18nXavier Noria2010-04-141-1/+1
|
* adds missing requires for arel and i18n, prevents Arel constant from being ↵Xavier Noria2010-04-141-1/+3
| | | | autoloaded (which was still seen), though it probably hides an issue related to dependencies
* Merge commit 'docrails/master'Xavier Noria2010-04-141-1/+1
|\
| * fixed typo in RUNNING_UNIT_TESTSDiego Carrion2010-04-141-1/+1
| |
* | Ensure not to load the entire association when bulk updating existing ↵Pratik Naik2010-04-143-13/+33
| | | | | | | | records using nested attributes
* | removes unnecessary assignment and local variable in AR::Base#subclasses, ↵Xavier Noria2010-04-131-3/+2
| | | | | | | | and revises its rdoc
* | Update changelogs for releaseDavid Heinemeier Hansson2010-04-131-1/+1
| |
* | Refactor compute_type to handle situations where the correct class is ↵Andrew White2010-04-128-25/+88
| | | | | | | | | | | | already loaded Signed-off-by: wycats <wycats@gmail.com>
* | make ActiveRecord::Base.subclasses a public methodEmmanuel Oga2010-04-122-1/+9
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
* | table_name_prefix and table_name_suffix are class_attributes instead of ↵Phil Smith2010-04-122-11/+56
| | | | | | | | | | | | cattr_accessors. [#4230] Signed-off-by: José Valim <jose.valim@gmail.com>
* | Generate module file for namespaced models [#4230 state:resolved]Andrew White2010-04-122-0/+10
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | mode postgresql adapters table_exists? method take the schema in to account. ↵Aaron Patterson2010-04-112-1/+38
| | | | | | | | | | | | [#4341 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* | Fix evals missing contextJeremy Kemper2010-04-101-3/+3
| |
* | Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...)Jeremy Kemper2010-04-108-12/+24
| |
* | clearing up many warnings, removing unnecessary regular expresion ↵Aaron Patterson2010-04-104-26/+25
|/ | | | | | comparisons [#4365 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Made arrays of ActiveRecords, and any classes, with namespaces convert to ↵mfoster2010-04-101-1/+11
| | | | | | valid xml. [#3824 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* clear the rest of the warnings, run with warnings turned on [#4332 ↵Aaron Patterson2010-04-102-25/+40
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* kill warnings on 1.8.7 [#4331 state:resolved]Aaron Patterson2010-04-101-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Update versions (otherwise you install a gem from source as beta3 but ↵José Valim2010-04-101-1/+1
| | | | internally it's beta2) and update CHANGELOG.
* fix stack trace lines on class_evalSantiago Pastorino2010-04-093-9/+9
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* db:test:prepare for tasks only if AR is loadedSantiago Pastorino2010-04-091-0/+2
|
* Revert "When creating database with rake, create schemas in ↵Michael Koziarski2010-04-094-41/+1
| | | | | | | | | | | | | schema_search_path if it doesn't exist." This reverts commit 6c2a0675f11a9b5b8e88ed7dbccd65cb51be8029. Reverting because it breaks the ability to run tests using a non-superuser. Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb activerecord/lib/active_record/railties/databases.rake
* Dirty datetime attributes should be aware of time zone info [#3658 ↵Kristopher Murata2010-04-082-0/+101
| | | | | | state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Some doc updates reflecting the new query APIPratik Naik2010-04-082-37/+33
|
* Reset named scope cache whenever the @target is resetPratik Naik2010-04-072-2/+19
|
* remove_index now uses quote_table_name() [#4300 state:resolved]Simon Effenberg2010-04-061-1/+1
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Memoize association.named_scope callsPratik Naik2010-04-052-0/+12
|
* moves Object#singleton_class to Kernel#singleton_class to match Ruby also ↵Xavier Noria2010-04-053-3/+3
| | | | there, same for #class_eval to simplify, and adds coverage for class_eval
* Merge commit 'docrails/master'Xavier Noria2010-04-041-1/+1
|\
| * Merge branch 'master' of github.com:lifo/docrailsAndrew White2010-04-0418-178/+191
| |\
| * | Update various documentation examples to use new routing DSLAndrew White2010-04-041-1/+1
| | |
* | | Add tests to prevent regression of lazy evaluation of has_many ..., ↵Andrew White2010-04-041-0/+18
| |/ |/| | | | | | | | | | | | | :dependent => :___ [#2627 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Merge commit 'rails/master'Xavier Noria2010-04-0312-175/+163
|\ \
| * | Bring back +extra_conditions+. This effectively reverts ↵Carl Lerche2010-04-032-4/+5
| | | | | | | | | | | | 386b7bfd9d78a6d8c8bc7cc4a310df806ad0ba57
| * | Raise a StatementInvalid error when trying to build a condition with hash ↵Carl Lerche2010-04-031-1/+3
| | | | | | | | | | | | keys that do not correspond to columns.
| * | Sanitize association conditions using the correct classCarl Lerche2010-04-031-1/+1
| | |
| * | Make the query built by has_many ...., :dependent => :____ lazy since all ↵Carl Lerche2010-04-022-50/+32
| | | | | | | | | | | | the information is not really available yet.
| * | Remove an unused argumentCarl Lerche2010-04-021-2/+1
| | |
| * | Improve scope docsPratik Naik2010-04-031-30/+14
| | |
| * | Improve named scope lambdaPratik Naik2010-04-031-13/+4
| | |
| * | Remove unnecessary argument for creating scopesPratik Naik2010-04-031-4/+4
| | |
| * | Make Relation#inspect less noisyPratik Naik2010-04-021-0/+4
| | |
| * | Goodbye ActiveRecord::NamedScope::ScopePratik Naik2010-04-023-36/+29
| | |
| * | Make Relation#first and Relation#last behave like named scope'sPratik Naik2010-04-022-18/+18
| | |
| * | Scope#method_missing can safely rely on Relation#method_missingPratik Naik2010-04-021-10/+0
| | |