aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Should escape meta characters in regexpRyuta Kamizono2017-05-0710-26/+26
|
* Fix `warning: ambiguous first argument`Ryuta Kamizono2017-05-061-2/+2
| | | | | | | | | | | | | | | | ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator Using sqlite3 Run options: --seed 9495 ..................................... Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s. 37 runs, 52 assertions, 0 failures, 0 errors, 0 skips ```
* Merge pull request #28989 from matthewd/quoted_id-deprecationMatthew Draper2017-05-062-2/+22
|\ | | | | Clarify deprecation message for #quoted_id
| * Clarify deprecation message for #quoted_idMatthew Draper2017-05-052-2/+22
| | | | | | | | | | In this case, it's the method definition that's more at fault, rather than the current caller.
* | Remove unused `DelegationTest#call_method`Ryuta Kamizono2017-05-061-27/+7
| | | | | | | | `DelegationTest#call_method` is no longer used since 9d79334a.
* | Don't pass `arel.engine` to `Arel::SelectManager.new`Ryuta Kamizono2017-05-053-9/+6
| | | | | | | | | | | | The argument of `Arel::SelectManager.new` is `table`, not `engine`. https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
* | Remove useless `target_records_from_association`Ryuta Kamizono2017-05-041-11/+3
|/ | | | Since through association is always loaded by `preloader.preload`.
* Should test against `Relation#bound_attributes`Ryuta Kamizono2017-05-041-8/+12
| | | | Since legacy `Relation#bind_values` was removed in b06f64c.
* Merge pull request #28974 from kamipo/extract_bind_param_and_bind_attributeRafael França2017-05-0311-51/+38
|\ | | | | Extract `bind_param` and `bind_attribute` into `ActiveRecord::TestCase`
| * Extract `bind_param` and `bind_attribute` into `ActiveRecord::TestCase`Ryuta Kamizono2017-05-0411-51/+38
| | | | | | | | These are used in tests from anywhere.
* | Remove duplicated `test_merging_reorders_bind_params`Ryuta Kamizono2017-05-041-9/+0
|/ | | | | | The same test exists in `test/cases/relation/merging_test.rb`. https://github.com/rails/rails/blob/v5.1.0/activerecord/test/cases/relation/merging_test.rb#L94-L101
* Add type caster to `RuntimeReflection#alias_name`Jon Moss2017-05-025-3/+13
| | | | | Since we have been using this `Arel::Table` since 111ccc832bc977b15af12c14e7ca078dad2d4373, in order to properly handle queries, it's important that we properly type cast arguments.
* Merge pull request #28938 from kamipo/deprecate_supports_statement_cacheRafael França2017-05-016-22/+12
|\ | | | | Deprecate `supports_statement_cache?`
| * Deprecate `supports_statement_cache?`Ryuta Kamizono2017-05-016-22/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_statement_cache?` was introduced in 3.1.0.beta1 (104d0b2) for bind parameter substitution, but it is no longer used in 3.1.0.rc1 (73ff679). Originally it should respect `prepared_statements` rather than `supports_statement_cache?` (fd39847). One more thing, named `supports_statement_cache?` is pretty misreading. We have `StatementCache` and `StatementPool`. However, `supports_statement_cache?` doesn't mean `StatementCache`, but `StatementPool` unlike its name. https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/statement_cache.rb https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/connection_adapters/statement_pool.rb
* | Merge pull request #28930 from kamipo/use_flat_mapRafael França2017-05-011-1/+1
|\ \ | |/ |/| Use `flat_map` rather than `map(&:...).flatten`
| * Use `flat_map` rather than `map(&:...).flatten`Ryuta Kamizono2017-04-291-1/+1
| |
* | Cleanup CHANGELOGs [ci skip]Ryuta Kamizono2017-04-301-1/+1
|/ | | | | | * Remove trailing spaces. * Add backticks around method and command. * Fix indentation.
* Stop creating duplicate Struct instancesJon Moss2017-04-281-23/+15
| | | | | | Just use one `Event` class. Reduces duplication, makes the tests easier to read. It might seem like each tests needs a different kind of Struct, since we make a new one for each test case.
* Also raise error when VERSION is nilRafael Mendonça França2017-04-272-3/+4
| | | | Fix #28905
* Evaluate belongs_to :default option against the owner, not the associationGeorge Claghorn2017-04-272-1/+19
|
* Restore `fixtures :author_addresses`Ryuta Kamizono2017-04-2721-26/+26
| | | | | This change reverted in eac6f369 but it is needed for data integrity. See #25328.
* Merge pull request #28883 from yahonda/fix28797Rafael França2017-04-262-3/+8
|\ | | | | PostgreSQL 10 does not convert `CURRENT_DATE` into `('now'::text)::date`
| * PostgreSQL 10 allows `CURRENT_DATE` and `CURRENT_TIMESTAMP` as default functionsYasuo Honda2017-04-262-3/+8
| | | | | | | | | | | | | | | | | | | | | | Address #28797 In the previous versions of PostgreSQL, `CURRENT_DATE` converted to `('now'::text)::date` and `CURRENT_TIMESTAMP` converted to `now()`. Refer these discussions and commit at PostgreSQL : https://www.postgresql.org/message-id/flat/5878.1463098164%40sss.pgh.pa.us#5878.1463098164@sss.pgh.pa.us https://github.com/postgres/postgres/commit/0bb51aa96783e8a6c473c2b5e3725e23e95db834
* | Merge pull request #28881 from bogdanvlviv/verbose-migrationRafael França2017-04-262-2/+17
|\ \ | | | | | | Set consistent typecast ENV["VERBOSE"]
| * | Refactor DatabaseTasksMigrateTest#test_migrate_receives_correct_env_varsbogdanvlviv2017-04-261-1/+16
| | | | | | | | | | | | | | | Add cases to ensure that environment variables VERBOSE and VERSION have correct typecast.
| * | Refactor AR::Tasks::DatabaseTasks::migratebogdanvlviv2017-04-261-1/+1
| |/ | | | | | | | | Set consistent type cast ENV["VERBOSE"]: ENV["VERBOSE"] is true if it not equal "false"
* | Merge pull request #28885 from kamipo/remove_useless_test_caseRafael França2017-04-262-13/+0
|\ \ | | | | | | Remove useless test case
| * | Remove useless test caseRyuta Kamizono2017-04-262-13/+0
| |/ | | | | | | | | Cannot call private methods in `@klass` against `CollectionProxy` (inherites `Relation`) because using `public_send` in `method_missing`.
* | Merge pull request #28891 from sodabrew/patch-1Rafael França2017-04-261-2/+0
|\ \ | | | | | | Remove mysql2 database adapter default username root
| * | Remove mysql2 database adapter default username rootAaron Stone2017-04-261-2/+0
| | |
* | | Revert "Merge pull request #27636 from ↵Rafael Mendonça França2017-04-2624-182/+98
|/ / | | | | | | | | | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2" This reverts commit c1faca6333abe4b938b98fedc8d1f47b88209ecf, reversing changes made to 8c658a0ecc7f2b5fc015d424baf9edf6f3eb2b0b. See https://github.com/rails/rails/pull/27636#issuecomment-297534129
* / Lock connection before checking it inMatthew Draper2017-04-261-6/+8
|/
* Merge pull request #28828 from kamipo/fix_extending_modules_on_associationRafael França2017-04-253-10/+25
|\ | | | | Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
| * Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`Ryuta Kamizono2017-04-223-10/+25
| | | | | | | | | | | | | | | | | | | | `ClassSpecificRelation` has `method_missing` and the `method_missing` is called first. if an associated class has the missing method in a relation, never reach to the `method_missing` in the `CollectionProxy`. I extracted `DelegateExtending` and included it to the delegate class that including `ClassSpecificRelation` to fix the issue. Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
* | Merge pull request #28831 from kamipo/respond_to_missing_should_be_privateRafael França2017-04-255-26/+18
|\ \ | | | | | | `respond_to_missing?` should be private
| * | `respond_to_missing?` should be privateRyuta Kamizono2017-04-225-26/+18
| |/ | | | | | | | | | | | | Follow up of 03d3f036. Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036. But the visibility is still public. It should be private.
* | Fix MigratorTest#test_migrator_verbositybogdanvlviv2017-04-261-1/+1
| | | | | | | | | | | | | | Add `ActiveRecord::Migration.verbose = true` to be sure that verbose is turned on in the test. Related to #28865
* | Merge pull request #28853 from kamipo/replace_regexp_zRafael França2017-04-253-14/+14
|\ \ | | | | | | Replace \Z to \z
| * | Replace \Z to \zRyuta Kamizono2017-04-243-14/+14
| |/ | | | | | | \Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
* | Merge pull request #28872 from eugeneius/enumerator_sizeRafael França2017-04-252-18/+12
|\ \ | | | | | | Remove checks for Enumerator#size method
| * | Remove checks for Enumerator#size methodEugene Kenny2017-04-252-18/+12
| |/ | | | | | | | | | | | | | | The Enumerator#size method was introduced in Ruby 2.0. These tests were added when Rails 4.1 was current, and Ruby 1.9.3 was still supported. Since Rails 5 only Ruby >= 2.2.2 is supported, so the checks are no longer necessary.
* / Fix typos [ci skip]Tobias Fankhänel2017-04-251-2/+2
|/ | | | | | | | | 'lookup' is the noun. 'to look up' is the verb. Looked it up just to be sure. cf. https://en.wiktionary.org/wiki/lookup https://en.wiktionary.org/wiki/look_up
* Don't attempt to create a new record that was already created.Isaac Betesh2017-04-203-0/+32
| | | | Fixes #24032
* Prevent double firing the before save callback of new object when the parent ↵Ryuta Kamizono2017-04-215-54/+70
| | | | | | | | | | | | | | | | | | association saved in the callback Related #18155, #26661, 268a5bb, #27434, #27442, and #28599. Originally #18155 was introduced for preventing double insertion caused by the after save callback. But it was caused the before save issue (#26661). 268a5bb fixed #26661, but it was caused the performance regression (#27434). #27442 added new record to `target` before calling callbacks for fixing #27434. But it was caused double firing before save callback (#28599). We cannot add new object to `target` before saving the object. This is improving #18155 to only track callbacks after `save`. Fixes #28599.
* Merge pull request #28681 from runephilosof/fix-mysql-grantRafael Mendonça França2017-04-203-2/+6
|\ | | | | | | Fix quoting in db:create grant all statement.
| * Fix quoting in db:create grant all statement.Rune Schjellerup Philosof2017-04-203-2/+6
| | | | | | | | | | | | The database name used in the test would have actually shown this if it had tried to execute on a real Mysql instead of being stubbed out (dashes in database names needs quotes).
* | Merge pull request #28733 from kamipo/dont_fallback_to_utf8mb3_after_mysql_8.0.0Rafael França2017-04-193-10/+12
|\ \ | | | | | | Don't fallback to utf8mb3 after MySQL 8.0.0
| * | Don't fallback to utf8mb3 after MySQL 8.0.0Ryuta Kamizono2017-04-173-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `internal_string_options_for_primary_key` is used for creating internal tables in newly apps. But it is no longer needed after MySQL 8.0.0. MySQL 5.7 has introduced `innodb_default_row_format` (default `DYNAMIC`) and has deprecated `innodb_large_prefix` and `innodb_file_format`. The purpose of the deprecated options was for compatibility with earlier versions of InnoDB. https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_large_prefix > innodb_large_prefix is deprecated and will be removed in a future release. innodb_large_prefix was introduced in MySQL 5.5 to disable large index key prefixes for compatibility with earlier versions of InnoDB that do not support large index key prefixes. https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_file_format > The innodb_file_format option is deprecated and will be removed in a future release. The purpose of the innodb_file_format option was to allow users to downgrade to the built-in version of InnoDB in MySQL 5.1. Now that MySQL 5.1 has reached the end of its product lifecycle, downgrade support provided by this option is no longer necessary. The deprecated options has removed in MySQL 8.0.0. It is no longer needed to take care newly created internal tables as a legacy format after MySQL 8.0.0. Fixes #28730.
* | | Merge pull request #28776 from kamipo/respect_limit_for_cache_keyRafael França2017-04-192-8/+44
|\ \ \ | | | | | | | | `cache_key` respects the limit in a relation even if a relation is not loaded
| * | | `cache_key` respects the limit in a relation even if a relation is not loadedRyuta Kamizono2017-04-172-8/+44
| |/ / | | | | | | | | | | | | | | | `cache_key` includes the size of a relation. But if a relation is not loadded, the size is not respected even if a relation has a limit. It should be respected for consistency.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 12:59:26 +0000