aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | raise `ArgumentError` exception if `Model.where.not` is called with `nil` ↵Kuldeep Aggarwal2013-12-302-0/+8
|/ / | | | | | | argument
* | setting `changed_attributes` instance variable if it is already initialized.Kuldeep Aggarwal2013-12-281-1/+1
| |
* | Merge pull request #13474 from jdelStrother/becomesYves Senn2013-12-272-0/+15
|\ \ | | | | | | Copy changed_attributes across to newly become'd records
| * | Copy changed_attributes across to newly become'd recordsJonathan del Strother2013-12-272-0/+15
| | | | | | | | | Without this, the original record's values won't get saved, since the partial insertions support (https://github.com/rails/rails/commit/144e8691cbfb8bba77f18cfe68d5e7fd48887f5e) checks for changed values and thinks there are none.
* | | Fix failure introduced from #13488schneems2013-12-251-1/+1
| | |
* | | Cast env to symbol, fixes deprecation warningŁukasz Strzałkowski2013-12-251-1/+1
| | | | | | | | | | | | | | | | | | Warning: DEPRECATION WARNING: Passing a string to ActiveRecord::Base.establish_connection for a configuration lookup is deprecated, please pass a symbol (:development) instead.
* | | Avoid getting redefined method warningŁukasz Strzałkowski2013-12-251-0/+1
| | | | | | | | | | | | | | | | | | | | | Warning: ~/projects/rails/activerecord/lib/active_record/railtie.rb:140: warning: method redefined; discarding old extend_message ~/projects/rails/activerecord/lib/active_record/errors.rb:104: warning: previous definition of extend_message was here
* | | Merge pull request #13478 from schneems/schneems/fix-mysqlGuillermo Iguaran2013-12-252-7/+7
|\ \ \ | | | | | | | | Move mysql2 test for when adapter will be loaded
| * | | Move mysql2 test for when adapter will be loadedschneems2013-12-242-7/+7
| |/ / | | | | | | | | | | | | | | | When run with only the Mysql adapter, we get this failure: https://travis-ci.org/rails/rails/jobs/15937907#L2416 Porting the test over to only run when mysql2 is loaded
* | | Merge pull request #13482 from aayushkhandelwal11/typoArun Agrawal2013-12-251-1/+1
|\ \ \ | | | | | | | | Typo rectified commom => common[ci skip]
| * | | Typo rectified commom => common[ci skip]Aayush khandelwal2013-12-251-1/+1
| | | |
* | | | using symbol instead of string in establish_connectionKuldeep Aggarwal2013-12-251-1/+1
| |/ / |/| |
* | | Raise NoDatabaseError when db does not existschneems2013-12-246-2/+41
| | | | | | | | | Building on the work of #13427 this PR adds a helpful error message to the adapters: mysql, mysql2, and sqlite3
* | | Deprecate use of string in establish_connection as connection lookupJosé Valim2013-12-247-15/+33
| | |
* | | Only build a ConnectionSpecification if requiredJosé Valim2013-12-244-56/+56
| | |
* | | Fix build failures related to the new ENV options in ymlJosé Valim2013-12-242-4/+4
| | |
* | | Merge pull request #13463 from josevalim/jv-envJosé Valim2013-12-236-53/+58
|\ \ \ | | | | | | | | Do not store production information in .yml files
| * | | Guarantee the connection resolver handles string valuesJosé Valim2013-12-236-53/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit also cleans up the rake tasks that were checking for DATABASE_URL in different places. In fact, it would be nice to deprecate DATABASE_URL usage in the long term, considering the direction we are moving of allowing those in .yml files.
* | | | Tidy up fix for PG extensions quotingCarlos Antonio da Silva2013-12-235-12/+26
| | | | | | | | | | | | | | | | | | | | Always pass in the column for quote_bound_value and quote using it in case it exists there.
* | | | Serialize postgres' hstore, json and array types correctly in AR update methods.Tadas Tamosauskas2013-12-235-4/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #12261. Closes #12395. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/adapters/postgresql/array_test.rb activerecord/test/cases/adapters/postgresql/json_test.rb
* | | | Do not consider PG array columns as number or text columnsCarlos Antonio da Silva2013-12-233-3/+33
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code uses these checks in several places to know what to do with a particular column, for instance AR attribute query methods has a branch like this: if column.number? !value.zero? end This should never be true for array columns, since it would be the same as running [].zero?, which results in a NoMethodError exception. Fixing this by ensuring that array columns in PostgreSQL never return true for number?/text? checks. Since most of the array support was based on the postgres_ext lib, it's worth noting it does the same thing for numeric array columns too: https://github.com/dockyard/postgres_ext/blob/v1.0.0/lib/postgres_ext/active_record/connection_adapters/postgres_adapter.rb#L72 This extended the same logic for text columns to ensure consistency.
* | | Tell how to Create a Database in Error Messageschneems2013-12-235-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if you attempt to use a database that does not exist you get an error: ``` PG::ConnectionBad FATAL: database "db_error" does not exist ``` The solution is easy, create and migrate your database however new developers may not know these commands by memory. Instead of requiring the developer to search for a solution, tell them how to fix the problem in the error message: ``` ActiveRecord::NoDatabase: FATAL: database "db_error" does not exist Run `$ bin/rake db:create db:migrate` to create your database ``` Active Record should not know about `rake db:migrate` so this additional information needs to come from the railtie. Potential alternative implementation suggestions are welcome.
* | | Fix comment example in AR enum [ci skip]Carlos Antonio da Silva2013-12-231-1/+1
| | |
* | | On destroying do not touch destroyed belongs to association.Paul Nikitochkin2013-12-233-1/+22
| | | | | | | | | | | | Fixes: #13445
* | | Merge pull request #13446 from kuldeepaggarwal/resolver-test-casesYves Senn2013-12-231-0/+10
|\ \ \ | | | | | | | | Resolver test cases
| * | | added test cases for Resolver#connection_url_to_hashKuldeep Aggarwal2013-12-231-0/+10
| | | |
* | | | CHANGELOG entry for #13451. [ci skip]Yves Senn2013-12-221-0/+13
| | | |
* | | | fix quoting non-stringsDamien Mathieu2013-12-222-1/+7
| | | | | | | | | | | | | | | | Closes #13444
* | | | Use the same enum definition in the docs and in the comments [ci skip]Godfrey Chan2013-12-221-6/+6
|/ / /
* | | fix url connections for sqlite3Aaron Patterson2013-12-202-1/+34
| | |
* | | Merge pull request #13417 from TalkativeTree/comments_changeRichard Schneeman2013-12-191-1/+1
|\ \ \ | | | | | | | | fix CollectionAssociation's comments
| * | | change CollectionAssociation's comments to say Association instead of ↵Ben Angel2013-12-191-1/+1
| | | | | | | | | | | | | | | | AssociationProxy to match changes for 3.1 removing Association proxy.
* | | | Merge pull request #13412 from arthurnn/quote_id_not_idRafael Mendonça França2013-12-192-1/+10
|\ \ \ \ | | | | | | | | | | quoting: Check if id is a valid method before using it
| * | | | quoting: Check if id is a valid method before using itArthur Neves2013-12-192-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | Need to check if valud also respond_to :id before calling it, otherwise things could explode.
* | | | | Improve CHANGELOG entry [ci skip]Rafael Mendonça França2013-12-191-8/+6
| | | | |
* | | | | fix default select when from is usedCody Cutrer2013-12-193-1/+26
|/ / / /
* | | | Fix indent in PG array testsCarlos Antonio da Silva2013-12-191-5/+5
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-203-3/+3
|\ \ \ \
| * | | | Typos. return -> returns. [ci skip]Lauro Caetano2013-12-033-3/+3
| | | | |
* | | | | Merge pull request #13395 from kuldeepaggarwal/postgres-table-ref-regexCarlos Antonio da Silva2013-12-193-1/+28
|\ \ \ \ \ | | | | | | | | | | | | modified regex for finding table_name from a multiline sql query in postgresql
| * | | | | Fix PostgreSQL insert to properly extract table name from multiline string SQL.Kuldeep Aggarwal2013-12-193-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, executing an insert SQL in PostgreSQL with a command like this: insert into articles( number) values( 5152 ) would not work because the adapter was unable to extract the correct articles table name.
* | | | | | Prefer assert_raise instead of flunk + rescue to test for exceptionsCarlos Antonio da Silva2013-12-192-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages.
* | | | | | Merge pull request #13393 from matthewd/fix_pg_range_testsCarlos Antonio da Silva2013-12-191-11/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix PostgreSQL range tests on fresh DB Correcting the name of the table we're creating is self-explanatory. But we must also move away from the low IDs, because we're not touching the freshly-created primary key sequence; when the time comes, @new_range will be assigned an ID of 1.
| * | | | | | Fix PostgreSQL range testsMatthew Draper2013-12-191-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes in c4044b2 meant the tests would error on a fresh DB.
* | | | | | | Merge pull request #13400 from nishant-cyro/docsGuillermo Iguaran2013-12-181-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | fix typos and grammar mistake [ci skip]
| * | | | | | | fix typos and grammar mistake [ci skip]nishant-cyro2013-12-191-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #13398 from kuldeepaggarwal/build-fixesGuillermo Iguaran2013-12-181-0/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | set encoding UTF-8 for accepting multibyte character
| * | | | | | | | set encoding UTF-8 for accepting multibyte characterKuldeep Aggarwal2013-12-191-0/+2
| | | | | | | | |
* | | | | | | | | Fix typo: data --> dateAlex Ghiculescu2013-12-191-1/+1
|/ / / / / / / /
* | | | | | | | Merge pull request #13366 from vipulnsward/minitest-namespace-changeGodfrey Chan2013-12-181-1/+1
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | Change all `MiniTest` to `Minitest`
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 04:14:42 +0000