aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #9207 from dylanahsmith/mysql-quote-numericGuillermo Iguaran2013-02-078-14/+60
|\ | | | | active_record: Quote numeric values compared to string columns.
| * active_record: Quote numeric values compared to string columns.Dylan Smith2013-02-078-14/+60
| |
* | Skip schema dumper extensions test if connection does not support itCarlos Antonio da Silva2013-02-071-0/+1
|/ | | | | Travis failed because the postgresql version installed there does not support extensions, so we just need to skip this for now.
* Run schema dumper extensions without creating real extensionsCarlos Antonio da Silva2013-02-061-9/+2
| | | | | There is no need to create the extension in the database just to test if it's dumped, we can stub that instead.
* Do not print anything related to extensions when they don't none existCarlos Antonio da Silva2013-02-062-4/+16
| | | | | When extensions are supported but there's no one enabled in the database, we should not print anything related to them in schema.rb.
* Add blank line after extensions to separate from tables in schemaCarlos Antonio da Silva2013-02-061-0/+1
|
* Fix indentation of extensions in schemaCarlos Antonio da Silva2013-02-061-4/+2
|
* Call super to use the abstract adapter implementation insteadCarlos Antonio da Silva2013-02-061-1/+1
|
* Add changelog entry for #9203 about schema dumper with db extensionsCarlos Antonio da Silva2013-02-062-2/+7
| | | | [ci skip]
* add ActiveRecord::AbstractAdapter#extensions and ↵Justin George2013-02-063-0/+27
| | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb
* improve tests to check for existence of extensions method, and skip testing ↵Justin George2013-02-062-8/+8
| | | | dumped extensions if they are unsupported by the database
* Add some tests to enumerate how extensions should be stored in the schema outputJustin George2013-02-062-0/+15
|
* Enable hstore extensions on tests if it is not enabled and database supports itRafael Mendonça França2013-02-051-1/+8
|
* Put .rdoc at the end of the files named RUNNING_UNIT_TESTSYuki Nishijima2013-02-031-0/+0
| | | | So that they are printed nicely on GitHub.
* Fix typo :bomb:Rafael Mendonça França2013-01-311-1/+1
|
* Fix typoRafael Mendonça França2013-01-311-2/+2
|
* CHANGELOG reviewRafael Mendonça França2013-01-311-3/+3
|
* Strict regexpRafael Mendonça França2013-01-311-2/+2
|
* Extract the value casting to a methodRafael Mendonça França2013-01-311-15/+23
|
* DATABASE_URL parsing should turn numeric strings into numeric types, andAaron Stone2013-01-313-11/+68
| | | | | | the strings true and false into boolean types, in order to match how YAML would parse the same values from database.yml and prevent unexpected type errors in the database adapters.
* Merge pull request #9119 from dazuma/database_tasks_for_unknown_adapterCarlos Antonio da Silva2013-01-312-0/+10
|\ | | | | Raise an exception with a useful message if a rake task is requested for an unknown adapter
| * Raise a specific exception with a useful message if a rake task is requested ↵Daniel Azuma2013-01-302-0/+10
| | | | | | | | for an unknown adapter
* | class_eval should use __FILE__ and __LINE__Neeraj Singh2013-01-301-1/+1
| |
* | Remove pre-emptive adapter name check from databases.rake so third party ↵Daniel Azuma2013-01-291-9/+3
|/ | | | adapters can register rake tasks
* reloading type map on extension changingAaron Patterson2013-01-292-2/+15
|
* fixing commentAaron Patterson2013-01-291-1/+1
|
* Fix typoRafael Mendonça França2013-01-291-1/+1
|
* Only search for enabled extension if the PostgreSQL version supportsRafael Mendonça França2013-01-291-3/+5
| | | | extensions
* Refactor to use each_key, remove extra spacesCarlos Antonio da Silva2013-01-287-11/+5
|
* add API to pg for enabling / disabling hstoreAaron Patterson2013-01-283-7/+54
|
* updates a dynamic method heredoc docXavier Noria2013-01-281-2/+2
|
* explains why the query cache checks arel.lockedXavier Noria2013-01-281-0/+2
|
* Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-282-2/+2
|
* Prevent Relation#merge from collapsing wheres on the RHSJon Leighton2013-01-279-22/+79
| | | | | | | | | | | | | | | | | | | | | | | This caused a bug with the new associations implementation, because now association conditions are represented as Arel nodes internally right up to when the whole thing gets turned to SQL. In Rails 3.2, association conditions get turned to raw SQL early on, which prevents Relation#merge from interfering. The current implementation was buggy when a default_scope existed on the target model, since we would basically end up doing: default_scope.merge(association_scope) If default_scope contained a where(foo: 'a') and association_scope contained a where(foo: 'b').where(foo: 'c') then the merger would see that the same column is representated on both sides of the merge and collapse the wheres to all but the last: where(foo: 'c') Now, the RHS of the merge is left alone. Fixes #8990
* Fix typo: adaptors => adapters [ci skip]Carlos Antonio da Silva2013-01-271-1/+1
|
* Fix cases where delete_records on a has_many association caused errorsDerek Kraan2013-01-277-5/+49
| | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql.
* Use `silence` instead of `quietly` to silence the `CheckPending` middleware.Lucas Mazza2013-01-261-1/+1
| | | | | | | | `Kernel.quietly` silences `STDOUT` and `STDERR`, which is useless if the logger is writing to a file, while `AS::Logger#silence` swaps the logger level to `ERROR`. Related to #8820 and #8052.
* Simplify type casting code for timezone aware attributesAndrew White2013-01-261-10/+5
| | | | | | With the addition of String#in_time_zone and Date#in_time_zone we can simplify the type casting code by checking if the value has an `in_time_zone` method.
* Fix handling of dirty time zone aware attributesLilibeth De La Cruz2013-01-263-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end
* Merge remote-tracking branch 'docrails/master'Xavier Noria2013-01-263-5/+5
|\ | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
| * Fix typoTatsuro Baba2013-01-221-1/+1
| |
| * Remove useless number signTatsuro Baba2013-01-181-2/+2
| | | | | | | | I think that these signs are probably mistake.
| * fix example of setting DEFAULTS in fixturesJonathan Garvin2013-01-161-2/+2
| |
* | `#count` in conjunction with `#uniq` performs distinct count.Yves Senn2013-01-263-1/+15
| | | | | | | | closes #6865
* | Remove obsolete test fileJon Leighton2013-01-251-35/+0
| | | | | | | | https://github.com/rails/rails/commit/4beb4dececcf10c642c74fbcb8548c833e921a86#commitcomment-2482869
* | reduce the number of queries on IN clauses, fix relation queries in `where`Aaron Patterson2013-01-243-2/+20
| |
* | stop converting strings to symbolsAaron Patterson2013-01-241-1/+1
| |
* | Default dead_connection_timeout to 5Akira Matsuda2013-01-241-1/+1
| | | | | | | | or the ConnectionPool silently fails to close connections inside the Thread
* | Describing the reason for defining BlankTopic#blank? which will never be calledAkira Matsuda2013-01-241-0/+1
| |
* | Revert "Unused methods, module, etc."Akira Matsuda2013-01-244-0/+28
| | | | | | | | | | | | This reverts commit 4e05bfb8e254c3360a3ca4a6cb332995314338fe. Reason: BlankTopic#blank? should not be removed to check that dynamic finder with a bang can find a model that responds to `blank?`
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-07 11:00:03 +0000