aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Avoid an attempt to fetch old record when id was not present in touch callbackCarlos Antonio da Silva2013-04-041-7/+7
|
* Use the correct pk field from the reflected class to find the old recordCarlos Antonio da Silva2013-04-041-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | The implementation was using the source class foreign key field instead of the reflected primary key one to find the old record. For instance, for this scenario class Bulb < ActiveRecord::Base belongs_to :car, :touch => true end class Car < ActiveRecord::Base has_many :bulbs end the current implementation was trying to do this query: Car.where(car_id: X).first where we should be doing this query: Car.where(id: X).first This should hopefully fix the build.
* Use inspect when writing the foreign key from the reflectionAndrew White2013-04-052-2/+8
| | | | | | If we don't use inspect inside the class_eval block then the foreign key is written without quotes causing us to fetch the foreign key value and not the column name.
* Use a space after the comment sign when showing the result of commandsCarlos Antonio da Silva2013-04-041-4/+4
| | | | | | http://guides.rubyonrails.org/api_documentation_guidelines.html#example-code [ci skip]
* Merge pull request #10094 from neerajdotname/fix2Carlos Antonio da Silva2013-04-042-3/+21
|\ | | | | Collection of small fixes. Check individual commits for background.
| * use | to have more intent revealing codeNeeraj Singh2013-04-041-1/+1
| | | | | | | | thanks to @egilburg for suggestion
| * expanded rdoc for chain and reflection_namesNeeraj Singh2013-04-041-2/+20
| |
* | stop depending on callbacksAaron Patterson2013-04-041-6/+12
|/
* Merge pull request #10087 from neerajdotname/10016Carlos Antonio da Silva2013-04-047-3/+26
|\ | | | | has_many through obeys order on through association
| * has_many through obeys order on through associationNeeraj Singh2013-04-047-3/+26
| | | | | | | | fixes #10016
* | Merge pull request #10088 from neerajdotname/fixes1Rafael Mendonça França2013-04-043-5/+15
|\ \ | |/ |/| minor fixes including variable name change and expanded rdoc
| * expanded rdoc on source_reflection methodNeeraj Singh2013-04-041-0/+10
| |
| * show name of the klass that has missing associationNeeraj Singh2013-04-021-1/+1
| |
| * not a relation. it's an arel select managerNeeraj Singh2013-04-021-4/+4
| |
* | Remove duplicated require from AR base testCarlos Antonio da Silva2013-04-031-1/+0
| |
* | Add missing require to inheritance testCarlos Antonio da Silva2013-04-032-3/+1
| |
* | Move changelog entry to the top and fix conflict [ci skip]Carlos Antonio da Silva2013-04-031-22/+20
| |
* | Merge pull request #9141 from adamgamble/issue-9091David Heinemeier Hansson2013-04-034-0/+62
|\ \ | | | | | | belongs_to :touch should touch old record when transitioning.
| * | Modifies belong_to touch callback to touch old associations also #9091Adam Gamble2013-03-143-10/+34
| | |
| * | + Add test for auto timestamps update of both old & new parent recordsPikachuEXE2013-03-142-0/+38
| | |
* | | Merge pull request #10049 from vipulnsward/optimize_around_merge_v1Rafael Mendonça França2013-04-031-1/+1
|\ \ \ | | | | | | | | optimize some code around merge
| * | | optimize some code around mergeVipul A M2013-04-031-1/+1
| | | |
* | | | Move alias method near to the aliased one in collection proxyCarlos Antonio da Silva2013-04-031-2/+1
| | | |
* | | | Merge pull request #10063 from SamSaffron/masterSantiago Pastorino2013-04-022-15/+29
|\ \ \ \ | | | | | | | | | | Per #9999 revert blank? to empty?
| * | | | Per #9999 revert the revert changing so columns are only tested for empty? ↵Sam2013-04-032-15/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as opposed to blank? This is both faster and more correct, added tests to make sure this is not reverted again.
* | | | | true/false => truthy falsySteve Klabnik2013-04-021-2/+2
|/ / / /
* | | / Prefer find_by over dynamic finders in rdocSam Ruby2013-04-025-11/+11
| |_|/ |/| |
* | | Merge pull request #9975 from ↵Aaron Patterson2013-04-022-14/+20
|\ \ \ | | | | | | | | | | | | | | | | mmangino/raise_when_attributes_cant_be_unserialized Unserializing YAML attributes can silently fail in development mode
| * | | Remove all error masking when decoding serialized data fails?Mike Mangino2013-04-022-15/+12
| | | |
| * | | Raise an exception when unserialization fails due to a missing classMike Mangino2013-03-282-1/+10
| | | |
* | | | Add CHANGELOG entry about extracting and deprecating ↵kennyj2013-04-031-0/+5
| | | | | | | | | | | | | | | | Firebird/Sqlserver/Oracle database tasks.
* | | | Show deprecated messages only when target database adapters definedYasuo Honda2013-04-033-3/+3
| | | |
* | | | Fix tiny problem: change method order for consistency and fix wrong method name.kennyj2013-04-032-2/+2
| | | |
* | | | Suppress deprecation messages for deprecated database tasks, when executing ↵kennyj2013-04-033-0/+21
| | | | | | | | | | | | | | | | rails's testcases.
* | | | Add deprecation message on Firebird / Sqlserver / Oracle database tasks.kennyj2013-04-033-0/+3
| | | |
* | | | Extract Oracle database tasks.kennyj2013-04-035-31/+140
| | | |
* | | | Extract Sqlserver database tasks.kennyj2013-04-035-11/+131
| | | |
* | | | Extract Firebird database tasks.kennyj2013-04-035-20/+151
| | | |
* | | | no need to invoke to_s before applying internNeeraj Singh2013-04-021-1/+1
| | | |
* | | | Merge pull request #10048 from ↵Rafael Mendonça França2013-04-021-17/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | senny/replace_merge_with_relation_calls_in_count_api replace #merge with relation API calls in calculations_test.
| * | | | replace #merge with relation API calls in calculations_test.Yves Senn2013-04-021-17/+13
| | | | |
* | | | | Fix #new with an STI object with complex inheritanceNate Berkopec2013-04-022-1/+5
|/ / / /
* | | | Updated the error message for +find+ on an inverse_of associationwangjohn2013-04-012-3/+1
| | | | | | | | | | | | | | | | | | | | so that it is consistent with the error thrown for +find+ without an inverse_of association.
* | | | Throwing a RecordNotFound exception when a record is scanned using thewangjohn2013-04-013-12/+55
| | | | | | | | | | | | | | | | | | | | inverse_of option. I've also refactored the code for raising a RecordNotFound exception when searching for records with ids.
* | | | :uniq is still a valid relation option since it was only silentlyRafael Mendonça França2013-04-011-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | deprecated Fixes activerecord-deprecated_finders build. https://travis-ci.org/rails/activerecord-deprecated_finders/builds/5964703
* | | Merge pull request #10010 from pwnall/fix_ref_index_trueRafael Mendonça França2013-04-011-1/+1
|\ \ \ | | | | | | | | Make references with index:true pass Hash options to add_index
| * | | Make references with index:true pass Hash options to add_index.Victor Costan2013-04-011-1/+1
| | | |
* | | | fix detect column type of enummasarakki2013-04-015-6/+6
|/ / / | | | | | | | | | enum includes text or blob or ... hooked by wrong regex
* | | Fix indent and change "or" usage to "||" in schema dumper testsCarlos Antonio da Silva2013-03-301-5/+5
| | |
* | | Refactor index algorithm lookup so that it only builds the available options ↵Carlos Antonio da Silva2013-03-301-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | once This way the available options are only built for actually fetching the algorithm in case the option is given. The options are going to be necessary a second time only in case the option is given but does not exist, which is supposed to be due to a typo or something like that, so no problem.
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-09 02:26:51 +0000