| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
[ci skip] fix typo
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When running passing condition assertions in the same test the user had already
been saved at that point.
Split out so we have a not yet persisted user.
Rename condition tests to improve clarity a bit.
|
| |
| |
| |
| |
| |
| |
| | |
Mistakenly interpreted the test case as a sign that we should switch to
before_save, when the original pitch use case was intended as before_create.
Revert a3ab6ad00872d24d4d87637f93fdae798d0edc79.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adding `if` and `unless` support doesn't bode well if the callback to assign
a token only runs on create.
Switch to `before_save`, but keep the conditional so that no token already
assigned is overriden.
|
| |
| |
| |
| |
| |
| | |
Fix the NoMethodErrors introduced in 224eddf, when adding conditional token creation.
The model declarations but the column wasn't added to the schema.
|
|/
|
|
|
| |
Pass through :if and :unless options from has_secure_token to the
generated before_create callback
|
|\
| |
| |
| |
| | |
y-yagi/match_environment_variable_name_and_error_message
match the environment variable name that actually checking and error message
|
| |
| |
| |
| |
| |
| | |
The error message has become a `DISABLE_DATABASE_ENVIRONMENT_CHECK`, modified to match the error message.
ref: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/migration.rb#L161
|
|\ \
| |/
|/| |
[ci skip] `automatic_inverse_of` returns `false` not `nil` (document …
|
| | |
|
|/
|
|
| |
[ci skip]
|
|\
| |
| | |
Get update_attributes working with SchemaMigration
|
| |
| |
| |
| | |
You cannot use `update_attributes` on models that do not have a primary key. Since SchemaMigration versions are guaranteed to be unique (they have a unique index on them) we can safely use them as a primary key.
|
| |
| |
| |
| |
| |
| | |
This is really strange, as it passes on Travis for 2.3, and it passes
for me locally on 2.2. But on travis w/ 2.2, passing `Float::INFINITY`
in is resulting in an infinite loop. This should resolve it.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is an alternate implementation to #22875, that generalizes a lot of
the logic that type decorators are going to need, in order to have them
work with arrays, ranges, etc. The types have the ability to map over a
value, with the default implementation being to just yield that given
value. Array and Range give more appropriate definitions.
This does not automatically make ranges time zone aware, as they need to
be added to the `time_zone_aware` types config, but we could certainly
make that change if we feel it is appropriate. I do think this would be
a breaking change however, and should at least have a deprecation cycle.
Closes #22875.
/cc @matthewd
|
|\ \
| |/
|/| |
Prevent destructive action on production database
|
| | |
|
| | |
|
| |
| |
| |
| | |
Discussion: https://github.com/rails/rails/pull/22967#discussion_r49137035
|
| |
| |
| | |
Raise an error when a destructive action is made on a database where the current environment is different from the environment stored in the database.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This PR introduces a key/value type store to Active Record that can be used for storing internal values. It is an alternative implementation to #21237 cc @sgrif @matthewd.
It is possible to run your tests against your production database by accident right now. While infrequently, but as an anecdotal data point, Heroku receives a non-trivial number of requests for a database restore due to this happening. In these cases the loss can be large.
To prevent against running tests against production we can store the "environment" version that was used when migrating the database in a new internal table. Before executing tests we can see if the database is a listed in `protected_environments` and abort. There is a manual escape valve to force this check from happening with environment variable `DISABLE_DATABASE_ENVIRONMENT_CHECK=1`.
|
|\ \
| | |
| | | |
Fix `select_values` method signature for consistency
|
| | | |
|
|/ /
| |
| |
| | |
Simply `{update|delete}_sql` aliases to `{update|delete}`.
|
| |
| |
| |
| |
| |
| |
| |
| | |
While the option on `ActiveRecord::Base` is always around, we need to
explicitly set it on the config object. Otherwise the recommended
configuration change results in an error.
Fixes #22839
|
| |
| |
| |
| |
| | |
`sql += " WHERE 1=1"` was introduced in 69cb942.
But it is not needed. ref https://www.sqlite.org/lang_delete.html
|
| |
| |
| |
| | |
`connection.insert_sql` is almost the same as `connection.insert`.
|
|\ \
| | |
| | | |
[close #22917] Don't output to `STDOUT` twice
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`.
Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced
```ruby
logger = Logger.new(STDOUT)
ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT)
# => true
```
To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
|
| | | |
|
|\ \ \
| | | |
| | | | |
Autoload ReferenceDefinition class in abstract adapter so that it can be used by #add_reference in schema_statements
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
used by #add_reference in schema_statements
- Fixes #22916.
|
|\ \ \
| | | |
| | | |
| | | | |
Add short-hand methods for text and blob types in MySQL
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Pg and Sqlite3, `:text` and `:binary` have variable unlimited length.
But in MySQL, these have limited length for each types (ref #21591, #21619).
This change adds short-hand methods for each text and blob types.
Example:
create_table :foos do |t|
t.tinyblob :tiny_blob
t.mediumblob :medium_blob
t.longblob :long_blob
t.tinytext :tiny_text
t.mediumtext :medium_text
t.longtext :long_text
end
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
While the type definition is in Active Model the change of behavior will
be only user facing in Active Record so better to put the entry in its
changelog.
[ci skip]
|
|\ \ \
| |/ /
|/| | |
Fix `connection#create` in PG adapter
|
| | |
| | |
| | |
| | |
| | |
| | | |
Originally `connection#create` had aliased to `connection#insert` in PG
adapter. But it was broken by #7447. Re-alias `create` to `insert` for
fixing it.
|
|\ \ \
| | | |
| | | | |
Fix `unsigned?` and `blob_or_text_column` for Enum columns in MySQL
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
activerecord: allocate fewer objects
|
| | | | |
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix user name in doc [ci skip]
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Allow add_to_transaction with null transaction
|
| | | |
| | | |
| | | |
| | | | |
Fixes https://github.com/rails/rails/issues/22819
|
|\ \ \ \
| | | | |
| | | | | |
Remove FIXME comments about the `Arel::Nodes::Quoted` [ci skip]
|