aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* remove unused constants from activerecordPareshGupta2016-02-012-30/+6
|
* Merge pull request #23391 from erullmann/join_table_indexesRafael França2016-02-011-0/+4
|\ | | | | Added references option to join tables
| * Added references option to join tablesErnst Rullmann2016-01-311-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes issue #22960 When creating join tables with the command rails g migration CreateJoinTableShowroomUser showroom:references user:references The migration will use references to create the joins and output: class CreateJoinTableShowroomUser < ActiveRecord::Migration def change create_join_table :showrooms, :users do |t| t.references :showroom, index: true, foreign_key: true t.references :user, index: true, foreign_key: true end end end This allows for proper refrences with indexes and foreign keys to be easily used when adding join tables. Without `:refrences` the normal output is generated: class CreateJoinTableShowroomUser < ActiveRecord::Migration[5.0] def change create_join_table :showrooms, :users do |t| # t.index [:showroom_id, :user_id] # t.index [:user_id, :showroom_id] end end end
* | Avoid extra `show variables` in migrationRyuta Kamizono2016-02-015-21/+15
|/ | | | | | | | | | | | | `initialize_schema_migrations_table` is called in every migrations. https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/migration.rb#L1080 https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/schema.rb#L51 This means that extra `show variables` is called regardless of the existence of `schema_migrations` table. This change is to avoid extra `show variables` if `schema_migrations` table exists.
* Merge pull request #23359 from kamipo/make_to_primary_keyRafael França2016-02-014-40/+5
|\ | | | | Make to primary key instead of an unique index for internal tables
| * Make to primary key instead of an unique index for internal tablesRyuta Kamizono2016-01-314-40/+5
| |
* | Merge pull request #23373 from ↵Rafael França2016-02-013-17/+1
|\ \ | | | | | | | | | | | | kamipo/remove_duplicated_composite_primary_key_tests Remove duplicated composite primary key tests
| * | Remove duplicated composite primary key testsRyuta Kamizono2016-02-013-17/+1
| | |
* | | Extract `ExplainPrettyPrinter` to appropriate filesRyuta Kamizono2016-02-017-119/+137
|/ /
* | Merge pull request #23372 from kamipo/use_index_in_create_in_test_schemaRafael França2016-02-012-11/+9
|\ \ | | | | | | Use `t.index` in `create_table` instead of `add_index` in test schema
| * | Use `t.index` in `create_table` instead of `add_index` in test schemaRyuta Kamizono2016-01-312-11/+9
| | | | | | | | | | | | For reduce bootstrap queries in tests.
* | | Merge pull request #23374 from prathamesh-sonpatki/migration-compatiblity-testsRafael França2016-01-311-0/+30
|\ \ \ | | | | | | | | Added test for backward compatibility of null constraints on timestamp columns
| * | | Added test for backward compatibility of null constraints on timestamp columnsPrathamesh Sonpatki2016-01-311-0/+30
| |/ /
* | | :speak_no_evil: :warning:Akira Matsuda2016-02-012-2/+6
| | |
* | | Merge pull request #23360 from kamipo/oid_money_precision_is_unusedRafael França2016-01-312-8/+0
|\ \ \ | | | | | | | | `OID::Money.precision` is unused since #15239
| * | | `OID::Money.precision` is unused since #15239Ryuta Kamizono2016-01-312-8/+0
| | |/ | |/| | | | | | | | | | | | | | | | | | | p PostgreSQLAdapter::OID::Money.precision # => 19 p PostgreSQLAdapter::OID::Money.new.precision # => nil
* | | Remove `case macro` from `calculate_constructable`yui-knk2016-02-011-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | Rails has abstract Reflection classes (`MacroReflection`, `AssociationReflection` etc.) and concrete Reflection classes (e.g. `HasManyReflection`, `HasOneReflection` etc.). In many case `calculate_constructable` returns `true`, so change `calculate_constructable` to always return `true` and override this method if necessary.
* | | Merge pull request #23387 from mcfiredrill/clarify-touching-callbacksKasper Timm Hansen2016-01-311-0/+2
|\ \ \ | | | | | | | | clarify the touch true option does not trigger after_save/update [ci skip]
| * | | clarify the touch true option does not trigger after_save/update [ci skip]Tony Miller2016-02-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've gotten tripped up more than a few times on this, thinking that using `belongs_to` with `touch: true` would trigger my after_save or after_update callbacks. The same text is in the documentation for the touch method itself, but I think its helpful to repeat it again here. It might save people some time.
* | | | Merge pull request #23169 from y-yagi/rake_proxy_in_engineKasper Timm Hansen2016-01-311-1/+1
|\ \ \ \ | | | | | | | | | | make rake proxy work in rails engines
| * | | | make rake proxy work in rails enginesyuuji.yaginuma2016-01-311-1/+1
| | |_|/ | |/| |
* | | | Merge pull request #23379 from ↵Kasper Timm Hansen2016-01-311-22/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | yui-knk/define_association_class_on_each_concrete_class Each concrete classes have responsibility to return `association_class`
| * | | | Each concrete classes have responsibility to return `association_class`yui-knk2016-01-311-22/+25
| |/ / /
* / / / Wrangle the asset build into something that sounds more generalMatthew Draper2016-02-011-0/+3
|/ / /
* | | Merge pull request #23362 from vipulnsward/20821-save-doc-updateJon Moss2016-01-301-3/+3
|\ \ \ | |_|/ |/| | - Updated persistence documentation to make it clear that save and sa…
| * | - Updated persistence documentation to make it clear that save and save! ↵Vipul A M2016-01-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | won't update a record if validation fails. - Also fixed `update` method's documention to be uniform about this statement. Fixes #20821 [ci skip] [Vipul A M & pseidemann ]
* | | Revert "Merge pull request #23346 from kamipo/refactor_oid_money_precision"Rafael Mendonça França2016-01-302-5/+9
| | | | | | | | | | | | | | | | | | | | | This reverts commit ff835f90800a3e4122d64606cb328908c2e0e071, reversing changes made to c4d85dfbc71043e2a746acd310e32f4f04db801a. Reason: This broke the tests. We will add back after investigated.
* | | Merge pull request #23345 from ↵Rafael França2016-01-302-0/+13
|\ \ \ | | | | | | | | | | | | | | | | yui-knk/warning_when_composite_primary_key_is_detected Warn if `AR.primary_key` is called for a table who has composite prim…
| * | | Warn if `AR.primary_key` is called for a table who has composite primary keyyui-knk2016-01-302-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If `AR.primary_key` is called for a table who has composite primary key, the method returns `nil`. This behavior sometimes generates invalid SQL. The first time developers notice to invalid SQL is when they execute SQL. This commit enables developers to know they are doing something dangerous as soon as possible.
* | | | Merge pull request #23349 from kamipo/refactor_column_existsRafael França2016-01-301-7/+8
|\ \ \ \ | | | | | | | | | | Refactor `column_exists?` in `SchemaStatements`
| * | | | Refactor `column_exists?` in `SchemaStatements`Ryuta Kamizono2016-01-301-7/+8
| |/ / /
* | | | Merge pull request #23355 from kamipo/fix_bigint_for_enum_columnsRafael França2016-01-303-2/+7
|\ \ \ \ | | | | | | | | | | Fix `bigint?` for Enum columns in MySQL
| * | | | Fix `bigint?` for Enum columns in MySQLRyuta Kamizono2016-01-313-2/+7
| |/ / / | | | | | | | | | | | | Follow up to #22896.
* | | | Merge pull request #23350 from kamipo/refactor_schema_migration_drop_tableRafael França2016-01-301-4/+1
|\ \ \ \ | | | | | | | | | | Make `SchemaMigration.drop_table` to one SQL
| * | | | Make `SchemaMigration.drop_table` to one SQLRyuta Kamizono2016-01-301-4/+1
| |/ / / | | | | | | | | | | | | | | | | `SchemaMigration.drop_table` is only used in tests. Simply we can use `drop_table if_exists: true`.
* | | | Merge pull request #23352 from yui-knk/move_test_conditionsRafael França2016-01-301-11/+9
|\ \ \ \ | | | | | | | | | | There is no need to define test if a connection does not support prim…
| * | | | There is no need to define test if a connection does not support primary_keyyui-knk2016-01-311-11/+9
| |/ / /
* | | | Merge pull request #23353 from ↵Rafael França2016-01-301-6/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/remove_unused_lost_connection_error_messages Remove unused `LOST_CONNECTION_ERROR_MESSAGES`
| * | | | Remove unused `LOST_CONNECTION_ERROR_MESSAGES`Ryuta Kamizono2016-01-311-6/+0
| |/ / / | | | | | | | | | | | | | | | | `LOST_CONNECTION_ERROR_MESSAGES` was added by f384582. But currently unused from anywhere.
* | | | Merge pull request #23347 from yui-knk/explicitly_define_columns_as_interfaceRafael França2016-01-301-1/+3
|\ \ \ \ | | | | | | | | | | Explicitly define `columns` method as an interface
| * | | | Explicitly define `columns` method as an interfaceyui-knk2016-01-301-1/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | `ActiveRecord::ConnectionAdapters::SchemaStatements#columns` is defined here as an interface method here. So changes to raise `NotImplementedError` same as `tables`, `views` ...etc.
* / / / Refactor `OID::Money.precision`Ryuta Kamizono2016-01-302-9/+5
|/ / /
* | | Intervene on change_table as well as create_tableMatthew Draper2016-01-301-0/+13
| | |
* | | Don't recommend using `ActiveRecord::Base[]`Sean Griffin2016-01-291-3/+0
| | | | | | | | | These methods are more expensive than the alternatives, and have strange semantics that are likely undesirable.
* | | Merge pull request #23252 from kamipo/remove_limit_11Rafael França2016-01-291-1/+0
|\ \ \ | | | | | | | | Remove `limit: 11` as backward-compatibility with Rails 2.0
| * | | Remove `limit: 11` as backward-compatibility with Rails 2.0Ryuta Kamizono2016-01-271-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Integer limit as a byte size was introduced from Rails 2.1. `limit: 11` is not a byte size, but take care for backward-compatibility with Rails 2.0 (a892af6). Integer limit out of range should be allowed to raise by #6349. I think we should remove this backward-compatibility.
* | | | Merge pull request #23188 from jcoleman/ar-connection-execute-docs-clarificationRafael França2016-01-292-1/+7
|\ \ \ \ | |_|/ / |/| | | Clarify DatabaseStatements#execute docs re: memory usage.
| * | | Clarify DatabaseStatements#execute docs re: memory usage.James Coleman2016-01-222-1/+7
| | | |
* | | | Reworked ActiveRecord::Relation#last to always use SQLBogdan Gusiev2016-01-283-31/+60
| | | | | | | | | | | | | | | | instead of loading relation
* | | | Merge pull request #23307 from mgrachev/fix-schema-migrationsEileen M. Uchitelle2016-01-281-1/+1
|\ \ \ \ | | | | | | | | | | Fix a bug with initialize schema_migrations table
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 18:57:36 +0000