aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Use `QUOTED_TRUE` and `QUOTED_FALSE` instead of magic stringsyui-knk2016-04-052-6/+16
| | | | | | Because we define `QUOTED_TRUE` as `"1"` and `QUOTED_FALSE` as `"0"`. And add test cases to ensure this commit does not break current behavior even if the value of `attributes_before_type_cast` is false.
* Merge pull request #24247 from ypxing/refactor_substitute_valuesAndrew White2016-04-041-5/+5
|\ | | | | enhance ActiveRecord#substitute_values to loop values just once
| * enhance ActiveRecord#substitute_values to loop values just onceRick Xing2016-03-191-5/+5
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-04-031-1/+1
|\ \
| * | format as code [ci-skip]Gaurish Sharma2016-03-141-1/+1
| | |
* | | Revert "Deprecate table names containing dots"Sean Griffin2016-03-312-15/+0
| | | | | | | | | | | | | | | | | | This reverts commit 7b82e1c77b48cb351da4e0ed6ea0bac806d4925c. This would have removed the ability to reference a schema when using PG
* | | Merge pull request #23658 from ↵Rafael França2016-03-317-19/+20
|\ \ \ | | | | | | | | | | | | | | | | kamipo/move_quoted_names_cache_up_to_abstract_adapter Move `@quoted_{column|table}_names` cache up to the abstract adapter
| * | | Move `@quoted_{column|table}_names` cache up to the abstract adapterRyuta Kamizono2016-03-317-19/+20
| | | |
* | | | Prepared statements shouldn't share a cache with unprepared statementsSean Griffin2016-03-312-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When prepared statements are enabled, the statement cache caches the SQL directly, including the bind parameters. If a similar query is run later with prepared statements disabled, we need to use a separate cache instead of trying to share the same one. Fixes #24351
* | | | Deprecate table names containing dotsSean Griffin2016-03-312-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dots have special meaning in most backends (e.g. everything except SQLite3), as well as most methods that work with table or column names. This isn't something that we ever explicitly supported, but there's at least one case of somebody using this (see #24367), so we'll go through a deprecation cycle as normal.
* | | | Ensure associations still work when the table name contains a dotSean Griffin2016-03-313-4/+6
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue occured because associations now call `where` directly, and a dot in the key name for `where` means nested tables. For this fix, we now pass the table name as a symbol, and do not attempt to expand symbols containing a dot. This is a temporary fix. I do not think we should support table names containing a dot, as it has a special meaning in most backends, as well as most APIs that involve table names. This commit does not include a test, as I am going to deprecate table names containing dots in the following commit. Fixes #24367
* | | Merge pull request #24368 from kamipo/make_to_private_the_visibilitySean Griffin2016-03-304-32/+54
|\ \ \ | | | | | | | | Make to private the visibility of `_quote` and `_type_cast`
| * | | Make to private the visibility of `_quote` and `_type_cast`Ryuta Kamizono2016-03-304-32/+54
| | | |
* | | | Merge pull request #24356 from denofevil/fixture_filenameRafael França2016-03-302-1/+13
|\ \ \ \ | | | | | | | | | | provide file name for fixture ERB
| * | | | provide file name for fixture ERBDennis Ushakov2016-03-302-1/+13
| | |_|/ | |/| |
* | | | Pass over CHANGELOGs [ci skip]Prathamesh Sonpatki2016-03-301-2/+2
| | | |
* | | | Merge pull request #24362 from kamipo/add_test_create_record_with_pk_as_zeroRafael França2016-03-292-0/+7
|\ \ \ \ | | | | | | | | | | Add a test case for create a record with primary key as zero
| * | | | Add a test case for create a record with primary key as zeroRyuta Kamizono2016-03-302-0/+7
| | |/ / | |/| |
* | | | Merge pull request #24363 from kamipo/remove_except_helper_in_test_schemaRafael França2016-03-291-7/+1
|\ \ \ \ | | | | | | | | | | Remove `except` helper for test schema
| * | | | Remove `except` helper for test schemaRyuta Kamizono2016-03-301-7/+1
| |/ / /
* | | | Merge pull request #24349 from chrisarcand/add-changelog-for-24305Rafael França2016-03-291-0/+6
|\ \ \ \ | | | | | | | | | | Add changelog for #24305
| * | | | Add changelog for #24305 [skip ci]Chris Arcand2016-03-281-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Forgot to add, sigh. Closes #24273
* | | | | Merge pull request #24327 from bogdanvlviv/patch-2Rafael França2016-03-291-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | Update compatibility.rb
| * | | | Update compatibility.rbBogdan2016-03-261-1/+1
| | | | |
* | | | | Delegate some additional methods in querying.rbKenta2016-03-303-1/+34
| |/ / / |/| | |
* | | | Merge pull request #24337 from xw19/realations-properlyVipul A M2016-03-271-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] relations inside <tt> tag
| * | | | [ci skip] relations inside <tt> tagSourav Moitra2016-03-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | s removed objects added
* | | | | Merge pull request #24328 from bogdanvlviv/patch-3Vipul A M2016-03-271-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | Fix description for method ActiveRecord::ConnectionAdapters::SchemaStatements#add_timestamps [ci skip]
| * | | | Fix description for method ↵Bogdan2016-03-271-2/+2
| |/ / / | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::SchemaStatements#add_timestamps [ci skip]
* / / / add `:index_errors` option to example [ci skip]yuuji.yaginuma2016-03-271-2/+2
|/ / /
* | | Highlight the dynamic method finder 'find_by_' [ci skip]Santosh Wadghule2016-03-261-1/+2
| | |
* | | Revert "Ensure `config.active_record.time_zone_aware_types` is always set"Rafael Mendonça França2016-03-241-1/+0
| | | | | | | | | | | | | | | | | | | | | This reverts commit 43ccebc1db072ba0c96a67de0b3db78fd8fd0973. This is not fixing the configuration problem since we are assigning to the ActiveRecord::Base not the configuration. See #24303.
* | | Merge pull request #24292 from arthurnn/arthurnn/pk_sequence_klassArthur Nogueira Neves2016-03-242-2/+14
|\ \ \ | | | | | | | | Move sequence value methods to Model level
| * | | Move sequence value methods to Model levelArthur Neves2016-03-242-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `prefetch_primary_key?` and `next_sequence_value` methods live in the connection level at the moment, that make sense when you are generating the sequence from the database, in the same connection. Which is the use case today at the Oracle and Postgres adapters. However if you have an service that generates IDs, that has nothing to do with the database connection, and should not be fetched from there. Another use case, is if you want to use another connection to fetch IDs, that would not be possible with the current implementation, however when we move those methods to the model level, you can use a new connection there. Also this makes easier for gems to add behavior on those methods.
* | | | Memoize user provided defaults before type castingSean Griffin2016-03-243-5/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a proc is given as a default value, the form builder ends up displaying `Proc#to_s` when the default is used. That's because we didn't handle the proc until type casting. This issue technically can occur any time that a proc is the value before type casting, but in reality the only place that will occur is when a proc default is provided through the attributes API, so the best place to handle this edge case is there. I've opted to memoize instead of just moving the `Proc#call` up, as this made me realize that it could potentially interact very poorly with dirty checking. The code here is a little redundant, but I don't want to rely on how `value_before_type_cast` is implemented in the super class, even if it's just an `attr_reader`. Fixes #24249 Close #24306
* | | | Make 'migrate' clear the schema cache afterwardChris Arcand2016-03-242-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without clearing the caches afterward, removals done in migrations would not be reflected in a separate task in the same process. That is, given a table with a migration to remove a column, the schema cache would still reflect that a table has that in something such as the 'db:seed' task: `rake db:migrate db:seed` (A common thing to do in a script for a project ala `bin/setup`) vs `rake db:migrate && rake db:seed` (Two processes) The first would not reflect that the column was removed. The second would (cache reset).
* | | | Fix a tip in Active Record time attributes deprecationGenadi Samokovarov2016-03-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have hit this deprecation in a newly created Rails 5 application and the suggested tip lead me to a `NoMethodError`. It's not trivial to actually make the following work, because of the ActiveRecord::Base class attributes setting dance in the Active Record railtie. config.active_record.time_zone_aware_types << :time Decided to suggest setting it explicitly to the values we need. [ci skip]
* | | | Change for `ActiveRecord::Migration.[]` to raise `ArgumentError` instead of ↵yui-knk2016-03-242-1/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | `RuntimeError` The error is raised because user passed invalid version number to a public api of `ActiveRecord`, so `ArgumentError` is more suitable. And add a test case checking if an error is raised when unknown migration version is passed, because these test cases are not implemented.
* | | Merge pull request #24167 from ↵Jeremy Daer2016-03-233-28/+44
|\ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/append_sql_mode_instead_of_overwriting_in_strict_mode Append sql_mode instead of overwriting in strict mode
| * | | Append sql_mode instead of overwriting in strict modeRyuta Kamizono2016-03-132-28/+37
| | | | | | | | | | | | | | | | For keep the default SQL mode.
* | | | guides, sync 5.0 release notes with changelogsYves Senn2016-03-221-1/+2
| |/ / |/| | | | | | | | | | | | | | | | | | | | [ci skip] Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft. This is a follow up to c94045d and contains changes made since the release of beta1.
* | | Merge pull request #22518 from ↵Arthur Nogueira Neves2016-03-182-1/+18
|\ \ \ | | | | | | | | | | | | | | | | RochesterinNYC/better-error-message-for-includes-relations-missing Improve error message for missing relations for includes and eager_load
| * | | Improve clarity of error message for missing includes and eager_loadJames Wen2016-01-282-1/+18
| | | | | | | | | | | | | | | | relations
* | | | Merge pull request #24201 from rails/rake-db-createRafael França2016-03-173-10/+17
|\ \ \ \ | | | | | | | | | | Creates development and test databases in db:migrate task
| * | | | Creates development and test databases in db:migrate taskRafael Mendonça França2016-03-143-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts a334425caff9b2140d5e99fcfc2eb8c4ab10bdfa. The main reason is that now the workflow is inconsistent when using spring. When using spring `RAILS_ENV` is always set, so only one database is created. This means that in development `bin/rake db:create` and `bundle exec rake db:create` have different results. It also breaks the `bin/setup` script since `bin/rake db:setup db:test:prepare` will fail.
* | | | | Remove log-related stuff from ActiveSupport::DependenciesAaron Ang2016-03-151-5/+0
|/ / / / | | | | | | | | | | | | | | | | In this patch, all log-related stuff in `ActiveSupport::Dependencies` is removed because the logging is no longer useful.
* | | | [ci skip] Fix the FinderMethods#find documentakihiro172016-03-141-2/+2
| | | | | | | | | | | | | | | | We should use #find_or_initialize_by and #find_or_create_by because #first_or_initialize and #first_or_create methods are not the public API
* | | | Fix `warning: method redefined; discarding old female`Ryuta Kamizono2016-03-121-3/+0
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` $ ARCONN=mysql2 be ruby -w -Itest test/cases/scoping/default_scoping_test.rb Using mysql2 /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old female /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of female was here /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old male /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of male was here ```
* | | Merge pull request #23797 from ↵Rafael França2016-03-113-3/+13
|\ \ \ | | | | | | | | | | | | | | | | kamipo/case_sensitive_comparison_for_non_string_column The BINARY Operator is only needed for string columns
| * | | The BINARY Operator is only needed for string columnsRyuta Kamizono2016-02-223-3/+13
| | | | | | | | | | | | | | | | Follow up to #13040.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 12:52:17 +0000