aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #5096 from lawso017/masterAaron Patterson2012-02-212-19/+43
| | | | Restoring ability to derive id/sequence from tables with nonstandard sequences for primary keys
* Fix some warnings on 3-2-stablekennyj2012-02-211-1/+1
|
* fix test with ruby 187-p358Arun Agrawal2012-02-181-1/+5
|
* Merge pull request #5038 from carlosantoniodasilva/fix-db-migrate-redoJosé Valim2012-02-141-1/+4
| | | | Always reenable _dump task in AR databases rake. Closes #5030
* Use real table and columns for index testRafael Mendonça França2012-02-081-3/+3
|
* Push proper test changes for previous commit conflicts.José Valim2012-02-081-2/+4
|
* Handle nil in add_index :length option in MySQLPaul Sadauskas2012-02-082-1/+6
| | | | | | | | | | | | | | | | | | | | | | | Our schema.rb is being generated with an `add_index` line similar to this: add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil} This is the same as it was on Rails 3.1.3, however, now when that schema.rb is evaluated, its generating bad SQL in MySQL: Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: CREATE UNIQUE INDEX `xxx` ON `foo` (`foo`(8), `bar`()) This commit adds a check for nil on the length attribute to prevent the empty parens from being output. Conflicts: activerecord/test/cases/migration/index_test.rb Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix attribute_before_type_cast for serialized attributes. Fixes #4837.Jon Leighton2012-02-073-0/+25
| | | | | | Conflicts: activerecord/lib/active_record/core.rb
* no need to check for this constantXavier Noria2012-02-071-1/+1
|
* Fixed the documenation for 'to_xml'Markus Fenske2012-02-071-1/+2
|
* let automatic EXPLAIN ignore CACHE notificationsXavier Noria2012-02-032-1/+52
|
* Fix Issue #4819densya2032012-02-041-1/+1
| | | | | | 'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1' Just a typo of 'ActiveSupport::...'
* Merge pull request #4809 from cfeist/feist-sqlite-binary-corruptionAaron Patterson2012-02-023-17/+3
| | | | Fix for SQLite binary data corrupter (to master branch)
* Merge pull request #4543 from jdelStrother/find_or_initJon Leighton2012-02-012-2/+13
| | | | Don't instantiate two objects in collection proxy / find_or_instantiate_by
* Fix broken tests added by 85c724d59Rafael Mendonça França2012-01-313-13/+13
|
* Improve deprecation messageJon Leighton2012-01-311-7/+17
|
* Merge pull request #4783 from gregolsen/ids_reader_fixJon Leighton2012-01-313-1/+6
| | | | ids_reader method fixed, test added to has_many association (for PostgreSQL)
* Allow writing unknown attributes, but with a deprecation warning. Closes #4583.Jon Leighton2012-01-312-4/+14
|
* Add workaround and deprecation if the inherited hook is not executed. Closes ↵Jon Leighton2012-01-312-0/+22
| | | | #4757.
* Merge pull request #4763 from kennyj/fix_4754Jon Leighton2012-01-312-1/+17
| | | | [MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES
* query cache instrumentation should included the bindings in the payload ↵Xavier Noria2012-01-301-1/+1
| | | | [closes #4750]
* Merge pull request #4715 from pwim/find-create-multi-argsJon Leighton2012-01-272-1/+12
| | | | Fix regression from Rails 3.1
* updating RAILS_VERSIONXavier Noria2012-01-261-1/+1
|
* CHANGELOG revision for v3.2.1Xavier Noria2012-01-261-2/+6
|
* Merge pull request #4696 from rafaelfranca/issue-4653Aaron Patterson2012-01-261-2/+0
|\ | | | | Remove extra attributes from HABTM join tables in AR tests
| * Remove extra attributes from HABTM join tables in AR testsRafael Mendonça França2012-01-261-2/+0
| | | | | | | | | | | | | | | | | | HABTM Join tables should not have extra attributes When extra attributes is needed in HABTM join tables is better to use `has_many :through` association. Fix #4653
* | registers 2483460 in the CHANGELOGXavier Noria2012-01-261-3/+5
| |
* | disable automatic explain if there is no logger [closes #4671]Xavier Noria2012-01-262-1/+17
|/
* call to_s on value passed to table_name=Sergey Nartimov2012-01-262-1/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix another race condition.Jon Leighton2012-01-204-6/+23
| | | | | | | | | | From 2c667f69aa2daac5ee6c29ca9679616e2a71532a. Thanks @pwnall for the heads-up. Conflicts: activerecord/lib/active_record/core.rb
* Preparing for 3.2.0 releaseDavid Heinemeier Hansson2012-01-202-2/+2
|
* Merge pull request #4531 from exviva/pessimistic_with_lockAaron Patterson2012-01-193-1/+70
| | | | Add ActiveRecord::Base#with_lock
* select doesn't take multiple arguments - fixes #4539 [ci skip]Vijay Dev2012-01-191-2/+2
| | | | | Didn't cherry pick the master commit because this one already had some of the fixes made in master.
* Merge pull request #4487 from sarenji/fix-reset-countersAaron Patterson2012-01-177-3/+45
| | | | Fix bug where reset_counters resets the wrong counter cache.
* Fix race condition :bomb:Jon Leighton2012-01-131-4/+11
|
* Fix table_name in ActiveRecord with more than one abstract ancestorsPiotr Sarnacki2012-01-122-3/+18
| | | | | | | | | | | | | | | | | When subclassing abstract_class table_name should be always computed based on class name, no matter if superclass is subclassing base or another abstract_class. So: class FirstAbstract < ActiveRecord::Base self.abstract_class = true end class SecondAbstract < FirstAbstract self.abstract_class = true end class Post < SecondAbstract self.table_name #=> 'posts' (not 'second_abstracts') end
* moving to arel 3.0.0Aaron Patterson2012-01-121-1/+1
|
* fixes in api docsVijay Dev2012-01-131-1/+1
|
* Add CHANGELOG entrySantiago Pastorino2012-01-111-0/+3
|
* on and ON are type casted to a true boolean columnSantiago Pastorino2012-01-112-2/+31
|
* add documentation explaining reorder behaviorMatt Jones2012-01-111-0/+10
|
* Merge pull request #4408 from tomstuart/read-and-write-attribute-aliasesSantiago Pastorino2012-01-112-5/+46
| | | | #[] and #[]= are no longer interchangeable with #read_attribute and #write_attribute
* FFFFFFFFUUUUUUUUUUUUUUUUUUUUUUUUU :bomb:Aaron Patterson2012-01-101-3/+0
|
* deprecate the subdirectories parameter to `migrations`Aaron Patterson2012-01-101-2/+13
| | | | | | Conflicts: activerecord/lib/active_record/migration.rb
* Bump to rc2Santiago Pastorino2012-01-041-1/+1
|
* Merge pull request #4282 from edgecase/order_after_reorderAaron Patterson2012-01-046-9/+25
| | | | correctly handle order calls after a reorder
* Fix GH #4285. Remove options when we record calling creat_tablekennyj2012-01-042-1/+7
|
* deprecate ActiveSupport::Base64Sergey Nartimov2012-01-031-4/+4
| | | | extend and define ::Base64 if needed
* Document that index names are made up of all columns, not just the first.Jo Liss2011-12-291-9/+2
| | | | | | | | | | | index_name has been using the following expression "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}" since at least 2006 (bc7f2315), and that's how they come out in my DB. Please check that this is correct before merging into master, perhaps I'm misunderstanding the section I changed.
* Remove unnecessary comma.Uģis Ozols2011-12-291-1/+1
|