| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ /
| | |
| | |
| | |
| | | |
These tests should be in inheritance_test.rb since its testing a
feature which is implemented in inheritance.rb
|
|\ \ \
| |/ /
|/| | |
SQLite3 3.6.8+ supports nested transactions [ci skip]
|
| | |
| | |
| | |
| | |
| | | |
http://www.sqlite.org/lang_savepoint.html
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #8079.
I had to rework some of the tests because the mock allowed any arguments
for `connection.exeucte`. I think this is very dangerous as there could
anything be executed without the tests noticing it.
|
| | |
| | |
| | |
| | |
| | |
| | | |
"utf8mb4"
Please, see rationale in the included CHANGELOG patch.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
PR #5210 added a Friendship model to illustrate a bug, but in doing so
created a confusing structure because both belongs_to declarations in
Friendship referred to the same side of the join. The new structure
maintains the integrity of the bug test while changing the follower
relationship to be more useful for other testing.
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
the primary key on an association will make sure that the corresponding
counter on the association is changed properly. Fixes #9722.
|
|\ \ \
| | | |
| | | | |
Method #primary_key? is not reused
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
senny/9712_option_to_turn_references_deprecation_off
make it possible to disable implicit join references.
|
| |/ / /
| | | |
| | | |
| | | | |
Closes #9712.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reimplements the behaviour of Rails 3, as I couldn't see why we
shouldn't cache the object, and @alindeman had a good use case for
caching it:
https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
|
|\ \ \
| | | |
| | | | |
rename `Relation#uniq` to `Relation#distinct`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We moved more and more away from passing options to finder / calculation
methods. The `:distinct` option in `#count` was one of the remaining places.
Since we can now combine `Relation#distinct` with `Relation#count` the option
is no longer necessary and can be deprecated.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our
Relation API is close to SQL terms I renamed `#uniq` to `#distinct`.
There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue
to work. I also updated the documentation to promote the use of `#distinct`.
|
|\ \ \ \
| |/ / /
|/| | | |
Cast number to string in Postgres
|
| | | |
| | | |
| | | |
| | | | |
fixes #9170
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #9724.
Raise an `ArgumentError` when the name of the counter does not
match an association name.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password entirely from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
|
| | | | |
|
|/ / /
| | |
| | | |
A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`.
|
|\ \ \
| | | |
| | | | |
dependent: :destroy should call destroy_all
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit https://github.com/rails/rails/pull/9668 shows warning
when `delete_all` is invoked with `:dependent` option
`:destroy`.
Unfortunately invoking `Post.destroy_all` invokes
`post.comments.delete_all` as part of `has_many` callbacks.
This commit ensures that instead `post.comments.destroy_all` is
invoked and in the process no warning is generated.
See issue #9567 for details .
|
| | |
| | |
| | |
| | | |
To make quote escape binary data correctly it needs the column passed in.
|
|/ / |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Show warning message if delete_all is firing callbacks
|
| | |
| | |
| | |
| | |
| | |
| | | |
`post.comments.delete_all` will fire callbacks if :dependent option is
:destroy . It will be fixed in Rails 4.1 . In the meantime display
a warning . Look at #9567 for details .
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
assertion for
https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5
d5f4/activerecord/lib/active_record/inheritance.rb#L32
|
|\ \
| | |
| | | |
Address ActiveRecord::StatementInvalid: OCIError: ORA-00979
|