Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove AR auto-explain (config.auto_explain_threshold_in_seconds) | Yves Senn | 2013-02-24 | 7 | -155/+39 |
| | | | | | | | | | | We discussed that the auto explain feature is rarely used. This PR removes only the automatic explain. You can still display the explain output for any given relation using `ActiveRecord::Relation#explain`. As a side-effect this should also fix the connection problem during asset compilation (#9385). The auto explain initializer in the `ActiveRecord::Railtie` forced a connection. | ||||
* | Merge pull request #9356 from senny/988_multiple_actions_for_after_commit | Steve Klabnik | 2013-02-24 | 3 | -14/+60 |
|\ | | | | | multiple actions for :on option with `after_commit` and `after_rollback` | ||||
| * | multiple actions for :on option with `after_commit` and `after_rollback` | Yves Senn | 2013-02-21 | 3 | -14/+60 |
| | | | | | | | | Closes #988. | ||||
* | | test case to prevent duplicated associations with custom PK. | Yves Senn | 2013-02-24 | 2 | -0/+12 |
| | | | | | | | | closes #9201 | ||||
* | | Oracle enhanced adapter shortens its name if it is longer than 30 bytes | Yasuo Honda | 2013-02-24 | 1 | -2/+10 |
| | | | | | | | | because of Oracle database index length spec. | ||||
* | | also rename the test-case class inside columns_test.rb | Yves Senn | 2013-02-24 | 1 | -1/+1 |
| | | |||||
* | | adds a missing LIMIT 1 in #take docs | Xavier Noria | 2013-02-23 | 1 | -1/+1 |
| | | |||||
* | | rename_column_test.rb -> columns_test.rb to reveal intent. | Yves Senn | 2013-02-23 | 1 | -0/+0 |
| | | | | | | | | | | | | | | | | I renamed the test to better communicate it's intention. Since it also tests: - add_column - remove_column - change_column There is no reason to call it rename_column_test. | ||||
* | | forwardport #9388 rename/remove column preserves custom PK. | Yves Senn | 2013-02-23 | 1 | -1/+15 |
|/ | |||||
* | Merge pull request #9348 from schuetzm/doc_no_indices_with_create_join_table | Xavier Noria | 2013-02-21 | 1 | -0/+8 |
|\ | | | | | Add more documentation for create_join_table. | ||||
| * | Indent comment block by two spaces. | Marc Schütz | 2013-02-21 | 1 | -4/+4 |
| | | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417 | ||||
| * | Add more documentation for create_join_table. | Marc Schütz | 2013-02-20 | 1 | -0/+8 |
| | | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form. | ||||
* | | Fix warning | Rafael Mendonça França | 2013-02-21 | 1 | -1/+1 |
|/ | |||||
* | ActiveRecord -> Active Record [ci skip] | Xavier Noria | 2013-02-20 | 1 | -1/+1 |
| | |||||
* | Merge pull request #9345 from ↵ | Rafael Mendonça França | 2013-02-20 | 1 | -10/+10 |
|\ | | | | | | | | | wangjohn/change_name_of_query_method_argument_checker_for_clarity Renaming the check_empty_arguments method to something more descriptive. | ||||
| * | Renaming the check_empty_arguments method to something more descriptive. | wangjohn | 2013-02-20 | 1 | -10/+10 |
| | | | | | | | | | | The function is now called has_arguments? so that it's easier to tell that it's just checking to see if the args are blank or not. | ||||
* | | removes relation bang methods from the AR changelog [ci skip] | Xavier Noria | 2013-02-20 | 1 | -12/+0 |
| | | |||||
* | | removes some remaining relation bang methods documentation [ci skip] | Xavier Noria | 2013-02-20 | 1 | -3/+0 |
| | | |||||
* | | puts a lambda around a default scope [ci skip] | Xavier Noria | 2013-02-20 | 1 | -1/+1 |
| | | |||||
* | | adds an example in the docs of #not with multiple conditions [ci skip] | Xavier Noria | 2013-02-20 | 1 | -4/+8 |
| | | |||||
* | | database.yml -> config/database.yml [ci skip] | Xavier Noria | 2013-02-20 | 1 | -1/+1 |
| | | |||||
* | | Skip failing test and add a FIXME note | Rafael Mendonça França | 2013-02-20 | 1 | -0/+2 |
| | | |||||
* | | unify AR changelog entries [ci skip] | Yves Senn | 2013-02-20 | 1 | -4/+4 |
| | | |||||
* | | also rename indexes when a table or column is renamed | Yves Senn | 2013-02-20 | 7 | -8/+73 |
| | | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed. | ||||
* | | moves the new :nsec date format to the Active Support changelog [ci skip] | Xavier Noria | 2013-02-20 | 1 | -6/+1 |
| | | |||||
* | | revises the documentation of AR::Base.cache_timestamp_format [ci skip] | Xavier Noria | 2013-02-20 | 1 | -2/+4 |
|/ | |||||
* | reserve less chars for internal sqlite3 operations | Yves Senn | 2013-02-20 | 1 | -7/+7 |
| | |||||
* | reserve index name chars for internal rails operations | Yves Senn | 2013-02-20 | 6 | -9/+64 |
| | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved. | ||||
* | Merge pull request #9332 from ↵ | Rafael Mendonça França | 2013-02-20 | 3 | -15/+45 |
|\ | | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors | ||||
| * | Added comments about the check_empty_arguments method which is called | wangjohn | 2013-02-20 | 3 | -15/+45 |
| | | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests. | ||||
* | | Merge pull request #9342 from hone/db_migrate_with_database_url | Rafael Mendonça França | 2013-02-20 | 1 | -1/+1 |
|\ \ | | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest | ||||
| * | | make type_cast_value a class level method | Terence Lee | 2013-02-21 | 1 | -1/+1 |
| |/ | |||||
* / | Reduced memory leak problem in transactions by lazily updating AR objects ↵ | wangjohn | 2013-02-20 | 6 | -6/+89 |
|/ | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks. | ||||
* | standardize database_configuration to a hash | Terence Lee | 2013-02-21 | 2 | -5/+3 |
| | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does | ||||
* | Whitespace :heart: and hash syntax change | Rafael Mendonça França | 2013-02-20 | 1 | -23/+22 |
| | |||||
* | descriptive error message when AR adapter was not found. Closes #7313. | Yves Senn | 2013-02-20 | 3 | -3/+20 |
| | |||||
* | s/revertible/reversible/ | Xavier Noria | 2013-02-19 | 1 | -1/+1 |
| | |||||
* | Merge pull request #9315 from ↵ | Steve Klabnik | 2013-02-19 | 1 | -23/+0 |
|\ | | | | | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb | ||||
| * | delete duplicated tests in AR base_test.rb | Takehiro Adachi | 2013-02-19 | 1 | -23/+0 |
| | | | | | | | | These are duplicated with the tests which are in relations_test.rb | ||||
* | | moves a CHANGELOG entry from AR to AP | Xavier Noria | 2013-02-19 | 1 | -4/+0 |
| | | |||||
* | | small tweaks in the AR CHANGELOG | Xavier Noria | 2013-02-19 | 1 | -4/+4 |
| | | |||||
* | | Raise an error when query methods have blank arguments, and when blank ↵ | John J Wang | 2013-02-19 | 2 | -9/+34 |
| | | | | | | | | arguments are meaningless. | ||||
* | | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 2 | -5/+5 |
|/ | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | add tests for ActiveRecord::Base#create | Takehiro Adachi | 2013-02-18 | 1 | -0/+8 |
| | |||||
* | Add CHANGELOG entry for 41ff6a10216f48f43605a1f9cd6094765cab750f | Andrew White | 2013-02-17 | 1 | -0/+40 |
| | | | | [ci skip] | ||||
* | copy-edits RDoc in fba496f | Xavier Noria | 2013-02-16 | 1 | -4/+4 |
| | | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".) | ||||
* | Remove valid_type? method | Jon Leighton | 2013-02-15 | 4 | -17/+0 |
| | | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 2 | -0/+24 |
|\ | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | copy edits [ci skip] | Vijay Dev | 2013-02-15 | 1 | -1/+1 |
| | | |||||
| * | Add example for ActiveRecord::Base.joins using a string as argument | Maurizio De Santis | 2013-02-07 | 1 | -0/+5 |
| | |