aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Oracle needs table to check index existenceJosh Susser2012-12-061-3/+3
|
* convert time to stringJosh Susser2012-12-062-2/+2
| | | why is this a Time to start with?
* dump schema.rb without :version optionJosh Susser2012-12-051-4/+2
|
* Merge branch 'joshsusser-master' into mergeAaron Patterson2012-12-0515-58/+268
|\ | | | | | | | | | | | | | | | | | | | | * joshsusser-master: style cleanup Add migration history to schema.rb dump Add metadata to schema_migrations Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/schema.rb
| * style cleanupJosh Susser2012-12-033-6/+5
| |
| * Add migration history to schema.rb dumpJosh Susser2012-12-029-17/+146
| |
| * Add metadata to schema_migrationsJosh Susser2012-12-0110-43/+125
| | | | | | | | | | migrated_at: timestamp when migration run fingerprint: md5 hash of migration source name: filename without version or extension
* | Replace comments' non-breaking spaces with spacesclaudiob2012-12-043-6/+6
| | | | | | | | | | | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code.
* | Merge pull request #8417 from kennyj/fix_8414Rafael Mendonça França2012-12-042-3/+8
|\ \ | | | | | | Fix #8414. Performance problem with postgresql adapter primary_key function.
| * | Fix #8414. Performance problem with postgresql adapter primary_key function.kennyj2012-12-052-3/+8
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-048-35/+22
|\ \ \ | |/ / |/| | | | | | | | Conflicts: guides/source/migrations.md
| * | Revert "Add documentation to TransactionIsolationError [ci skip]"Vijay Dev2012-12-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5ff59704f68d284381606a1b76e4ffcfd73b2cfa. Reason: Seems dubious and adds less value. [ci skip]
| * | Fix typo.Hendy Tanata2012-12-031-2/+2
| | |
| * | grammar improvements for increment_counter and decrement_counter docsMatthew Robertson2012-12-021-6/+8
| | |
| * | increment_counter and decrement_counter can accept and array of ids as an argMatthew Robertson2012-12-021-2/+2
| | |
| * | Cleans and removes 'Examples' tag [ci skip]Alvaro Pereyra2012-12-014-9/+4
| | |
| * | Cleans and removes useless 'Examples' tag [ci skip]Alvaro Pereyra2012-12-011-7/+2
| | |
| * | update AR::Schema docs [ci skip]Carlos Duclos2012-12-011-1/+6
| | |
| * | Revert "Remove trailing whitespaces"Florent Guilleux2012-12-016-12/+12
| | | | | | | | | | | | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3.
| * | Remove trailing whitespacesFlorent Guilleux2012-12-016-12/+12
| | |
| * | Add documentation to TransactionIsolationError [ci skip]Florent Guilleux2012-12-011-0/+2
| | |
| * | remove unneeded Examples tag [ci skip]Carlos Duclos2012-12-011-10/+0
| | |
* | | pg_namespace table isn't used.kennyj2012-12-051-1/+0
| | |
* | | Do not instantiate intermediate AR objects when eager loading.Yves Senn2012-12-044-2/+26
| |/ |/| | | | | Closes #3313
* | Remove not used variable warnignsCarlos Antonio da Silva2012-12-012-5/+5
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-012-6/+16
|\ | | | | | | | | Conflicts: guides/source/active_record_validations.md
| * copy edits [ci skip]Vijay Dev2012-12-012-2/+2
| |
| * Fix Calculations#pluck doc to mention several attributes can be selected [ci ↵Florent Guilleux2012-12-011-3/+3
| | | | | | | | skip]
| * add documentation to CollectionProxy #length and #size methods [ci skip]Francesco Rodriguez2012-11-291-2/+7
| |
| * add documentation to CollectionProxy#empty?Francesco Rodriguez2012-11-291-1/+6
| |
* | Remove references to AR::Observer from docsclaudiob2012-11-301-11/+0
| | | | | | | | | | ActiveRecord::Observer was extracted into a separate gem so it should not be referenced anymore (see https://github.com/rails/rails/commit/ccecab3)
* | Use separate Relation subclasses for each AR classJon Leighton2012-11-305-56/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At present, ActiveRecord::Delegation compiles delegation methods on a global basis. The compiled methods apply to all subsequent Relation instances. This creates several problems: 1) After Post.all.recent has been called, User.all.respond_to?(:recent) will be true, even if User.all.recent will actually raise an error due to no User.recent method existing. (See #8080.) 2) Depending on the AR class, the delegation should do different things. For example, if a Post.zip method exists, then Post.all.zip should call it. But this will then result in User.zip being called by a subsequent User.all.zip, even if User.zip does not exist, when in fact User.all.zip should call User.all.to_a.zip. (There are various variants of this problem.) We are creating these compiled delegations in order to avoid method missing and to avoid repeating logic on each invocation. One way of handling these issues is to add additional checks in various places to ensure we're doing the "right thing". However, this makes the compiled methods signficantly slower. In which case, there's almost no point in avoiding method_missing at all. (See #8127 for a proposed solution which takes this approach.) This is an alternative approach which involves creating a subclass of ActiveRecord::Relation for each AR class represented. So, with this patch, Post.all.class != User.all.class. This means that the delegations are compiled for and only apply to a single AR class. A compiled method for Post.all will not be invoked from User.all. This solves the above issues without incurring significant performance penalties. It's designed to be relatively seamless, however the downside is a bit of complexity and potentially confusion for a user who thinks that Post.all and User.all should be instances of the same class. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' connection.create_table :posts def self.omg :omg end end relation = Post.all Benchmark.ips do |r| r.report('delegation') { relation.omg } r.report('constructing') { Post.all } end Before ------ Calculating ------------------------------------- delegation 4392 i/100ms constructing 4780 i/100ms ------------------------------------------------- delegation 144235.9 (±27.7%) i/s - 663192 in 5.038075s constructing 182015.5 (±21.2%) i/s - 850840 in 5.005364s After ----- Calculating ------------------------------------- delegation 6677 i/100ms constructing 6260 i/100ms ------------------------------------------------- delegation 166828.2 (±34.2%) i/s - 754501 in 5.001430s constructing 116575.5 (±18.6%) i/s - 563400 in 5.036690s Comments -------- Bear in mind that the standard deviations in the above are huge, so we can't compare the numbers too directly. However, we can conclude that Relation construction has become a little slower (as we'd expect), but not by a huge huge amount, and we can still construct a large number of Relations quite quickly.
* | Fix memory leak in development modeJon Leighton2012-11-302-15/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keying these hashes by klass causes reloadable classes to never get freed. Thanks to @thedarkone for pointing this out in the comments on 221571beb6b4bb7437989bdefaf421f993ab6002. This doesn't seem to make a massive difference to performance. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' end GC.disable Benchmark.ips(20) do |r| r.report { Post.connection } end Before ------ Calculating ------------------------------------- 5632 i/100ms ------------------------------------------------- 218671.0 (±1.9%) i/s - 4364800 in 19.969401s After ----- Calculating ------------------------------------- 8743 i/100ms ------------------------------------------------- 206525.9 (±17.8%) i/s - 4039266 in 19.992590s
* | Mark Relation mutators as :nodoc:Jon Leighton2012-11-302-48/+23
| | | | | | | | | | These are for internal use only and cannot be relied on as part of the public API. See discussion on 8c2c60511beaad05a218e73c4918ab89fb1804f0.
* | Revert "Fix annoy warning, when executing testcase."Andrey Deryabin2012-11-302-13/+0
| | | | | | | | | | | | This reverts commit a3024f81228d7b3b446408114a5dc2a86870cd35. REASON: Since warning doesn't exist
* | Move instantiation responsibilities from Inheritance to Persistence. Have ↵Jeremy Kemper2012-11-292-24/+50
| | | | | | | | Inheritance#discriminate_class_for_record handle STI lookup duties.
* | User assert_kind_of, invert assert_equal expectationsCarlos Antonio da Silva2012-11-294-12/+12
| |
* | Added STI support to init and building associationsJason Rush2012-11-2911-1/+163
| | | | | | | | | | | | | | | | Allows you to do BaseClass.new(:type => "SubClass") as well as parent.children.build(:type => "SubClass") or parent.build_child to initialize an STI subclass. Ensures that the class name is a valid class and that it is in the ancestors of the super class that the association is expecting.
* | Add CHANGELOG entries for the observes extractionRafael Mendonça França2012-11-291-0/+4
| | | | | | | | [ci skip]
* | Fix typo in the Observers deprecation message. [ci skip]Lucas Mazza2012-11-281-1/+1
| |
* | Gracefully handle upgrading apps with observersRafael Mendonça França2012-11-281-0/+12
| | | | | | | | | | | | Rather than just raising a NoMethodError when copying the config, this commit adds a warning message until either the rails-observers gem is installed or the relevant config options are removed.
* | Remove observers and sweepersRafael Mendonça França2012-11-2811-503/+5
| | | | | | | | | | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik]
* | Ensure that associations have a symbol argument.Steve Klabnik2012-11-283-0/+12
| | | | | | | | Fixes #7418.
* | Fix some indentation in the postgresql_specific_schemaRafael Mendonça França2012-11-281-9/+9
| |
* | Add comment to a table without model.Rafael Mendonça França2012-11-281-0/+1
| | | | | | | | | | This table is being used to verify if the :limit options is being ignored for text and binary columns
* | Use assert_nil instead of assert_equalRafael Mendonça França2012-11-282-3/+3
| |
* | Use "refute" instead of "assert !"Carlos Antonio da Silva2012-11-271-6/+5
| | | | | | | | Remove FIXME tag from abstract adapter test.
* | Remove useless check of AR being defined from teardown fixturesCarlos Antonio da Silva2012-11-271-5/+4
| | | | | | | | | | | | | | We are already in the AR namespace, there's no way for it to be undefined. See the cousin commit 13e72db77063f57c3028a906690d42fb068845bb Refactor a bit teardown fixtures to avoid two conditionals.
* | Merge pull request #8319 from alindeman/typoCarlos Antonio da Silva2012-11-261-1/+1
|\ \ | | | | | | Corrects typo in test name [ci skip]
| * | Corrects typo in test nameAndy Lindeman2012-11-261-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 07:59:45 +0000