aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Add `columns_for_distinct` for MySQL 5.7 with ONLY_FULL_GROUP_BYRyuta Kamizono2015-12-233-2/+62
| | | | | | | | | In MySQL 5.7.5 and up, ONLY_FULL_GROUP_BY affects handling of queries that use DISTINCT and ORDER BY. It requires the ORDER BY columns in the select list for distinct queries, and requires that the ORDER BY include the distinct column. See https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html
* Avoid `distinct` if a subquery has already materializedRyuta Kamizono2015-12-231-3/+5
| | | | Follow up to #19359 and avoid #22241.
* Fix ↵Ryuta Kamizono2015-12-193-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` to NULL-agnostic way The sort order of NULL depends on the RDBS implementation. This commit is to fix the test to NULL-agnostic way. Example: ``` activerecord_unittest=# SELECT DISTINCT "posts"."id", author_addresses_authors.id AS alias_0 FROM "posts" LEFT OUTER JOIN "authors" ON "authors"."id" = "posts"."author_id" LEFT OUTER JOIN "author_addresses" ON "author_addresses"."id" = "authors"."author_address_id" LEFT OUTER JOIN "categorizations" ON "categorizations"."category_id" = "posts"."id" LEFT OUTER JOIN "authors" "authors_posts" ON "authors_posts"."id" = "categorizations"."author_id" LEFT OUTER JOIN "author_addresses" "author_addresses_authors" ON "author_addresses_authors"."id" = "authors_posts"."author_address_id" ORDER BY author_addresses_authors.id DESC; id | alias_0 ----+--------- 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 1 | 1 (12 rows) ``` ``` root@localhost [activerecord_unittest] > SELECT DISTINCT `posts`.`id`, author_addresses_authors.id AS alias_0 FROM `posts` LEFT OUTER JOIN `authors` ON `authors`.`id` = `posts`.`author_id` LEFT OUTER JOIN `author_addresses` ON `author_addresses`.`id` = `authors`.`author_address_id` LEFT OUTER JOIN `categorizations` ON `categorizations`.`category_id` = `posts`.`id` LEFT OUTER JOIN `authors` `authors_posts` ON `authors_posts`.`id` = `categorizations`.`author_id` LEFT OUTER JOIN `author_addresses` `author_addresses_authors` ON `author_addresses_authors`.`id` = `authors_posts`.`author_address_id` ORDER BY author_addresses_authors.id DESC; +----+---------+ | id | alias_0 | +----+---------+ | 1 | 1 | | 3 | NULL | | 1 | NULL | | 2 | NULL | | 4 | NULL | | 5 | NULL | | 6 | NULL | | 7 | NULL | | 8 | NULL | | 9 | NULL | | 10 | NULL | | 11 | NULL | +----+---------+ 12 rows in set (0.00 sec) ```
* Merge pull request #19423 from ↵Aaron Patterson2015-12-182-2/+13
|\ | | | | | | | | yuroyoro/fix_performance_regression_of_preloading_has_many_through_relation Fix #12537 performance regression when preloading has_many_through association
| * Read already loaded association records from association.targetTomohito Ozaki2015-04-172-2/+13
| | | | | | | | | | For performance, Avoid instantiate CollectionProxy. Fixes #12537
* | Fix typo in CHANGELOGJan2015-12-181-1/+1
| |
* | Add CHANGELOG headers for Rails 5.0.0.beta1eileencodes2015-12-181-0/+5
| |
* | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | :tada: :beers:
* | Merge pull request #22658 from greysteil/handle-specified-schema-in-index-removeMatthew Draper2015-12-192-3/+30
|\ \ | | | | | | Handle specified schemas when removing a Postgres index
| * | Handle specified schemas when removing a Postgres indexGrey Baker2015-12-182-3/+30
| | |
* | | Refer to rails command instead of rake in a bunch of placesDavid Heinemeier Hansson2015-12-185-11/+11
|/ / | | | | | | Still more to do. Please assist!
* | Merge pull request #22653 from matthewd/find_array_orderedMatthew Draper2015-12-184-2/+100
|\ \ | | | | | | | | | ActiveRecord::Base#find(array) returning result in the same order as the array passed
| * | Implement limit & offset for ourselvesMatthew Draper2015-12-182-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We know the query will return exactly one row for each entry in the `ids` array, so we can do all the limit/offset calculations on that array, in advance. I also split our new ordered-ids behaviour out of the existing `find_some` method: especially with this change, the conditionals were overwhelming the actual logic.
| * | Adding a new test using chained where, limit and find([pks])Miguel Grazziotin2015-08-071-2/+12
| | |
| * | using order_values method instead of relying on ActiveRecord::Relation ↵Miguel Grazziotin2015-06-191-2/+2
| | | | | | | | | | | | @values hash
| * | WIP: fixing the limit bug and introducing new tests (failing for now) on ↵Miguel Grazziotin2015-06-192-7/+30
| | | | | | | | | | | | .find(array) with offset
| * | do not change the order of the result if the object was already ordered by ↵Miguel Grazziotin2015-06-052-0/+6
| | | | | | | | | | | | the user via :order clause
| * | adding a test to ensure the find is obbeying the limitMiguel Grazziotin2015-06-031-0/+7
| | |
| * | [#20338] adding tests to ensure the order clause takes precedenceMiguel Grazziotin2015-06-031-0/+18
| | |
| * | [#20338] improving implementation, fixing and adding some more specsMiguel Grazziotin2015-06-032-6/+4
| | |
| * | [#20338] WIP: first basic implementation and specsMiguel Grazziotin2015-05-292-1/+17
| | |
* | | These limits are now implicitMatthew Draper2015-12-182-2/+2
| | |
* | | Merge pull request #20815 from ↵Matthew Draper2015-12-183-3/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | byroot/do-not-include-column-limit-if-it-is-default Do not include column limit in schema.rb if it matches the default
| * | | Do not include column limit in schema.rb if it matches the defaultJean Boussier2015-07-082-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working on engines that supports multiple databases, it's very annoying to have a different schema.rb output based on which database you use. MySQL being the primary offender. This patch should reduce the disparities a bit.
* | | | Merge pull request #22623 from greysteil/support-passing-schema-name-to-indexesMatthew Draper2015-12-183-9/+24
|\ \ \ \ | | | | | | | | | | | | | | | Support passing the schema name prefix to `conenction.indexes`
| * | | | Support passing the schema name prefix to `conenction.indexes`Grey Baker2015-12-173-9/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support passing the schema name as a prefix to table name in `ConnectionAdapters::SchemaStatements#indexes`. Previously the prefix would be considered a full part of the index name, and only the schema in the current search path would be considered.
* | | | | Merge pull request #19456 from greysteil/index-exists-behaviourMatthew Draper2015-12-187-20/+126
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Ignore index name in `index_exists?` when not passed a name to check for
| * | | | | Support removing custom-names indexes when only specifying column namesGrey Baker2015-12-156-18/+107
| | | | | |
| * | | | | Ignore index name in `index_exists?` when not passed a name to check forGrey Baker2015-12-154-2/+19
| | | | | |
* | | | | | Merge pull request #22642 from seuros/remove-mysql-adapterMatthew Draper2015-12-1851-1723/+61
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Remove legacy mysql adapter
| * | | | | | Remove legacy mysql adapterAbdelkader Boudih2015-12-1750-1723/+56
| | | | | | |
* | | | | | | Use released arelRafael Mendonça França2015-12-171-1/+1
| | | | | | |
* | | | | | | Expanding the documentation for collection=objects for has_many :through ↵Eric Krause2015-12-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci-skip]
* | | | | | | Call the new point behavior `:point`, not `:rails_5_1_point`Sean Griffin2015-12-173-7/+6
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Since the attributes API is new in Rails 5, we don't actually need to keep the behavior of `attribute :point`, as it's not a breaking change.
* | / / / / Pass over the ApplicationRecord changelog entryGenadi Samokovarov2015-12-171-10/+5
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changelog entry for ApplicationRecord was a bit confusing. Thank you guys for helping me get it in a better shape. [ci skip]
* | | | | fix typo in method name [ci skip]yuuji.yaginuma2015-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | It was changed by mistake at 428d47adfed8d6aa7b21aec2bf5ad890961c9de3
* | | | | Revert "Merge pull request #22615 from ↵Rafael Mendonça França2015-12-173-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/join_to_delete_is_same_as_join_to_update" This reverts commit 4d06ea9a829de8f6f5a345589828e182eacab6a3, reversing changes made to e9d15072a94e2ae4dec5b7a121c84a5db38547b8. Reason: This will break oracle-enhanced, see https://github.com/rsim/oracle-enhanced/blob/3c42131db82b64ac41645db3affc6e4650289df6/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L1254
* | | | | Merge pull request #22615 from kamipo/join_to_delete_is_same_as_join_to_updateRafael França2015-12-173-11/+5
|\ \ \ \ \ | | | | | | | | | | | | `join_to_delete` is same as `join_to_update`
| * | | | | `join_to_delete` is same as `join_to_update`Ryuta Kamizono2015-12-173-11/+5
| | | | | |
* | | | | | Make sure File.exist? run in the root of the applicationRafael Mendonça França2015-12-161-1/+5
| | | | | |
* | | | | | Do not define attributes_with_index as a Thor taskRafael Mendonça França2015-12-161-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All public methods are tasks, so we need to move it to protected visibility.
* | | | | | Remove dead codeRafael Mendonça França2015-12-161-4/+0
| | | | | |
* | | | | | Don't over-specify types in our testsSean Griffin2015-12-161-1/+0
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test was failing when run on Windows using PostgreSQL. Depending on the OS (and 32 vs 64 bit), this type could be a `BigNum`. We could loosen the assertion to `Numeric`, but if the value is equal to the expected, and responds to `bitlength` properly, who cares?
* | | | | Fix test failures on WindowsSean Griffin2015-12-161-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike unix, the TZ variable on Windows does not look at a database. It is always expected to be in the form {Standard Time Abbreviation}{UTC-Offset}{Daylight Time Abbriviation}. This changes the relevant tests to use the Windows form when run from Windows.
* | | | | Fix test failure on WindowsSean Griffin2015-12-161-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
* | | | | Merge pull request #22567 from gsamokovarov/introduce-application-recordRafael França2015-12-162-1/+23
|\ \ \ \ \ | | | | | | | | | | | | Introduce ApplicationRecord, an Active Record layer supertype
| * | | | | Introduce ApplicationRecord, an Active Record layer supertypeGenadi Samokovarov2015-12-162-1/+23
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.
* | | | | Merge pull request #22605 from tonyta/delete-dead-commentsRafael França2015-12-161-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Delete dead code comments
| * | | | | deletes commented code introduced in db045db (initial commit)Tony Ta2015-12-151-1/+0
| | | | | |
* | | | | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-162-16/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Deprecate passing string to define callback.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-14 03:54:22 +0000