aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Prevent shadowing outer local variable.Emilio Tagua2010-09-271-3/+3
|
* third parameter is not usedAaron Patterson2010-09-261-1/+1
|
* db:structure:dump should list current Rails.env adapter in errors, not ↵Nic Benders2010-09-261-1/+1
| | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix remove_index issue when provided :name is a symbolTim Connor2010-09-262-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add namespacing for observer generatorPiotr Sarnacki2010-09-251-0/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators fix: properly check if module should be created when creating a ↵Piotr Sarnacki2010-09-251-1/+1
| | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com>
* Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵Marcelo Giorgi2010-09-242-1/+7
| | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved]Brian Candler2010-09-241-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactor namespaced generators to use module_namespacing block helperPiotr Sarnacki2010-09-243-2/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators are not aware of namespace of isolated engines and applicationsPiotr Sarnacki2010-09-241-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* restore behavior of touch for models without :updated_xx [#5439 state:resolved]tnp2010-09-242-8/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* reject_id option should be respected while using nested_attributesNeeraj Singh2010-09-242-3/+12
| | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Hash#to_s behaves differently between 1.8 and 1.9, so adjust accordinglyAaron Patterson2010-09-231-1/+1
|
* switch present in favor of emptyAaron Patterson2010-09-221-1/+1
|
* testing poor behavior of hash serializationAaron Patterson2010-09-221-0/+4
|
* Refactor association_collection uniq method.Emilio Tagua2010-09-221-4/+3
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to use inject here.Emilio Tagua2010-09-221-5/+5
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Perf: refactor method.Emilio Tagua2010-09-221-11/+8
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to use inject here, use map instead.Emilio Tagua2010-09-221-4/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Goodbye inject, hello map.Emilio Tagua2010-09-221-7/+5
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use map instead inject.Emilio Tagua2010-09-221-4/+3
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Missing the mysql2 gem hereSantiago Pastorino2010-09-221-1/+1
|
* Error message should advice to use 'mysql2' gem.Neeraj Singh2010-09-221-2/+2
| | | | | | | | | | | | | If I create a new app using command rails new demo -d mysql then Gemfile contains 'mysql2' gem by default. However if mysql gem is missing then error message says raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'" [#5569 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* avoid a proc objectAaron Patterson2010-09-221-1/+1
|
* avoid creating a range objectAaron Patterson2010-09-221-1/+1
|
* drying up construct_associationAaron Patterson2010-09-211-15/+15
|
* dry up some conditionalsAaron Patterson2010-09-211-3/+4
|
* fixing case / when indentationAaron Patterson2010-09-211-19/+19
|
* fix case / when indentationAaron Patterson2010-09-211-18/+18
|
* avoid a hash lookupAaron Patterson2010-09-211-2/+2
|
* remove more codesAaron Patterson2010-09-211-6/+4
|
* deleting more codeAaron Patterson2010-09-211-4/+1
|
* use each properly to avoid splatting a variableAaron Patterson2010-09-211-2/+1
|
* deleting repeated codesAaron Patterson2010-09-211-13/+10
|
* do not pass nil values to arelAaron Patterson2010-09-211-1/+1
|
* refacoring duplicate code. <3 <3 <3Aaron Patterson2010-09-211-2/+3
|
* this reject can be replaced with compactAaron Patterson2010-09-211-1/+1
|
* removing unused codeAaron Patterson2010-09-211-2/+1
|
* remove some repeated codeAaron Patterson2010-09-211-2/+2
|
* break up giant methodAaron Patterson2010-09-211-62/+72
|
* removing lolinjectAaron Patterson2010-09-211-1/+1
|
* fixing tests. wooAaron Patterson2010-09-211-4/+7
|
* remove join table rows before removing owner row for habtm associations, ↵Hemant Kumar2010-09-212-2/+2
| | | | fixes#5674
* providing arel with column information when possible [#5392 state:resolved]Aaron Patterson2010-09-213-3/+29
|
* un-nodocs AR::BatchesXavier Noria2010-09-211-1/+1
|
* Remove helper methods that were moved to helper.rbEmilio Tagua2010-09-211-15/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Move helper methods to helper.rb. Make test not depend on local TZ to pass ↵Emilio Tagua2010-09-212-9/+27
| | | | | | or fail. Signed-off-by: José Valim <jose.valim@gmail.com>
* use instance_eval, reduce method calls.Stevie Graham2010-09-211-15/+7
| | | | | | | | | | | | | | | | execution time in seconds for `rake test_sqlite3`: ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0] - before: 52.771426, 52.159505, 52.937056 - after: 51.452584, 51.897017, 51.584431 rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0] - before: 284.334076 - after: 285.753028 ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0] - before: 75.811548, 75.533153, 75.353122 - after: 75.244243, 75.19226, 75.256925
* Add helper for loading seed data for engine and applicationPiotr Sarnacki2010-09-201-2/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Exception handling more readableThiago Pradi2010-09-192-6/+6
| | | | | | [#5601 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>