aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | push parent up to the superclassAaron Patterson2013-10-093-7/+11
| | | | | | | | | | | | We always want a linked list back to the root node.
| * | convert JoinBase to a tree and remove the Node classAaron Patterson2013-10-092-42/+30
| | |
| * | names are guaranteed to be symbolsAaron Patterson2013-10-081-1/+1
| | |
| * | eliminate function that is only used in one placeAaron Patterson2013-10-081-7/+2
| | |
| * | we will always detect the same node, so just pass the node inAaron Patterson2013-10-081-7/+2
| | |
| * | we do not need to to_s the name all the timeAaron Patterson2013-10-081-5/+3
| | |
| * | parent is guaranteed to be the sameAaron Patterson2013-10-081-4/+1
| | | | | | | | | | | | | | | since we are searching a tree, the current level should be consistent, so we don't have to inspect the parent class / table
| * | reduce number of comparisons and array allocationsAaron Patterson2013-10-081-11/+10
| | | | | | | | | | | | | | | Just inspecting the children nodes will reduce the number of comparisons we have to do (since it is limited to the child size)
| * | rename the variable to make more sense with a treeAaron Patterson2013-10-081-7/+7
| | |
| * | walk the tree rather than generating a hash and walking itAaron Patterson2013-10-081-21/+10
| | |
| * | do not convert the tree to a list just for the first nodeAaron Patterson2013-10-081-1/+1
| | |
| * | generate the association hash from the top downAaron Patterson2013-10-081-17/+15
| | | | | | | | | | | | | | | This prevents us from walking back up the parent tree once for each leaf.
| * | store join parts in a treeAaron Patterson2013-10-081-16/+45
| | |
* | | Using flat_map instead of map and flattenArun Agrawal2013-10-091-1/+1
| | | | | | | | | | | | | | | | | | original commit 8998441967a8cfc6e4302c29664ab9d0acd77704 Reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4
* | | Merge pull request #12473 from claudiob/document-after-touchYves Senn2013-10-092-2/+6
|\ \ \ | |_|/ |/| | Add documentation for after_touch [ci skip]
| * | Add documentation for after_touch [ci skip]claudiob2013-10-082-2/+6
| |/
* | :scissors:Rafael Mendonça França2013-10-092-2/+2
| |
* | Push define_accessors to class level since we don't need anythig fromRafael Mendonça França2013-10-083-8/+8
| | | | | | | | the instance
* | Use the reflection name instead of the accessorRafael Mendonça França2013-10-082-1/+2
| |
* | Move add_counter_cache_methods to class levelRafael Mendonça França2013-10-081-2/+2
| |
* | Move define_constructors to class levelRafael Mendonça França2013-10-081-3/+2
| |
* | Move define_writers to class level since we don't need anything from theRafael Mendonça França2013-10-082-3/+3
| | | | | | | | instance
* | Move define_readers to class method since it doesn't need nothing fromRafael Mendonça França2013-10-082-5/+3
| | | | | | | | the instance
* | Fix the indentationRafael Mendonça França2013-10-081-12/+13
|/
* join parts in `build` are *always* new, so don't bother checkingAaron Patterson2013-10-081-1/+2
|
* stop looking up the reflection multiple timesAaron Patterson2013-10-081-6/+5
|
* cache join associations and join base on the stackAaron Patterson2013-10-081-4/+11
| | | | No reason to decompose the join objects on every iteration
* use the API rather than accessing underlying data structuresAaron Patterson2013-10-081-1/+1
|
* associations is always a hashAaron Patterson2013-10-081-19/+13
|
* keys are always symbolsAaron Patterson2013-10-081-2/+4
|
* we can get a list of reflections from the join parts, so let's removeAaron Patterson2013-10-081-3/+5
| | | | the @reflections ivar.
* transform the association input so we can avoid type checks later.Aaron Patterson2013-10-081-17/+31
| | | | | We should consider moving the input munging outside the class instantiation
* we know the keys are scalars, so avoid some typecheckingAaron Patterson2013-10-081-8/+12
|
* this method is only ever called with a reflectionAaron Patterson2013-10-081-6/+2
| | | | Stop typechecking the parameter. We know the type.
* don't access the reflections hashAaron Patterson2013-10-082-3/+7
| | | | The reflections hash is supposed to be private, so let's use the API.
* build association tree thing on demand.Aaron Patterson2013-10-081-6/+11
| | | | | `instantiate` is only called once, so there is no reason to cache the data structure on the instance and mutate itself.
* hide join_parts internals from other classesAaron Patterson2013-10-082-17/+17
|
* decouple JoinAssociation from JoinDependencyAaron Patterson2013-10-082-10/+5
|
* @associations can never have an array, so remove the dead codeAaron Patterson2013-10-081-4/+0
|
* typecast records returned from the db rather than to_sing everythingAaron Patterson2013-10-082-12/+21
|
* extract the string handling part to a method.Aaron Patterson2013-10-071-15/+15
| | | | | | We know the structure passed in to the `construct` method will be a hash, so we don't need to test it all the time. The key value will be a symbol or string, so handle it with the special method
* remove more dead codeAaron Patterson2013-10-071-2/+0
| | | | | We control the inputs to `construct`, so the wrong type shouldn't be passed in ever.
* this code is never used, remove itAaron Patterson2013-10-071-4/+0
|
* log the statement name along with the SQLAaron Patterson2013-10-044-6/+20
|
* log every sql statement, even when they errorAaron Patterson2013-10-041-25/+25
|
* prepare the statement inside the begin / rescue blockAaron Patterson2013-10-041-4/+4
|
* rm LogIntercepterAaron Patterson2013-10-041-15/+0
|
* stop adding singleton methods to the SQLite3 connectionAaron Patterson2013-10-041-11/+11
|
* stop adding singleton methods to the mysql2 adapterAaron Patterson2013-10-043-22/+22
|
* stop adding singleton methods to the PG connectionAaron Patterson2013-10-041-11/+26
|