aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* don't apply invalid ordering when preloading hmt associations.Yves Senn2013-02-243-2/+13
| | | | | | | | | | | | | | | closes #8663. When preloading a hmt association there two possible scenarios: 1.) preload with 2 queries: first hm association, then hmt with id IN () 2.) preload with join: hmt association is loaded with a join on the hm association The bug was happening in scenario 1.) with a normal order clause on the hmt association. The ordering was also applied when loading the hm association, which resulted in the error. This patch only applies the ordering the the hm-relation if we are performing a join (2). Otherwise the order will only appear in the second query (1).
* Merge pull request #9400 from senny/remove_auto_explain_threshold_in_secondsXavier Noria2013-02-247-155/+39
|\ | | | | remove config.auto_explain_threshold_in_seconds
| * remove AR auto-explain (config.auto_explain_threshold_in_seconds)Yves Senn2013-02-247-155/+39
| | | | | | | | | | | | | | | | | | | | We discussed that the auto explain feature is rarely used. This PR removes only the automatic explain. You can still display the explain output for any given relation using `ActiveRecord::Relation#explain`. As a side-effect this should also fix the connection problem during asset compilation (#9385). The auto explain initializer in the `ActiveRecord::Railtie` forced a connection.
* | Updated doc to clarify about update_all and delete_allNeeraj Singh2013-02-241-2/+2
| | | | | | | | | | | | | | | | delete_all will call callbacks if depdent option is specified as :destroy. This behavior is not very clear from the documetation and hence issue #7832 was raised. closes #7832
* | Skip connection url test when the machine is using socket configuration.Rafael Mendonça França2013-02-241-0/+3
| | | | | | | | The connection url parssing don't accept the socket option
* | Do not type cast all the database url values.Rafael Mendonça França2013-02-248-56/+32
|/ | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c
* Merge pull request #9356 from senny/988_multiple_actions_for_after_commitSteve Klabnik2013-02-243-14/+60
|\ | | | | multiple actions for :on option with `after_commit` and `after_rollback`
| * multiple actions for :on option with `after_commit` and `after_rollback`Yves Senn2013-02-213-14/+60
| | | | | | | | Closes #988.
* | test case to prevent duplicated associations with custom PK.Yves Senn2013-02-242-0/+12
| | | | | | | | closes #9201
* | Oracle enhanced adapter shortens its name if it is longer than 30 bytesYasuo Honda2013-02-241-2/+10
| | | | | | | | because of Oracle database index length spec.
* | also rename the test-case class inside columns_test.rbYves Senn2013-02-241-1/+1
| |
* | adds a missing LIMIT 1 in #take docsXavier Noria2013-02-231-1/+1
| |
* | rename_column_test.rb -> columns_test.rb to reveal intent.Yves Senn2013-02-231-0/+0
| | | | | | | | | | | | | | | | I renamed the test to better communicate it's intention. Since it also tests: - add_column - remove_column - change_column There is no reason to call it rename_column_test.
* | forwardport #9388 rename/remove column preserves custom PK.Yves Senn2013-02-231-1/+15
|/
* Merge pull request #9348 from schuetzm/doc_no_indices_with_create_join_tableXavier Noria2013-02-211-0/+8
|\ | | | | Add more documentation for create_join_table.
| * Indent comment block by two spaces.Marc Schütz2013-02-211-4/+4
| | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417
| * Add more documentation for create_join_table.Marc Schütz2013-02-201-0/+8
| | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form.
* | Fix warningRafael Mendonça França2013-02-211-1/+1
|/
* ActiveRecord -> Active Record [ci skip]Xavier Noria2013-02-201-1/+1
|
* Merge pull request #9345 from ↵Rafael Mendonça França2013-02-201-10/+10
|\ | | | | | | | | wangjohn/change_name_of_query_method_argument_checker_for_clarity Renaming the check_empty_arguments method to something more descriptive.
| * Renaming the check_empty_arguments method to something more descriptive.wangjohn2013-02-201-10/+10
| | | | | | | | | | The function is now called has_arguments? so that it's easier to tell that it's just checking to see if the args are blank or not.
* | removes relation bang methods from the AR changelog [ci skip]Xavier Noria2013-02-201-12/+0
| |
* | removes some remaining relation bang methods documentation [ci skip]Xavier Noria2013-02-201-3/+0
| |
* | puts a lambda around a default scope [ci skip]Xavier Noria2013-02-201-1/+1
| |
* | adds an example in the docs of #not with multiple conditions [ci skip]Xavier Noria2013-02-201-4/+8
| |
* | database.yml -> config/database.yml [ci skip]Xavier Noria2013-02-201-1/+1
| |
* | Skip failing test and add a FIXME noteRafael Mendonça França2013-02-201-0/+2
| |
* | unify AR changelog entries [ci skip]Yves Senn2013-02-201-4/+4
| |
* | also rename indexes when a table or column is renamedYves Senn2013-02-207-8/+73
| | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* | moves the new :nsec date format to the Active Support changelog [ci skip]Xavier Noria2013-02-201-6/+1
| |
* | revises the documentation of AR::Base.cache_timestamp_format [ci skip]Xavier Noria2013-02-201-2/+4
|/
* reserve less chars for internal sqlite3 operationsYves Senn2013-02-201-7/+7
|
* reserve index name chars for internal rails operationsYves Senn2013-02-206-9/+64
| | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
* Merge pull request #9332 from ↵Rafael Mendonça França2013-02-203-15/+45
|\ | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors
| * Added comments about the check_empty_arguments method which is calledwangjohn2013-02-203-15/+45
| | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests.
* | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |/
* / Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-206-6/+89
|/ | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* standardize database_configuration to a hashTerence Lee2013-02-212-5/+3
| | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* Whitespace :heart: and hash syntax changeRafael Mendonça França2013-02-201-23/+22
|
* descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-203-3/+20
|
* s/revertible/reversible/Xavier Noria2013-02-191-1/+1
|
* Merge pull request #9315 from ↵Steve Klabnik2013-02-191-23/+0
|\ | | | | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb
| * delete duplicated tests in AR base_test.rbTakehiro Adachi2013-02-191-23/+0
| | | | | | | | These are duplicated with the tests which are in relations_test.rb
* | moves a CHANGELOG entry from AR to APXavier Noria2013-02-191-4/+0
| |
* | small tweaks in the AR CHANGELOGXavier Noria2013-02-191-4/+4
| |
* | Raise an error when query methods have blank arguments, and when blank ↵John J Wang2013-02-192-9/+34
| | | | | | | | arguments are meaningless.
* | Gist URLs are now namespacedAkira Matsuda2013-02-182-5/+5
|/ | | | see: https://github.com/blog/1406-namespaced-gists
* add tests for ActiveRecord::Base#createTakehiro Adachi2013-02-181-0/+8
|
* Add CHANGELOG entry for 41ff6a10216f48f43605a1f9cd6094765cab750fAndrew White2013-02-171-0/+40
| | | | [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-24 10:05:32 +0000