aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | push !loaded? conditional upAaron Patterson2011-01-141-10/+8
| |
* | return early in case the left or right side lists are emptyAaron Patterson2011-01-141-5/+4
| |
* | only find_target can raise the exception, so isolate the rescue around that callAaron Patterson2011-01-141-5/+9
| |
* | we always have a target, so stop checkingAaron Patterson2011-01-141-1/+1
| |
* | we should use [] instead of Array.newAaron Patterson2011-01-141-1/+1
| |
* | @target is always a list, so stop doing is_a? checksAaron Patterson2011-01-141-1/+1
| |
* | move complex logic to it's own methodAaron Patterson2011-01-141-15/+19
| |
* | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵Aaron Patterson2011-01-141-4/+4
| | | | | | | | inside the conditional
* | reduce funcalls by using falsey objectsAaron Patterson2011-01-141-2/+2
| |
* | write the delegate method directly to avoid `delegate` callstack overheadAaron Patterson2011-01-141-1/+5
| |
* | reduce some lasignsAaron Patterson2011-01-141-2/+1
| |
* | use rake to create test databases for usAaron Patterson2011-01-142-9/+9
| |
* | transactional fixtures must be set to false for this testAaron Patterson2011-01-141-1/+1
| |
* | Arel::Table.engine will be deprecated, so stop using itAaron Patterson2011-01-141-1/+1
| |
* | preheat the table cache in arelAaron Patterson2011-01-141-0/+1
| |
* | Add missing requireSantiago Pastorino2011-01-141-0/+1
| |
* | sorry, the CI cannot lie to us anymore (Part II)Santiago Pastorino2011-01-131-1/+1
| |
* | include_in_memory? should check against @target list in case of new records. ↵Aaron Patterson2011-01-122-2/+9
| | | | | | | | [#6257 state:resolved]
* | use array maths rather than *argsAaron Patterson2011-01-121-2/+4
| |
* | just use return value of load_targetAaron Patterson2011-01-121-2/+1
| |
* | just call methods on return value of `load_target`Aaron Patterson2011-01-121-8/+3
| |
* | default return value is nilAaron Patterson2011-01-121-1/+0
| |
* | @loaded is defined in initialize, so we should not need thisAaron Patterson2011-01-121-2/+0
| |
* | just use respond_to? and super rather than aliasing around methodsAaron Patterson2011-01-122-5/+4
| |
* | adding a test for no method errorAaron Patterson2011-01-112-11/+57
| |
* | use underlying _read_attribute method rather than causing NoMethodErrorsAaron Patterson2011-01-112-2/+2
| |
* | kill unused variable warningsAaron Patterson2011-01-111-1/+1
| |
* | lazily instantiate AR objects in order to avoid NoMethodErrorsAaron Patterson2011-01-112-17/+24
| |
* | test_with_polymorphic_and_condition works without the conditions methods in ↵Jon Leighton2011-01-111-5/+0
| | | | | | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago
* | Support for create_association! for has_one associationsJon Leighton2011-01-113-1/+23
| |
* | Refactor the code for singular association constructors. This will allow me ↵Jon Leighton2011-01-111-8/+13
| | | | | | | | to define a create_association! method in a minute.
* | It's not necessary to pass the association proxy class around nowJon Leighton2011-01-111-22/+15
| |
* | Get rid of set_association_target and association_loaded? as the parts of ↵Jon Leighton2011-01-115-21/+18
| | | | | | | | the code that need that can now just use association_proxy(:name).loaded?/target=
* | We can use the association_proxy method directly in HasOneThroughAssociation nowJon Leighton2011-01-112-20/+20
| |
* | DRY up the code which instantiates the association proxyJon Leighton2011-01-115-48/+60
| |
* | find_target can be inheritedJon Leighton2011-01-111-4/+0
| |
* | Document the recent changes to association assignmentJon Leighton2011-01-111-4/+9
| |
* | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-112-1/+18
| | | | | | | | replaced
* | When assigning a has_one, if anything fails, the assignment should be rolled ↵Jon Leighton2011-01-112-21/+28
| | | | | | | | back entirely
* | In a number of places in the tests, we only need to turn off transactional ↵Jon Leighton2011-01-119-43/+51
| | | | | | | | fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :)
* | SQLite3 has supported savepoints since version 3.6.8, we should use this!Jon Leighton2011-01-112-2/+18
| |
* | When assigning a has_one, if the new record fails to save, raise an errorJon Leighton2011-01-113-19/+19
| |
* | When assigning a has_one, if the existing record fails to be removed from ↵Jon Leighton2011-01-112-5/+23
| | | | | | | | the association, raise an error
* | Have a separate test connection directory for sqlite3 in-memory so that the ↵Jon Leighton2011-01-112-1/+1
| | | | | | | | tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes)
* | Enable the sqlite3 in-memory test connection to workJon Leighton2011-01-115-17/+25
| |
* | has_one should always remove the old record (properly), even if not saving ↵Jon Leighton2011-01-114-11/+31
| | | | | | | | the new record, so we don't get the database into a pickle
* | Return value is irrelevant here as the RHS of the assignment is always ↵Jon Leighton2011-01-111-1/+0
| | | | | | | | returned by methods ending in '='
* | Remove incorrect documentation about build_assoc on has_one. This is proven, ↵Jon Leighton2011-01-111-2/+1
| | | | | | | | for example, by test_successful_build_association in has_one_associations_test.rb
* | For a singular association, it should be build_association, rather than ↵Jon Leighton2011-01-111-1/+1
| | | | | | | | association.build (as association may be nil)
* | Correctly indent the bullet points under 'One-to-one associations', so that ↵Jon Leighton2011-01-111-10/+10
| | | | | | | | the lines are not broken in the generated rdoc html
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 22:07:59 +0000