aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #23677 from kamipo/passing_table_name_to_column_initializeRafael França2016-03-119-29/+58
|\ | | | | Passing `table_name` to `Column#initialize` to avoid `instance_variable_set`
| * Passing `table_name` to `Column#initialize` to avoid `instance_variable_set`Ryuta Kamizono2016-03-085-17/+11
| |
| * Initialize `column.table_name` immediately for `column.serial?` correctly ↵Ryuta Kamizono2016-03-088-21/+56
| | | | | | | | | | | | | | | | working Currently the results of `column.serial?` is not correct. For `column.serial?` correctly working, initialize `column.table_name` immediately.
* | Merge pull request #23958 from kamipo/fix_bigserial_appears_with_limit_8Rafael França2016-03-112-2/+6
|\ \ | | | | | | Fix bigserial appears with limit 8 for schema dumper
| * | Fix bigserial appears with limit 8 for schema dumperRyuta Kamizono2016-03-042-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ```ruby create_table "postgresql_big_serials", force: :cascade do |t| t.bigserial "seq", limit: 8, null: false end ``` After: ```ruby create_table "postgresql_big_serials", force: :cascade do |t| t.bigserial "seq", null: false end ```
* | | Fixed comments of add_foreign_key methodSalman Afzal Siddiqui2016-03-101-2/+2
| | | | | | | | | The comments of add_foreign_key method was displaying incorrect constraint name.
* | | revises the homepage URL in the gemspecs [ci skip]Xavier Noria2016-03-101-1/+1
| | | | | | | | | | | | References https://github.com/rails/homepage/issues/46.
* | | use same name to type objectyuuji.yaginuma2016-03-091-1/+1
| | | | | | | | | | | | Follow up to #24079
* | | Merge pull request #23666 from meinac/fix_abstract_default_scope_bugSean Griffin2016-03-085-1/+38
|\ \ \ | | | | | | | | Execute default_scope defined by abstract class within the scope of subclass
| * | | Execute default_scope defined by abstract class within the scope of subclassMehmet Emin İNAÇ2016-03-085-1/+38
| | |/ | |/|
* / | add test case for schema dumping of PG bytea columns.Yves Senn2016-03-081-0/+9
|/ /
* | Merge pull request #24034 from kamipo/remove_outdated_commentArthur Nogueira Neves2016-03-071-1/+0
|\ \ | | | | | | Remove outdated comment [ci skip]
| * | Remove outdated comment [ci skip]Ryuta Kamizono2016-03-041-1/+0
| |/ | | | | | | Currently column options handled by the type map in Rails 4.2.
* | Add changelog for batch touch records.Arthur Neves2016-03-071-0/+15
| | | | | | | | | | | | related to #19324 and #18606 [skip ci]
* | move changelog to right place [skip ci]Arthur Neves2016-03-071-6/+6
| |
* | Add changelog for #20997Arthur Neves2016-03-071-0/+6
| |
* | Merge pull request #23922 from rthbound/fix-funny-spellingArthur Nogueira Neves2016-03-071-2/+2
|\ \ | | | | | | Fixes funny spelling in an AR test
| * | Fixes funny spellingRyan T. Hosford2016-02-261-2/+2
| | | | | | | | | | | | - marked_for_destroyal -> marked_for_destruction
* | | Merge pull request #23993 from kamipo/no_need_to_extract_limit_for_booleanSean Griffin2016-03-072-5/+1
|\ \ \ | | | | | | | | No need to extract a limit for a boolean type
| * | | No need to extract a limit for a boolean typeRyuta Kamizono2016-03-042-5/+1
| | | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-03-061-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/association_basics.md
| * | | | [ci skip] Fix `'id'` to be fixed-width fontyui-knk2016-02-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As shown below, we should use <tt>...</tt> for string literal ``` $ echo "+'id'+" | rdoc --pipe <p>+&#39;id&#39;+</p> $ echo "<tt>'id'</tt>" | rdoc --pipe <p><code>&#39;id&#39;</code></p> ```
* | | | | This code won't workAkira Matsuda2016-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Fix typo `--ssl-cipher`Ryuta Kamizono2016-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | Follow up to #22543.
* | | | | Merge pull request #24079 from y-yagi/chage_date_time_to_datetimeSean Griffin2016-03-051-1/+1
|\ \ \ \ \ | | | | | | | | | | | | chage `date_time` type ` to `datetime`
| * | | | | chage `date_time` type ` to `datetime`yuuji.yaginuma2016-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since we are using `datetime` in migration, better to use `datetime` is I think that confusion is less.
* | | | | | make attributes API example to work [ci skip]yuuji.yaginuma2016-03-061-2/+2
|/ / / / / | | | | | | | | | | | | | | | There is a need to pass the keyword arguments to `attribute` method.
* | | | | fix typo in attribute example [ci skip]yuuji.yaginuma2016-03-051-1/+1
| | | | |
* | | | | A small documentation fix about autosave associations [ci skip]Mehmet Emin İNAÇ2016-03-051-1/+1
| | | | |
* | | | | remove outdated comment [ci skip]yuuji.yaginuma2016-03-051-6/+0
| | | | | | | | | | | | | | | | | | | | Currently use minitest mock, mocha is not used.
* | | | | start hiding the `scope_chain` data structureAaron Patterson2016-03-042-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Introduce a predicate method that doesn't need to build a scope chain, but also hides the data structure used for representing the scope chain.
* | | | | don't build the reflection chain to calculate `nested?`Aaron Patterson2016-03-041-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We know a reflection can be considered as `nested?` if the source reflection or the through reflection are also through reflections (since the through reflection will also add another join table). This allows us to avoid traversing the entire reflection tree just to calculate whether or not there will be more join tables.
* | | | | remove useless ivarAaron Patterson2016-03-041-1/+0
| |_|_|/ |/| | |
* | | | don't treat all associations with extensions as instance dependent.Yves Senn2016-03-034-1/+33
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Closes #23934. This is a forward port of ac832a43b4d026dbad28fed196d2de69ec9928ac Previously the scope of all associations with extensions were wrapped in an instance dependent proc. This made it impossible to preload such associations.
* | | Fix a small template misrender in ActiveRecord::PersistenceGenadi Samokovarov2016-03-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | See the end of [this] page. [ci skip] [this]: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Persistence/ClassMethods.html#method-i-create
* | | Merge pull request #23086 from kamipo/deprecate_insert_update_delete_sqlRafael França2016-03-025-60/+17
|\ \ \ | | | | | | | | Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`
| * | | Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`Ryuta Kamizono2016-03-025-60/+17
| | | | | | | | | | | | | | | | | | | | Originally, `{insert|update|delete}_sql` is protected methods. We can use the `{insert|update|delete}` public methods instead.
* | | | [ci skip] Add `bundle exec` for ActiveRecord unit testsYasuo Honda2016-03-021-3/+3
| | | |
* | | | remove trailing whitespace.Yves Senn2016-03-021-1/+1
| | | |
* | | | Remove not needed `exec_insert` in mysql2 adapterRyuta Kamizono2016-03-021-4/+0
|/ / / | | | | | | | | | Simply it is sufficient to use the method in the super class.
* | | Merge pull request #23932 from arthurnn/arthurnn/remove_load_pathsArthur Nogueira Neves2016-03-013-4/+0
|\ \ \ | | | | | | | | Remove load_paths file
| * | | Remove load_paths fileArthur Neves2016-02-273-4/+0
| | | |
* | | | Remove duplicated `test_` prefix [ci skip]Ryuta Kamizono2016-03-021-1/+1
| | | |
* | | | Merge pull request #23959 from kamipo/add_test_primary_key_should_be_not_nullRafael França2016-03-011-3/+4
|\ \ \ \ | | | | | | | | | | Add a test for primary key should be not null
| * | | | Add a test for primary key should be not nullRyuta Kamizono2016-02-291-3/+4
| |/ / /
* | | | Merge pull request #23961 from ↵Rafael França2016-03-013-8/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/exclude_name_and_type_from_prepare_column_options Exclude `:name` and `:type` from `prepare_column_options`
| * | | | Exclude `:name` and `:type` from `prepare_column_options`Ryuta Kamizono2016-02-293-8/+8
| |/ / / | | | | | | | | | | | | Actually `:name` and `:type` are not column options.
* | | | Merge pull request #23953 from ↵Rafael França2016-03-0112-136/+96
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/fix_tests_failure_with_prepared_statements_false Fix tests failure with `prepared_statements: false`
| * | | | Remove unnecessary namespaces in `explain_test.rb`Ryuta Kamizono2016-02-293-40/+28
| | | | |
| * | | | Fix tests failure with `prepared_statements: false`Ryuta Kamizono2016-02-2910-97/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tests does not work for unprepared statements. Add `if ActiveRecord::Base.connection.prepared_statements` and fix a regex for fix tests failure with `prepared_statements: false`.