Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | has_one should always remove the old record (properly), even if not saving ↵ | Jon Leighton | 2011-01-11 | 4 | -11/+31 |
| | | | | the new record, so we don't get the database into a pickle | ||||
* | Return value is irrelevant here as the RHS of the assignment is always ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+0 |
| | | | | returned by methods ending in '=' | ||||
* | Remove incorrect documentation about build_assoc on has_one. This is proven, ↵ | Jon Leighton | 2011-01-11 | 1 | -2/+1 |
| | | | | for example, by test_successful_build_association in has_one_associations_test.rb | ||||
* | For a singular association, it should be build_association, rather than ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 |
| | | | | association.build (as association may be nil) | ||||
* | Correctly indent the bullet points under 'One-to-one associations', so that ↵ | Jon Leighton | 2011-01-11 | 1 | -10/+10 |
| | | | | the lines are not broken in the generated rdoc html | ||||
* | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 |
| | |||||
* | Fix polymorphic belongs_to associationproxy raising errors when loading target. | Ernie Miller | 2011-01-11 | 3 | -0/+16 |
| | |||||
* | only use one array when collecting split up queries | Aaron Patterson | 2011-01-10 | 1 | -1/+1 |
| | |||||
* | Always return decimal average of integer fields | Raimonds Simanovskis | 2011-01-10 | 2 | -9/+10 |
| | | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done. | ||||
* | use SQLite3::VERSION rather than the deprecated class | Aaron Patterson | 2011-01-10 | 1 | -1/+1 |
| | |||||
* | Aligning master changelog w/ 3-0-stable | Kevin Moore | 2011-01-09 | 1 | -1/+9 |
| | |||||
* | Adding postgresql template option when executing db:test:clone_structure | Katrina Owen | 2011-01-09 | 1 | -1/+1 |
| | | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1 | ||||
* | remove unused string substitution | Aaron Patterson | 2011-01-08 | 1 | -6/+1 |
| | |||||
* | use select_all because not all database adapters support bind values | Aaron Patterson | 2011-01-08 | 1 | -1/+1 |
| | |||||
* | join the cult of cargo. reduce the number of NoMethodErrors in the system | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | stop creating intermediate AR objects, just construct AR objects from a list ↵ | Aaron Patterson | 2011-01-07 | 1 | -1/+2 |
| | | | | of hashes | ||||
* | no need for to_sym | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | String#insert() mutates the string, so no need for lasgn | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | fewer funcalls to the cached attributes variable | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | Add test for e0e3adf | Jeremy Kemper | 2011-01-07 | 1 | -0/+6 |
| | |||||
* | Refactor HasOneAssociation#replace | Jon Leighton | 2011-01-07 | 1 | -26/+22 |
| | |||||
* | Don't not remove double negatives | Jon Leighton | 2011-01-07 | 2 | -5/+5 |
| | |||||
* | Clean up create, create! and build in HasOneAssociation | Jon Leighton | 2011-01-07 | 1 | -14/+8 |
| | |||||
* | merge_with_conditions is not necessary because the conditions will already ↵ | Jon Leighton | 2011-01-07 | 1 | -9/+0 |
| | | | | be in the scope_for_create hash in the scope | ||||
* | Not really worth having the HasAssociation module for just a single method | Jon Leighton | 2011-01-07 | 5 | -21/+9 |
| | |||||
* | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 12 | -125/+76 |
| | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | ||||
* | Use encode_with for marshalling | Jon Leighton | 2011-01-07 | 2 | -0/+27 |
| | |||||
* | send() will raise an ArgumentError, so we should leverage ruby | Aaron Patterson | 2011-01-07 | 2 | -17/+7 |
| | |||||
* | no need for parens | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | use a hash for caching aggregations rather than ivars | Aaron Patterson | 2011-01-07 | 2 | -14/+9 |
| | |||||
* | method is never called with arguments | Aaron Patterson | 2011-01-07 | 1 | -4/+2 |
| | |||||
* | only rescue from Mysql::Error exceptions [#6236 state:resolved] | Aaron Patterson | 2011-01-07 | 1 | -4/+9 |
| | |||||
* | just use a hash for doing association caching | Aaron Patterson | 2011-01-07 | 6 | -15/+17 |
| | |||||
* | no need for self | Aaron Patterson | 2011-01-06 | 1 | -1/+1 |
| | |||||
* | adding an `encode_with` method for Psych dump/load methods | Aaron Patterson | 2011-01-05 | 2 | -0/+23 |
| | |||||
* | make sure new objects can round trip | Aaron Patterson | 2011-01-05 | 1 | -0/+6 |
| | |||||
* | make sure that Psych can roundtrip an AR object | Aaron Patterson | 2011-01-05 | 1 | -0/+13 |
| | |||||
* | AR internals expect a normal hash, otherwise there are serialization ↵ | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | | | | incompatibilities | ||||
* | no need to specify self | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | no need to send a symbol to send() | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | avoid creating so many Arel::Table objects | Aaron Patterson | 2011-01-05 | 1 | -6/+9 |
| | |||||
* | use attr_reader and alias methods to access instance variables | Aaron Patterson | 2011-01-05 | 1 | -8/+4 |
| | |||||
* | we have a method for this, so let's use it | Aaron Patterson | 2011-01-05 | 1 | -2/+2 |
| | |||||
* | use arel ast construction rather than generating strings | Aaron Patterson | 2011-01-05 | 1 | -1/+7 |
| | |||||
* | use arel to construct AST rather than generate strings | Aaron Patterson | 2011-01-05 | 1 | -2/+3 |
| | |||||
* | fixing merge errors | Aaron Patterson | 2011-01-04 | 2 | -78/+0 |
| | |||||
* | Merge remote branch 'rsim/require_deprecation' | Aaron Patterson | 2011-01-04 | 1 | -0/+2 |
|\ | | | | | | | | | * rsim/require_deprecation: require ActiveSupport deprecatation file before using deprecate method in database_statements | ||||
| * | require ActiveSupport deprecatation file before using deprecate method in ↵ | Raimonds Simanovskis | 2011-01-04 | 1 | -0/+2 |
| | | | | | | | | | | database_statements otherwise when using external ActiveRecord adapters (e.g. Oracle) database_statements might be loaded before active_support/core_ext/module/deprecation which results in NoMethodError (commit 60cf65def805995bcca184c40b44bb01d86a48aa added "deprecate" call to database_statements.rb) | ||||
* | | Merge remote branch 'rsim/habtm_select_fix' | Aaron Patterson | 2011-01-04 | 2 | -2/+3 |
|\ \ | | | | | | | | | | | | | * rsim/habtm_select_fix: Explicitly select * from has_and_belongs_to_many association tables, simplify exists? query | ||||
| * | | Explicitly select * from has_and_belongs_to_many association tables, ↵ | Raimonds Simanovskis | 2011-01-04 | 2 | -2/+3 |
| |/ | | | | | | | | | simplify exists? query Previous version (after commit 3103296a61709e808aa89c3d37cf22bcdbc5a675) was generating wrong SQL for Oracle when calling exists? method on HABTM association. |