| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | | | | | | reuse the same preloader object for each association | Aaron Patterson | 2013-09-23 | 1 | -2/+2 | |
| | | | | | | | | ||||||
| * | | | | | | | remove state from the preloader | Aaron Patterson | 2013-09-23 | 3 | -28/+18 | |
| | | | | | | | | ||||||
| * | | | | | | | pass the scope all the way down to the constructors | Aaron Patterson | 2013-09-23 | 1 | -10/+10 | |
| | | | | | | | | ||||||
| * | | | | | | | only do the should_reset test once | Aaron Patterson | 2013-09-23 | 1 | -6/+6 | |
| | | | | | | | | ||||||
| * | | | | | | | fix variable names and speed up relation ordering | Aaron Patterson | 2013-09-23 | 2 | -16/+12 | |
| | | | | | | | | ||||||
| * | | | | | | | hm:t preloading will respect order set on the RHS association | Aaron Patterson | 2013-09-23 | 6 | -8/+68 | |
| | | | | | | | | ||||||
| * | | | | | | | cache associated target records hash | Aaron Patterson | 2013-09-20 | 1 | -17/+11 | |
| | | | | | | | | ||||||
| * | | | | | | | combine methods so we can reuse preloaders | Aaron Patterson | 2013-09-20 | 1 | -19/+18 | |
| | | | | | | | | ||||||
| * | | | | | | | return a list rather than hash | Aaron Patterson | 2013-09-20 | 1 | -7/+13 | |
| | | | | | | | | ||||||
| * | | | | | | | preserve order on the RHS query | Aaron Patterson | 2013-09-20 | 1 | -0/+8 | |
| | | | | | | | | ||||||
| * | | | | | | | split up construction and mutation | Aaron Patterson | 2013-09-20 | 1 | -1/+4 | |
| | | | | | | | | ||||||
| * | | | | | | | fix method name | Aaron Patterson | 2013-09-20 | 1 | -3/+5 | |
| | | | | | | | | ||||||
| * | | | | | | | access preloaders independently of model mutations | Aaron Patterson | 2013-09-20 | 1 | -12/+12 | |
| | | | | | | | | ||||||
| * | | | | | | | push running the preloaders up | Aaron Patterson | 2013-09-20 | 1 | -19/+7 | |
| | | | | | | | | ||||||
| * | | | | | | | push `run` up to preload | Aaron Patterson | 2013-09-20 | 3 | -14/+41 | |
| | | | | | | | | ||||||
| * | | | | | | | the hash should only ever be length one, so decompose it | Aaron Patterson | 2013-09-20 | 1 | -4/+5 | |
| | | | | | | | | ||||||
| * | | | | | | | stop depending on preloader interals so we can create fewer preloader | Aaron Patterson | 2013-09-20 | 1 | -19/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | objects | |||||
| * | | | | | | | lhs preload is always a single preload, so just preload one | Aaron Patterson | 2013-09-20 | 1 | -3/+3 | |
| | | | | | | | | ||||||
| * | | | | | | | just read the attribute rather than `send`ing | Aaron Patterson | 2013-09-20 | 1 | -1/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | extract exception raising, clean up group_by statement | Aaron Patterson | 2013-09-20 | 1 | -6/+7 | |
| | | | | | | | | ||||||
| * | | | | | | | generate fewer objects when grouping | Aaron Patterson | 2013-09-20 | 1 | -5/+7 | |
| | | | | | | | | ||||||
| * | | | | | | | do not access internal data structures | Aaron Patterson | 2013-09-20 | 1 | -1/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | exposing target records on the preloader | Aaron Patterson | 2013-09-20 | 2 | -16/+29 | |
| |/ / / / / / | ||||||
| * | | | | | | remove unused variable | Aaron Patterson | 2013-09-18 | 1 | -1/+0 | |
| | | | | | | | ||||||
| * | | | | | | support objects with blank string primary keys | Aaron Patterson | 2013-09-18 | 2 | -1/+7 | |
| | | | | | | | ||||||
| * | | | | | | ActiveRecord::Base#<=> has been removed. Primary keys may not be in order, | Aaron Patterson | 2013-09-18 | 3 | -16/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or even be numbers, so sorting by id doesn't make sense. Please use `sort_by` and specify the attribute you wish to sort with. For example, change: Post.all.to_a.sort to: Post.all.to_a.sort_by(&:id) | |||||
| * | | | | | | do what the superclass does in the case that objects do not match | Aaron Patterson | 2013-09-18 | 2 | -0/+10 | |
| | | | | | | | ||||||
| * | | | | | | Merge pull request #12011 from jetthoughts/11963_fix_join_with_association_scope | Rafael Mendonça França | 2013-09-16 | 4 | -6/+25 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collapse where constraints to the Arel::Nodes::And node Conflicts: activerecord/CHANGELOG.md | |||||
| | * | | | | | | Collapse where constraints to one where constraint | Paul Nikitochkin | 2013-09-13 | 4 | -6/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to remove duplication with joining arel where constraints with `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And` Closes: #11963 | |||||
| * | | | | | | | Removes unused code related to DatabaseTasks. | kennyj | 2013-09-16 | 1 | -4/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge pull request #12129 from Empact/deprecate-array-bang-delegation | Rafael Mendonça França | 2013-09-12 | 5 | -147/+265 | |
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/relation_test.rb | |||||
| | * | | | | | | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation | Ben Woosley | 2013-09-04 | 3 | -3/+117 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary means of returning results for Array bang methods is to modify the array in-place. When you call these methods on a relation, that array is created, modified, and then thrown away. Only the secondary return value is exposed to the caller. Removing this delegation is a straight-forward way to reduce user error by forcing callers to first explicitly call #to_a in order to expose the array to be acted on by the bang method. | |||||
| | * | | | | | | | Pull the RelationMutationTests from cases/relation_test to ↵ | Ben Woosley | 2013-09-03 | 2 | -135/+139 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cases/relation/mutation_test. | |||||
| * | | | | | | | | Merge pull request #12137 from lann/fix_association_first_last | Rafael Mendonça França | 2013-09-12 | 3 | -6/+11 | |
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md | |||||
| | * | | | | | | | | Make CollectionAssociation first/last with integer fetch with query | Lann Martin | 2013-09-09 | 3 | -6/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation. | |||||
| * | | | | | | | | | Add CHANGELOG entry for #11698 | Rafael Mendonça França | 2013-09-12 | 1 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
| * | | | | | | | | | Merge pull request #11698 from dmathieu/sqlite_tasks_without_rails | Rafael Mendonça França | 2013-09-12 | 3 | -2/+4 | |
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let the SQLite rake tasks run without rails | |||||
| | * | | | | | | | | | let the sqlite task run without rails | Damien Mathieu | 2013-08-07 | 3 | -2/+4 | |
| | | | | | | | | | | | ||||||
| * | | | | | | | | | | Merge pull request #12156 from rywall/from-copy-binds | Rafael Mendonça França | 2013-09-12 | 3 | -0/+12 | |
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md | |||||
| | * | | | | | | | | | | Allow Relation#from to accept other relations with bind values. | Ryan Wallace | 2013-09-08 | 3 | -0/+12 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Remove unnecessary loop | Vipul A M | 2013-09-13 | 1 | -5/+2 | |
| | |_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | ||||||
| * | | | | | | | | | | Disable prepared statements in the unprepared_statement block | Rafael Mendonça França | 2013-09-12 | 1 | -2/+3 | |
| | | | | | | | | | | | ||||||
| * | | | | | | | | | | Fix typo on instance variable get call | Carlos Antonio da Silva | 2013-09-12 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| * | | | | | | | | | | these are not real developer objects, so counting them doesn't make | Aaron Patterson | 2013-09-11 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sense. Let's load the object to ensure it's an array and count the array. | |||||
| * | | | | | | | | | | Remove conditional adding a new method | Rafael Mendonça França | 2013-09-11 | 2 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method | |||||
| * | | | | | | | | | | Fix inverted conditional | Rafael Mendonça França | 2013-09-11 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Oops, I should had run the tests | |||||
| * | | | | | | | | | | Remove invalid comment | Rafael Mendonça França | 2013-09-11 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not valid anymore after 08477a651648ba4417ded128aa37b9ae0dcbc9ce | |||||
| * | | | | | | | | | | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 10 | -7/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | |||||
| * | | | | | | | | | | Merge pull request #12188 from SamSaffron/master | Aaron Patterson | 2013-09-11 | 4 | -12/+16 | |
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | Perf: avoid dupes add fallback logic for coders | |||||
| | * | | | | | | | | | | Perf: avoid dupes add fallback logic for coders | Sam | 2013-09-11 | 4 | -12/+16 | |
| | | | | | | | | | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activerecord