aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #16003 from sgrif/sg-refactor-sqlite3-stringsMatthew Draper2014-07-051-13/+37
|\ | | | | Use a type object for type casting behavior on SQLite3
| * Use a type object for type casting behavior on SQLite3Sean Griffin2014-07-011-13/+37
| | | | | | | | | | Note: I'm not sure we actually need to be logging when this happens. This code would be a fair bit cleaner if we didn't need to log it.
* | Merge pull request #16028 from ↵Rafael Mendonça França2014-07-043-1/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | cade/fix_counter_cache_count_with_association_selects Add `:all` argument to `count` in `reset_counters` Conflicts: activerecord/CHANGELOG.md
| * | Add `:all` argument to `count` in `reset_counters`Cade Truitt2014-07-023-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this fix, if an association had a scope with a `select`, calls to `reset_counters` would generate invalid SQL and throw: ActiveRecord::StatementInvalid: [$DB_ADAPTER]: wrong number of arguments to function COUNT() References #10710, #13648
* | | Merge pull request #16049 from matthewd/find-via-reloadMatthew Draper2014-07-053-0/+19
|\ \ \ | | | | | | | | After find-via-reload, the record is not new
| * | | After find-via-reload, the record is not newMatthew Draper2014-07-053-0/+19
| | | |
* | | | Merge pull request #16037 from sgrif/sg-money-quotingRafael Mendonça França2014-07-043-11/+28
|\ \ \ \ | |/ / / |/| | | Remove unneccessary special case for money in quoting
| * | | Remove unneccessary special case for money in quotingSean Griffin2014-07-033-11/+28
| | | |
* | | | Merge pull request #16036 from sgrif/sg-datetime-infinityRafael Mendonça França2014-07-033-3/+46
|\ \ \ \ | | | | | | | | | | Do not rely on the column type when quoting infinity
| * | | | Do not rely on the column type when quoting infinitySean Griffin2014-07-033-3/+46
| |/ / /
* / / / Use the type object for type casting HStore columnsSean Griffin2014-07-034-66/+39
|/ / /
* / / Fix typo in commentCade Truitt2014-07-021-1/+1
|/ /
* | Merge pull request #16015 from sgrif/sg-ensure-initializedRafael Mendonça França2014-07-022-4/+7
|\ \ | | | | | | | | | | | | | | | | | | Move pk initialization logic onto `AttributeSet` Conflicts: activerecord/lib/active_record/attribute_set.rb
| * | Move pk initialization logic onto `AttributeSet`Sean Griffin2014-07-022-4/+7
| | | | | | | | | | | | Better encapsulates its internals from `ActiveRecord::Base`.
* | | Quote range strings when quoting PG rangesSean Griffin2014-07-023-2/+19
| | | | | | | | | | | | | | | The test case for CVE-2014-3483 doesn't actually send the generated SQL to the database. The generated SQL is actually invalid for real inputs.
* | | Fix SQL injection when querying against ranges and bitstringsRafael Mendonça França2014-07-023-4/+16
| | | | | | | | | | | | Fix CVE-2014-3483 and protect against CVE-2014-3482.
* | | Don't error when `dup`ing a record with no PKSean Griffin2014-07-023-2/+19
|/ /
* | Revert "Merge pull request #15394 from ↵Rafael Mendonça França2014-07-023-15/+2
| | | | | | | | | | | | | | | | | | | | morgoth/fix-automatic-maintaining-test-schema-for-sql-format" This reverts commit 46139d33c06715e74ad450428ece3ee84da98579, reversing changes made to 8f247871bb18b2e3036a05df5f62cbfe3b402586. Conflicts: activerecord/CHANGELOG.md
* | Tiny follow-up to #15987 and 088b4c3e [ci skip]Robin Dupret2014-07-021-4/+4
| |
* | do not hold on to a stale connection object. fixes #15998Aaron Patterson2014-07-012-6/+14
| |
* | Add regression tests for keys on nested associationseileencodes2014-07-011-0/+32
|/ | | | | | This adds the regressions tests from issue #15893 to master. It's checking that both strings and symbols are accepted as keys for nested associations.
* Don't add a second method for attribute existenceSean Griffin2014-06-301-6/+1
| | | | | We already had one in the public API that people can use more easily for the transition
* Move STI docs off of the main Base document, leaving a noteSean Griffin2014-06-302-28/+34
|
* Update documentation on STI change handlingjamesprior2014-06-301-0/+9
| | | Documenting a potential source of confusion about how STI classes handle changes.
* Merge pull request #15981 from sgrif/sg-simplify-defaultsRafael Mendonça França2014-06-293-21/+9
|\ | | | | Simplify creation of default attributes on AR instance
| * Simplify creation of default attributes on AR instanceSean Griffin2014-06-294-21/+10
| | | | | | | | `AttributeSet#dup` has all the behavior we need.
* | Merge pull request #15977 from sgrif/sg-remove-array-hackGodfrey Chan2014-06-291-24/+0
|\ \ | | | | | | Remove array workaround in PG quoting
| * | Remove array workaround in PG quotingSean Griffin2014-06-291-24/+0
| | | | | | | | | | | | | | | We no longer need to do fancy legwork to make sure arrays use a type object, now that schema methods use a real type object.
* | | Remove unused `array_member` from PG quoting for HStore columnsSean Griffin2014-06-292-12/+9
|/ / | | | | | | | | Hstore no longer needs additional quoting to be used in an array, the array type handles it sufficiently.
* | Merge pull request #15983 from sgrif/sg-inline-pointGodfrey Chan2014-06-293-19/+9
|\ \ | | | | | | Use the type object when sending point columns to the DB
| * | Use the type object when sending point columns to the DBSean Griffin2014-06-293-19/+9
| | |
* | | Merge pull request #15976 from sgrif/sg-attribute-existsGodfrey Chan2014-06-291-2/+7
|\ \ \ | |/ / |/| | Don't encourage usage of `columns_hash`
| * | Don't encourage usage of `columns_hash`Sean Griffin2014-06-291-2/+7
| |/ | | | | | | | | | | | | | | | | As discussed in https://github.com/plataformatec/simple_form/pull/1094, we should not encourage usage of `columns_hash`, and instead provide an alternate method to determine whether or not an attribute exists. The language `attribute` was chosen over `column` since these are in the `AttributeMethods` module.
* | Merge pull request #15982 from sgrif/sg-attr-set-map-valuesGodfrey Chan2014-06-292-7/+4
|\ \ | | | | | | Use `Hash#transform_values` to clean up `AttributeSet`
| * | Use `Hash#transform_values` to clean up `AttributeSet`Sean Griffin2014-06-292-7/+4
| |/
* / Use the type object for sending JSON to the databaseSean Griffin2014-06-294-23/+11
|/
* Always pass a column with a type object to quoteSean Griffin2014-06-288-28/+25
| | | | | | | | The only case where we got a column that was not `nil`, but did not respond to `cast_type` was when type casting the default value during schema creation. We can look up the cast type, and add that object to the column definition. Will allow us to consistently rely on the type objects for type casting in all directions.
* [Postgresql tests] remove duplicate helperAbdelkader Boudih2014-06-281-12/+3
|
* MySQL doesn't work with foreign keysPhilippe Creux2014-06-271-1/+4
| | | | | | This was previously fixed in e84799d but broken in 3f596f8. This commit reintroduced the conditional that prevents the foreign keys from being added to MySQL databases.
* Fix test with add_foreign_key DSL in 9d21ef9Philippe Creux2014-06-271-1/+1
|
* Merge pull request #15934 from seuros/renameRafael Mendonça França2014-06-273-3/+17
|\ | | | | | | rename primary key sequence only if it exists
| * rename sequence only if it existsAbdelkader Boudih2014-06-273-3/+17
| |
* | Do not change the global state of the test suiteRafael Mendonça França2014-06-272-18/+2
| |
* | Improve tests to use add_foreign_key DSLRafael Mendonça França2014-06-271-18/+11
| |
* | MySQL doesn't works with foreign keyRafael Mendonça França2014-06-271-3/+2
|/
* Merge pull request #12450 from iantropov/masterRafael Mendonça França2014-06-275-5/+59
|\ | | | | | | | | | | | | | | | | Fix bug, when ':dependent => :destroy' violates foreign key constraints Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/has_one.rb
| * Fix bug, when ':dependent => :destroy' option violates foreign key ↵Ivan Antropov2013-10-265-9/+61
| | | | | | | | constraints, issue #12380
* | Merge pull request #15788 from sgrif/sg-mutable-stringsRafael Mendonça França2014-06-275-13/+77
|\ \ | | | | | | | | | Detect in-place modifications on Strings
| * | Detect in-place modifications on StringsSean Griffin2014-06-174-13/+55
| | |
* | | Merge pull request #8639 from bogdan/valid-with-bangRafael Mendonça França2014-06-273-1/+36
|\ \ \ | | | | | | | | | | | | Add AR::Base#valid! method
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-28 23:30:52 +0000