aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* avoid deprecated methodsAaron Patterson2011-12-061-1/+1
|
* add prefix and suffix to renamed tables, closes #1510Vasiliy Ermolovich2011-12-064-0/+52
|
* Quitoting the table name before querying.Aaron Patterson2011-12-051-1/+1
|
* Speed up table_exists? for databases with a large number of tablesJade Rubick2011-12-051-1/+6
| | | | | | At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time. The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors.
* Merge pull request #3854 from exviva/validates_associated_marked_for_destructionJosé Valim2011-12-042-2/+13
|\ | | | | Do not validate associated records marked for destruction
| * Do not validate associated records marked for destructionOlek Janiszewski2011-12-052-2/+13
| | | | | | | | | | | | The main reason for this change is to fix a bug where `validates_associated` would prevent `accepts_nested_attributes_for` with `allow_destroy: true` from destroying invalid associated records.
* | Merge pull request #3851 from ebeigarts/fix_sequence_nameJon Leighton2011-12-042-2/+12
|\ \ | |/ |/| Fix sequence name with abstract classes.
| * Fix sequence name with abstract classes.Edgars Beigarts2011-12-042-2/+12
| |
* | moves some auto explain logic to the subscriber [José Valim & Xavier Noria]Xavier Noria2011-12-042-19/+12
| |
* | simplifies ActiveRecord::ExplainSubscriber [José Valim & Xavier Noria]Xavier Noria2011-12-041-8/+6
| |
* | Merge branch 'explain'Xavier Noria2011-12-046-84/+93
|\ \ | |/ |/|
| * implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xavier Noria]Xavier Noria2011-12-046-84/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit vastly reduces the impact of auto explain logging when enabled, while keeping a negligible cost when disabled. The first implementation was based on the idea of subscribing to "sql.active_record" when needed, and unsubscribing once done. This is the idea behind AR::Relation#explain. Subscribe, collect, unsubscribe. But with the current implementation of notifications unsubscribing is costly, because it wipes an internal cache and that puts a penalty on the next event. So we are switching to an approach where a long-running subscriber is listening. Instead of collecting the queries with a closure in a dedicated subscriber, now we setup a thread local. If the feature is disabled by setting the threshold to nil, the subscriber will call a method that does nothing. That's totally cheap.
* | Refactor readonly attributes conditionalCarlos Antonio da Silva2011-12-041-1/+2
|/
* SQlite3 Bump Arun Agrawal2011-12-041-1/+1
|
* Add missing requireJon Leighton2011-12-031-0/+2
|
* Avoid postgres 9.X syntaxJon Leighton2011-12-031-1/+5
|
* Fix #3837.Jon Leighton2011-12-032-11/+17
| | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access.
* removes the convenience instance version of AR::Base.silence_auto_explainXavier Noria2011-12-034-96/+83
| | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled.
* Merge pull request #3820 from jaylevitt/nested_loading_through_assocJon Leighton2011-12-032-1/+36
|\ | | | | reintroduce patch from #726 to handle nested eager loading via associations
| * reintroduce patch from #726 to handle nested eager loading via associationsJay Levitt2011-11-302-1/+36
| |
* | Merge pull request #3833 from kennyj/fix_3678-3Jon Leighton2011-12-031-3/+8
|\ \ | | | | | | Use show create table (fix 3678: third time).
| * | Use show create table.kennyj2011-12-031-3/+8
| | |
* | | yield > block.callXavier Noria2011-12-021-3/+3
| | |
* | | two small details from the previous patchXavier Noria2011-12-021-1/+1
| | |
* | | implements AR::Base(.|#)silence_auto_explainXavier Noria2011-12-024-61/+105
| | |
* | | indentation fix warningArun Agrawal2011-12-021-1/+1
|/ /
* | revises some details in the previous explain patchXavier Noria2011-12-022-3/+3
| |
* | Revert "Roflscaling!" (for now)Jon Leighton2011-12-022-8/+11
| | | | | | | | | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.)
* | implements automatic EXPLAIN logging for slow queriesXavier Noria2011-12-0211-95/+316
| |
* | Fewer string allocations in attribute methodJon Leighton2011-12-011-4/+4
| |
* | Roflscaling!Jon Leighton2011-12-012-11/+8
| | | | | | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster.
* | Create method with known identifier then alias into place.Jon Leighton2011-12-012-25/+23
| | | | | | | | | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.)
* | Remove some unnecessary code etcJon Leighton2011-12-012-26/+11
| |
* | Add test for read_attribute(:id) with non-standard PK.Jon Leighton2011-12-013-4/+23
| | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go.
* | Remove the need for type_cast_attribute.Jon Leighton2011-12-015-43/+52
| | | | | | | | This is good because it reduces duplication.
* | Fix up test altering global state that was causing me griefJon Leighton2011-12-011-2/+4
| |
* | Get rid of the underscore versions of attribute methods!Jon Leighton2011-12-016-6/+40
| | | | | | | | This makes me happy!
* | Don't rely on underscore-prefixed attribute methods.Jon Leighton2011-12-013-48/+80
| | | | | | | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o
* | Remove unnecessary *argsJon Leighton2011-12-011-2/+2
| |
* | Allow rescue responses to be configured through a railtie.José Valim2011-12-011-0/+7
| |
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵Jon Leighton2011-12-012-0/+25
| | | | | | | | changes to attribute serialization.
* | don't alter global state in testJon Leighton2011-11-301-2/+3
| |
* | If the table behind has no primary key, do not ask again and just return nil.Julius de Bruijn2011-11-302-1/+7
| |
* | consistencyJon Leighton2011-11-303-16/+16
| |
* | Don't check column type, you might implement a custom coder that serializes ↵Jon Leighton2011-11-301-1/+1
| | | | | | | | to a different type
* | omg computer science!Jon Leighton2011-11-304-29/+47
| | | | | | | | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it.
* | Fix typoJon Leighton2011-11-301-2/+2
| |
* | Don't need second paramJon Leighton2011-11-302-4/+4
| |
* | No longer need to undef id as we are defining it ourselvesJon Leighton2011-11-301-3/+0
| |
* | Move some serialization stuff out of BaseJon Leighton2011-11-302-40/+42
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 17:01:37 +0000