| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | | Fix multidimensional PG arrays containing non-string items | Yves Senn | 2013-08-07 | 3 | -15/+32 | |
| | | | | ||||||
| * | | | skip `test_unicode_column_name` for `MysqlAdapter`. | Yves Senn | 2013-08-07 | 1 | -3/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the build but we need to further investigate the root cause, to see if it can be fixed. The test fails under `MysqlAdapter` with: ``` ActiveRecord::UnknownAttributeError: unknown attribute: なまえ ``` The root cause is that the returned column names from the adapter have the wrong encoding: ```ruby columns = Weird.columns_hash.keys columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"] columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>] columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"] ``` From what I can tell the MySQL variables are fine: ``` ActiveRecord::Base.connection.execute("show variables") ... character_set_client utf8 character_set_connection utf8 character_set_database utf8 character_set_filesystem binary character_set_results utf8 character_set_server utf8 character_set_system utf8 character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/ collation_connection utf8_general_ci collation_database utf8_unicode_ci collation_server utf8_general_ci ... ``` | |||||
| * | | | test to express that we can't turn non-array columns to array columns. | Yves Senn | 2013-08-06 | 1 | -0/+9 | |
| | | | | | | | | | | | | | Closes #11062 | |||||
| * | | | Use the proper encoding comment on the file | Rafael Mendonça França | 2013-08-06 | 1 | -0/+2 | |
| | | | | ||||||
| * | | | Fix indentation | Rafael Mendonça França | 2013-08-06 | 1 | -3/+2 | |
| | | | | ||||||
| * | | | asakusa.rb hack night! | Aaron Patterson + Akira Matsuda | 2013-08-06 | 2 | -0/+5 | |
| | | | | | | | | | | | | | Fix in-memory tests | |||||
| * | | | Add CHANGELOG entry for #11767 | Rafael Mendonça França | 2013-08-06 | 1 | -0/+4 | |
| | | | | | | | | | | | | | [ci skip] | |||||
| * | | | adding a weird test case | Aaron Patterson | 2013-08-06 | 2 | -0/+8 | |
| | | | | ||||||
| * | | | config[:database] should be a string | Rafael Mendonça França | 2013-08-05 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969 | |||||
| * | | | Remove deprecated branch on the scope method. | Rafael Mendonça França | 2013-08-05 | 1 | -6/+2 | |
| | | | | | | | | | | | | | The deprecation message was removed on 50cbc03d18c5984347965a94027879623fc44cce but the code was not. | |||||
| * | | | Merge pull request #11767 from kassio/master-load-fixtures-from-linked-folder | Rafael Mendonça França | 2013-08-05 | 5 | -4/+17 | |
| |\ \ \ | | | | | | | | | Load fixtures from linked folders[master] | |||||
| | * | | | load fixtures from linked folders | Kassio Borges | 2013-08-05 | 5 | -4/+17 | |
| | | | | | ||||||
| * | | | | Merge pull request #11762 from peterkovacs/patch-2 | Carlos Antonio da Silva | 2013-08-05 | 1 | -1/+1 | |
| |\ \ \ \ | | | | | | | | | | | Free result_metadata directly instead of freeing 2nd, redundant call. | |||||
| | * | | | | Free result_metadata directly instead of freeing 2nd, redundant call. | Peter Kovacs | 2013-08-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | `result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it. | |||||
| * | | | | | Create sqlite3 directory if not present | schneems | 2013-08-05 | 3 | -3/+30 | |
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim | |||||
| * | | | | Merge pull request #11693 from egilburg/minor_relation_refactor | Rafael Mendonça França | 2013-08-04 | 1 | -38/+45 | |
| |\ \ \ \ | | | | | | | | | | | Minor optimization and code cleanup in query_methods.rb | |||||
| | * | | | | Minor optimization and code cleanup in query_methods. | Eugene Gilburg | 2013-07-31 | 1 | -38/+45 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use symbols rather than strings where possible to avoid extra object construction - Use destructive methods where possible to avoid extra object construction - Use array union rather than concat followed by uniq - Use shorthand block syntax where possible - Use consistent multiline block styles, method names, method parenteses style, and spacing | |||||
| * | | | | | Merge pull request #11740 from Karunakar/self_table | Rafael Mendonça França | 2013-08-03 | 1 | -2/+2 | |
| |\ \ \ \ \ | | | | | | | | | | | | | Changing the def self.table_name to self.table_name in the column_name.r... | |||||
| | * | | | | | Changing the def self.table_name to self.table_name in the column_name.rb | Karunakar (Ruby) | 2013-08-03 | 1 | -2/+2 | |
| | | | | | | | ||||||
| * | | | | | | Merge pull request #11741 from Karunakar/failing_test_in_local | Rafael Mendonça França | 2013-08-03 | 1 | -1/+1 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | fix for postgresql failing test in local | |||||
| | * | | | | | | fix for postgresql failing test in local | Karunakar (Ruby) | 2013-08-04 | 1 | -1/+1 | |
| | |/ / / / / | ||||||
| * / / / / / | use flat_map | Neeraj Singh | 2013-08-03 | 1 | -1/+1 | |
| |/ / / / / | ||||||
| * | / / / | add a test for concat on hm:t associations | Aaron Patterson | 2013-08-02 | 1 | -0/+7 | |
| | |/ / / |/| | | | ||||||
| * | | | | Merge pull request #11455 from antonio/fix_enable_extension_not_being_defined | Rafael Mendonça França | 2013-08-02 | 3 | -0/+32 | |
| |\ \ \ \ | | | | | | | | | | | Define enable_extension method to prevent undefined method error | |||||
| | * | | | | Define enable_extension method to prevent undefined method error | Antonio Santos | 2013-08-02 | 3 | -0/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it. | |||||
| * | | | | | Use assert_nil instead of testing for equality | Carlos Antonio da Silva | 2013-08-02 | 2 | -3/+2 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #11714 from jetthoughts/11706_remove_bad_override_of_xml | Rafael Mendonça França | 2013-08-02 | 3 | -7/+47 | |
| |\ \ \ \ \ | | | | | | | | | | | | | Removed redundant xml override from pg adapter | |||||
| | * | | | | | Removed redundant xml override from pg adapter | Paul Nikitochkin | 2013-08-02 | 3 | -7/+47 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Closes: #11706 | |||||
| * | | | | | | Use map! to avoid an extra object creation | Carlos Antonio da Silva | 2013-08-02 | 1 | -1/+1 | |
| | | | | | | | ||||||
| * | | | | | | Remove useless begin..end | Carlos Antonio da Silva | 2013-08-02 | 1 | -2/+1 | |
| | | | | | | | ||||||
| * | | | | | | fix the changelog typo[ci skip] | Rajarshi Das | 2013-08-02 | 1 | -1/+1 | |
| |/ / / / / | ||||||
| * | | | | | extract habtm handling to a method | Aaron Patterson | 2013-08-01 | 1 | -8/+12 | |
| | | | | | | ||||||
| * | | | | | use drop and avoid a range object | Aaron Patterson | 2013-08-01 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | Change test_registering_new_handlers and test_count_on_invalid_columns_raises | Yasuo Honda | 2013-08-02 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | tesetcases assertion to case insensitive because Oracle database adapter handles table name in uppercase. | |||||
| * | | | | | remove intermediate assignments | Aaron Patterson | 2013-08-01 | 2 | -7/+4 | |
| | | | | | | ||||||
| * | | | | | push option handling "chrome" outside `initialize` | Aaron Patterson | 2013-08-01 | 1 | -8/+7 | |
| | | | | | | ||||||
| * | | | | | remove `valid_options` class method | Aaron Patterson | 2013-08-01 | 1 | -4/+3 | |
| | | | | | | ||||||
| * | | | | | association builder classes no longer need the model | Aaron Patterson | 2013-08-01 | 3 | -8/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now. | |||||
| * | | | | | remove more mutations from the `build` method | Aaron Patterson | 2013-08-01 | 1 | -7/+2 | |
| | | | | | | ||||||
| * | | | | | make mutation method apis more consistent | Aaron Patterson | 2013-08-01 | 2 | -4/+5 | |
| | | | | | | ||||||
| * | | | | | push more mutations outside the factory method | Aaron Patterson | 2013-08-01 | 2 | -8/+6 | |
| | | | | | | ||||||
| * | | | | | push module building to the constructor | Aaron Patterson | 2013-08-01 | 1 | -14/+20 | |
| | | | | | | ||||||
| * | | | | | users should be warned if clobbering constants | Aaron Patterson | 2013-08-01 | 1 | -3/+1 | |
| | | | | | | ||||||
| * | | | | | no need to define the constant twice | Aaron Patterson | 2013-08-01 | 1 | -1/+0 | |
| | | | | | | ||||||
| * | | | | | this code is dead, removing | Aaron Patterson | 2013-08-01 | 1 | -6/+0 | |
| | | | | | | ||||||
| * | | | | | defning extensions happens once, no need to cache | Aaron Patterson | 2013-08-01 | 1 | -5/+3 | |
| | | | | | | ||||||
| * | | | | | assert that constants have been set rather than the names | Aaron Patterson | 2013-08-01 | 2 | -9/+11 | |
| | | | | | | ||||||
| * | | | | | remove dead code | Aaron Patterson | 2013-08-01 | 1 | -4/+0 | |
| | | | | | | ||||||
| * | | | | | pushing out more callback definitions | Aaron Patterson | 2013-08-01 | 1 | -2/+6 | |
| | | | | | | ||||||
| * | | | | | push more mutations out of the builder | Aaron Patterson | 2013-08-01 | 2 | -12/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | `configure_dependency` actually defined callbacks, so rename the method and move it to the appropriate method. | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activerecord